chore(upgrade): v1.10.0 to v1.11.0 by enddynayn · Pull Request #2117 · frequency-chain/frequency

enddynayn · 2024-08-08T16:03:06Z

Upgrade Polkadot-sdk 1.10.0 to 1.11.0
Update weights to reflect the new version.

Notable Changes:

For more details, please refer to:

Release Notes

#1957

codecov · 2024-08-08T22:10:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

enddynayn · 2024-08-12T20:57:57Z

I’ve split off the Omni Benchmarker CI updates into a follow-up PR.

deny.toml

shannonwells

I reviewed weights changes, and ran make start. I ran all the rust tests. I could not run make start-paseo-relay because of broken docker files (not a regression).
I could not get e2e tests to run locally and they would not recognize a running local frequency instance:
Unable to find or start a Frequency node; aborting.

e2e/capacity/capacity_rpc.test.ts

runtime/common/src/weights/extrinsic_weights.rs

shannonwells · 2024-08-13T00:41:26Z

runtime/common/src/weights/pallet_preimage.rs

 		//  Estimated: `5041`
-		// Minimum execution time: 47_210_000 picoseconds.
-		Weight::from_parts(48_322_000, 5041)
+		// Minimum execution time: 66_888_000 picoseconds.


Noting large weight changes throughout this file.

runtime/frequency/genesis_config_presets.rs

shannonwells · 2024-08-13T00:53:22Z

node/service/src/chain_spec/frequency_dev.rs

-			get_account_id_from_seed::<sr25519::Public>("Bob"),
-			get_account_id_from_seed::<sr25519::Public>("Dave"),
-		],
+		development_invulnerables(),


enddynayn · 2024-08-13T13:27:12Z

I reviewed weights changes, and ran make start. I ran all the rust tests. I could not run make start-paseo-relay because of broken docker files (not a regression). I could not get e2e tests to run locally and they would not recognize a running local frequency instance: Unable to find or start a Frequency node; aborting.

Thanks for double checking. How are you running the e2e tests? I was able to run them using make e2e-tests.

saraswatpuneet

read through the changes

Mostly appear to be updates/refactor
Existing comments are useful and can be addressed

Lgtm

- Upgrade Polkadot-sdk 1.10.0 to 1.11.0 - Update weights to reflect the new version. Notable Changes: - [Apply patch `run_with_spec`](paritytech/polkadot-sdk#3512) - [Genesis Presets](paritytech/polkadot-sdk#2714) - [Integrate LiteP2P](paritytech/polkadot-sdk#2944) - [Template Simplification](https://github.com/paritytech/polkadot-sdk/pull/3801/files) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.11.0) issue-1957

JoeCap08055

Pull branch
Built & ran unit tests
Built & ran e2e tests

Looks good!

mattheworris · 2024-08-13T17:22:43Z

node/service/src/service.rs

 /// Build the import queue for the parachain runtime.
 #[cfg(not(feature = "frequency-no-relay"))]
+/// Build the import queue for the parachain runtime.


One of these is not needed:

Suggested change

/// Build the import queue for the parachain runtime.

#[cfg(not(feature = "frequency-no-relay"))]

/// Build the import queue for the parachain runtime.

#[cfg(not(feature = "frequency-no-relay"))]

/// Build the import queue for the parachain runtime.

Nice catch! I’ll update this in my follow-up PR to avoid triggering the CI again.

mattheworris · 2024-08-13T17:26:06Z

node/service/src/service.rs

 }
-
-/// Start a parachain node.
-#[cfg(any(not(feature = "frequency-no-relay"), feature = "frequency-lint-check"))]


Nice cleanup.

mattheworris · 2024-08-13T17:26:56Z

pallets/frequency-tx-payment/src/tests/mock.rs

 impl pallet_transaction_payment::Config for Test {
 	type RuntimeEvent = RuntimeEvent;
-	type OnChargeTransaction = CurrencyAdapter<Balances, ()>;
+	type OnChargeTransaction = FungibleAdapter<Balances, ()>;


Bye, bye Currency. 🤓

mattheworris

Read through Polkadot Release notes.
Read through code changes.

Looks good, nice work!

🚢 it!

shannonwells

Looks like my test run is a local problem. Approved!

aramikm

Read the code and looked good. Just some questions.

aramikm · 2024-08-13T17:36:00Z

node/cli/Cargo.toml

 sp-keyring = { workspace = true }
 sp-runtime = { workspace = true }
 sp-timestamp = { workspace = true }
-try-runtime-cli = { workspace = true, optional = true }


nit: Would you mind explaining why is this removed?

Good question. I missed including that in the PR description. There’s now a standalone CLI, which is a result of this Polkadot-sdk issue.

aramikm · 2024-08-13T17:39:18Z

node/cli/src/run_as_parachain.rs

-			AccountIdConversion::<polkadot_primitives::AccountId>::into_account_truncating(&id);

-		info!("Parachain id: {:?}", id);
-		info!("Parachain Account: {}", parachain_account);


no more parachain account?

Yes, I think this might be leftover code since it was only used for logging. The PR description where Parity removed it doesn’t provide a clear explanation.
Link to the PR.

- Upgrade Polkadot-sdk 1.10.0 to 1.11.0 - Update weights to reflect the new version. Notable Changes: - [Apply patch `run_with_spec`](paritytech/polkadot-sdk#3512) - [Genesis Presets](paritytech/polkadot-sdk#2714) - [Integrate LiteP2P](paritytech/polkadot-sdk#2944) - [Template Simplification](https://github.com/paritytech/polkadot-sdk/pull/3801/files) - [Remove try-runtime-cli](https://github.com/paritytech/polkadot-sdk/pull/4017/files#diff-3a3aa5e088741f8ab1ca38fbe314c7a150d18b7466426f4ad2569113017e8439) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.11.0)

enddynayn force-pushed the chore/upgrade-polkadot-v1.10.0-to-v1.11.0-issue-1957 branch from 8e515fd to 118cc6d Compare August 8, 2024 16:03

enddynayn force-pushed the chore/upgrade-polkadot-v1.10.0-to-v1.11.0-issue-1957 branch 2 times, most recently from 2ad5baf to 3e72965 Compare August 8, 2024 22:20

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 8, 2024

enddynayn force-pushed the chore/upgrade-polkadot-v1.10.0-to-v1.11.0-issue-1957 branch from 5336cf4 to 5b6de32 Compare August 9, 2024 15:31

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 9, 2024

enddynayn force-pushed the chore/upgrade-polkadot-v1.10.0-to-v1.11.0-issue-1957 branch 5 times, most recently from f3f6b24 to d172134 Compare August 12, 2024 19:42

enddynayn changed the title ~~Chore/upgrade polkadot v1.10.0 to v1.11.0 issue 1957~~ chore(upgrade): v1.10.0 to v1.11.0 Aug 12, 2024

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 12, 2024

enddynayn force-pushed the chore/upgrade-polkadot-v1.10.0-to-v1.11.0-issue-1957 branch from d172134 to f5f10cc Compare August 12, 2024 20:56

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Aug 12, 2024

enddynayn marked this pull request as ready for review August 12, 2024 20:58

enddynayn requested a review from wilwade as a code owner August 12, 2024 20:58

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 12, 2024

shannonwells reviewed Aug 13, 2024

View reviewed changes

deny.toml Outdated Show resolved Hide resolved

shannonwells reviewed Aug 13, 2024

View reviewed changes

enddynayn force-pushed the chore/upgrade-polkadot-v1.10.0-to-v1.11.0-issue-1957 branch from 237200e to 29997b2 Compare August 13, 2024 13:21

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Aug 13, 2024

enddynayn force-pushed the chore/upgrade-polkadot-v1.10.0-to-v1.11.0-issue-1957 branch from 29997b2 to 8ac302c Compare August 13, 2024 13:24

enddynayn requested review from aramikm, claireclark1, mattheworris, saraswatpuneet and shannonwells August 13, 2024 13:27

saraswatpuneet approved these changes Aug 13, 2024

View reviewed changes

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 13, 2024

enddynayn force-pushed the chore/upgrade-polkadot-v1.10.0-to-v1.11.0-issue-1957 branch from 8ac302c to f1e3247 Compare August 13, 2024 14:24

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 13, 2024

JoeCap08055 approved these changes Aug 13, 2024

View reviewed changes

mattheworris reviewed Aug 13, 2024

View reviewed changes

mattheworris approved these changes Aug 13, 2024

View reviewed changes

shannonwells approved these changes Aug 13, 2024

View reviewed changes

aramikm approved these changes Aug 13, 2024

View reviewed changes

enddynayn merged commit 404a1e4 into main Aug 13, 2024

enddynayn deleted the chore/upgrade-polkadot-v1.10.0-to-v1.11.0-issue-1957 branch August 13, 2024 18:02

This was referenced Aug 14, 2024

chore: upgrade to 1.11.0 r0gue-io/pop-node#189

Merged

chore: upgrade to 1.12.0 r0gue-io/pop-node#193

Merged

Conversation

enddynayn commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Aug 8, 2024

Codecov Report

Uh oh!

enddynayn commented Aug 12, 2024

Uh oh!

Uh oh!

shannonwells left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

enddynayn commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saraswatpuneet left a comment

Choose a reason for hiding this comment

Uh oh!

JoeCap08055 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mattheworris left a comment

Choose a reason for hiding this comment

Uh oh!

shannonwells left a comment

Choose a reason for hiding this comment

Uh oh!

aramikm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

enddynayn commented Aug 8, 2024 •

edited

Loading

enddynayn commented Aug 13, 2024 •

edited

Loading