Conversation
Upgrade Polkadot version from 1.7.0 to 1.8.0
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #178 +/- ##
=========================================
- Coverage 10.60% 6.40% -4.20%
=========================================
Files 27 27
Lines 2132 1997 -135
Branches 2132 1997 -135
=========================================
- Hits 226 128 -98
+ Misses 1906 1869 -37
|
Upgrade Polkadot version from 1.7.0 to 1.8.0
chungquantin
requested review from
al3mart and
peterwht
and removed request for
al3mart and
peterwht
Co-authored-by: Peter White <petras9789@gmail.com>
Daanvdplas
left a comment
Daanvdplas
left a comment
There was a problem hiding this comment.
Well done Tin! We are almost there! I left a few last things two check and I think we forgot the storage reclaim.
Some of the non-polkadot-sdk dependencies are not on the correct version. If you could compare them with the base-parachain on 1.14.
Daanvdplas
left a comment
Daanvdplas
left a comment
There was a problem hiding this comment.
I'm getting an error when using try-runtime
|
I'm afraid there are multiple migrations required for pallet contracts. Automatic migration is what we are doing now and can only happen with single migrations. Edit: the pallet version is 15 so there should only be needed one (ED deposit migration) Not sure why it doesn't work |
|
#222 Fixed the above. |
| // from contract layer to substrate layer. | ||
| // reference: https://github.com/paritytech/ink-examples/blob/b8d2caa52cf4691e0ddd7c919e4462311deb5ad0/psp22-extension/runtime/psp22-extension-example.rs#L236 | ||
| let overhead = contract_host_weight.debug_message; | ||
| // reference: https://github.com/paritytech/polkadot-sdk/pull/4233/files#:~:text=DebugMessage(len)%20%3D%3E%20T%3A%3AWeightInfo%3A%3Aseal_debug_message(len)%2C |
There was a problem hiding this comment.
Great work updating those references Tin!
Co-authored-by: Peter White <petras9789@gmail.com> Co-authored-by: Daanvdplas <daanvdplas@live.nl> Co-authored-by: Alejandro Martinez Andres <11448715+al3mart@users.noreply.github.com>
4 participants
Link to issue: #141
Upgrade guidelines
major.minor.patchtodeveloper, the nextmajor.<minor + 1>.patchwill be rebased todeveloperand asking for approvals from the reviewers again.List of pull requests (merge in order)