-
Notifications
You must be signed in to change notification settings - Fork 3k
chore: Never use wildcard imports #45372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Next, disable wildcard imports: navigate to Editor -> Code Style -> Java -> Imports and set Class count to use import with '*' to 999. Do the same with Names count to use static import with '*'.
|
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
|
@geoand is this helpful to avoid the manual interaction? |
server properties no longer works with auto-config
This is done because I assume that was the original intent, but also because it avoids the non-zero cost incurred by Vert.x to look up the various supported options
They both have the same result starting with 23.1. Runtime initialization is public API while rerun is not, and will soon be deprecated and at some point removed in future releases. See oracle/graal#5013 (comment) and oracle/graal#8323
This change does not have any impact in Mandrel/GraalVM for JDK 21 and later versions, but allows Quarkus to build with Mandrel/GraalVM for JDK 17.
Starting with Mandrel/GraalVM for JDK 21 `RuntimeReinitializedClassBuildItem` is functionally the same with `RuntimeInitializedClassBuildItem`.
In a traditional blocking and synchronous framework the opentelemetry context is attached to ThreadLocal. In reactive programming, where multiple processings share the same event-loop thread, one has to use Vert.x duplicated contexts instead (see https://quarkus.io/guides/duplicated-context). wrapWithSpan ensures that the pipeline is executed on a duplicated context (If the current context already is duplicated, it will stay the same. Therefore, nested calls to wrapWithSpan will all run on the same vert.x context). inspired by Jan Peremsky (https://github.com/jan-peremsky/quarkus-reactive-otel/blob/c74043d388ec4df155f466f1d6938931c3389b70/src/main/java/com/fng/ewallet/pex/Tracer.java) and edeandrea (https://github.com/quarkusio/quarkus-super-heroes/blob/main/event-statistics/src/main/java/io/quarkus/sample/superheroes/statistics/listener/SuperStats.java) suggestions from review I will squash with the previous commit once everything is approved suggestion from reviewer todo: squash when everything is done -> adapt commit message. In this solution span and scope are local variables. no need for a stack. unnecessary line removed fix test to run on different contexts again cleanup
Add helper methods for manual spans in mutiny pipelines
Bump strimzi-test-container version from 0.107.0 to 0.109.1
Use VertxLogDelegateFactory for internal Vert.x logging
…eads This is going to be useful once netty/netty#14155 lands in Quarkus.
…se-vertx-when-possible OIDC: reuse shared Vert.x instance in DEV and test mode whenever it is possible
…t-with-dev-svc-for-oidc OIDC: document and use OidcTestClient to get access token from Dev Services for OIDC
Switch to runtime initialization instead of rerun
Next, disable wildcard imports: navigate to Editor -> Code Style -> Java -> Imports and set Class count to use import with '*' to 999. Do the same with Names count to use static import with '*'.
# Conflicts: # .editorconfig # pom.xml
|
🙈 The PR is closed and the preview is expired. |
|
this is very interesting for quarkus as the eclipse plugin is already in use: https://www.baeldung.com/java-maven-spotless-plugin#custom-formatting-rules
maven fixes the checkstyle isses with spot out of the box its very nice to have this smart setup. |
|
let me know if you want to see demo like currently done in check. |

Convention over configuration -> auto config over manual config:
Next, disable wildcard imports:
navigate to Editor -> Code Style -> Java -> Imports
and set Class count to use import with '*' to
999. Do the same with Names count to use static import with '*'.https://stackoverflow.com/a/67844641/3388213
enforce with plugin: https://github.com/ec4j/editorconfig-maven-plugin
with * import
without *