Skip to content

PoC: integrate Eclipse Formatter Profile into Maven Spotless Plugin #48041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

PoC: integrate Eclipse Formatter Profile into Maven Spotless Plugin #48041

wants to merge 1 commit into from

Conversation

@Pankraz76
Copy link

@Pankraz76 Pankraz76 commented May 24, 2025 •
edited
Loading

issue

references:

unused:
image

[ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.44.4:check (spotless-check) on project quarkus-smallrye-context-propagation: The following files had format violations:
[ERROR]     src/main/java/io/quarkus/smallrye/context/runtime/SmallRyeContextPropagationRecorder.java
[ERROR]         @@ -12,7 +12,6 @@
[ERROR]          
[ERROR]          import·org.eclipse.microprofile.context.ManagedExecutor;
[ERROR]          import·org.eclipse.microprofile.context.ThreadContext;
[ERROR]         -import·org.eclipse.microprofile.context.spi.ContextManager.Builder;
[ERROR]          import·org.eclipse.microprofile.context.spi.ContextManagerExtension;
[ERROR]          import·org.eclipse.microprofile.context.spi.ContextManagerProvider;
[ERROR]          import·org.eclipse.microprofile.context.spi.ThreadContextProvider;
[ERROR] Run 'mvn spotless:apply' to fix these violations.
[ERROR] -> [Help 1]

check:
Pasted Graphic

apply:
Pasted Graphic 1

@Pankraz76 Pankraz76 mentioned this pull request May 24, 2025
Closed
@quarkus-bot
Copy link

quarkus-bot bot commented May 24, 2025

/cc @gsmet (hibernate-orm)

Pankraz76
Pankraz76 commented May 24, 2025
View reviewed changes
Pankraz76
Pankraz76 commented May 24, 2025
View reviewed changes
@Pankraz76
Copy link
Author

Pankraz76 commented May 24, 2025

is this any good? @geoand

This was referenced May 24, 2025
Closed
Open
Closed
Pankraz76
Pankraz76 commented May 24, 2025
View reviewed changes
Pankraz76
Pankraz76 commented May 24, 2025
View reviewed changes
@Pankraz76
Copy link
Author

Pankraz76 commented May 24, 2025

see old commits for actual changes.

This was referenced May 25, 2025
Open
Closed
@geoand
Copy link
Contributor

geoand commented May 26, 2025

I am assuming that this change will result in the source being reformated a lot when the build is run. If that indeed happens, we don't want that.

@quarkus-bot quarkus-bot bot added the area/jdbc Issues related to the JDBC extensions label May 30, 2025
Pankraz76
Pankraz76 commented May 30, 2025
View reviewed changes
Pankraz76
Pankraz76 commented May 30, 2025
View reviewed changes
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@Pankraz76
Copy link
Author

Pankraz76 commented May 30, 2025 

[INFO] Quarkus - Integration Tests - Virtual Threads - gRPC SUCCESS [  3.799 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - RESTEasy Reactive SUCCESS [  1.477 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Mailer SUCCESS [  1.652 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Redis Client and Cache SUCCESS [  1.659 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - REST Client Reactive SUCCESS [  1.554 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Kafka SUCCESS [  1.667 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - AMQP 1.0 SUCCESS [  1.802 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - JMS  SUCCESS [  1.834 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Vert.x Event Bus SUCCESS [  1.387 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Scheduler SUCCESS [  2.902 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Quartz Scheduler SUCCESS [  1.490 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Disabled SUCCESS [  1.529 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Reactive Routes SUCCESS [  1.261 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Security WebAuthn SUCCESS [  1.441 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Micrometer Metrics SUCCESS [  1.623 s]
[INFO] Quarkus - Integration Tests - Mutiny native JCTools support SUCCESS [  0.669 s]
[INFO] Quarkus - Documentation ............................ SUCCESS [01:17 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  30:53 min
[INFO] Finished at: 2025-05-30T12:52:23+02:00
[INFO] ------------------------------------------------------------------------
[INFO] Njord session closed
[INFO] 12824 goals, 12824 executed
➜  quarkus git:(spotless-pr)

@Pankraz76
Copy link
Author

Pankraz76 commented May 30, 2025

see dedicated commits. config and apply.

@Pankraz76 Pankraz76 force-pushed the spotless-pr branch 3 times, most recently from f2f265f to 3369a20 Compare May 31, 2025 19:55
@Pankraz76
Copy link
Author

Pankraz76 commented May 31, 2025

ready for checkup.

@Pankraz76
Copy link
Author

Pankraz76 commented May 31, 2025 •
edited
Loading

Error: Could not find goal 'validate' in plugin com.diffplug.spotless:spotless-maven-plugin:2.44.5 among available goals apply, check -> [Help 1]

Yes fixed remaining.

This was referenced Jun 1, 2025
Closed
Closed
Closed
@Pankraz76
Copy link
Author

Pankraz76 commented Jun 2, 2025 •
edited
Loading

kindly request ci run, fixed previous issue.

Pankraz76
Pankraz76 commented Jun 2, 2025
View reviewed changes
...test/kotlin/io/quarkus/hibernate/orm/panache/kotlin/deployment/test/DuplicateIdEntityTest.kt
@RegisterExtension
@JvmField
var runner = QuarkusUnitTest()
.setExpectedException(BuildException::class.java)
Copy link
Author

@Pankraz76 Pankraz76 Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could consider migration to palantir, to promote block format having one thing only (per line).

@Pankraz76 Pankraz76 mentioned this pull request Jun 2, 2025
Closed
@Pankraz76 Pankraz76 marked this pull request as draft June 2, 2025 12:31
@Pankraz76
Copy link
Author

Pankraz76 commented Jun 2, 2025

need enabler then its good to go:

@Pankraz76
Copy link
Author

Pankraz76 commented Jun 12, 2025

#48344

@Pankraz76 Pankraz76 closed this Jun 12, 2025
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jun 12, 2025
@Pankraz76 Pankraz76 mentioned this pull request Jun 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/agroal area/amazon-lambda area/arc Issue related to ARC (dependency injection) area/context-propagation area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/fault-tolerance area/gradle Gradle area/graphql area/grpc gRPC area/health area/hibernate-orm Hibernate ORM area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/jdbc Issues related to the JDBC extensions area/kubernetes area/maven area/metrics area/mutiny area/openapi area/panache area/platform Issues related to definition and interaction with Quarkus Platform area/redis area/rest area/rest-client area/resteasy-classic area/scheduler area/security area/smallrye area/testing area/vertx triage/invalid This doesn't seem right

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pankraz76 @geoand