OIDC: reuse shared Vert.x instance in DEV and test mode whenever it is possible #45621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status for workflow
|
sberyozkin
approved these changes
Jan 16, 2025
michalvavrik
deleted the
feature/oidc-dev-test-reuse-vertx-when-possible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For OIDC extensions in DEV and test mode, this PR propposes using managed Vertx when it is possible because creating of a new Vertx is expensive and it should be preferred to reuse Vertx. Sadly I added some runtime code required in a DEV mode, but I don't think it matters as soon classes used for a DEV UI will only affect the DEV mode #45053.
context: https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/Using.20managed.20.28shared.29.20Vert.2Ex.20instance.20to.20create.20WebClient