Parser update #256
Closed
Parser update #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switching glsl version depends of --enable-gles configure flag
memleaks fixes
- HLSL: Lots of HLSLparser fixes - HLSL: Add Preprocessor macro support - HLSL: Add functions: modf, tan - HLSL: Add while loops support - Shader static code fixes - Add define DUMP_SHADERS_ON_ERROR - ShaderEngine.hpp cleanup - Restore current preset message - Remove useless messages
Minor fixes
Plugins should be unversioned shared objects
Fix build on ppc64
* added preset Aderrasi - Bow To Gravity * added presets 3dRaGoNs & Unchained - Dragon Science and Aderrasi - Visitor
* use travis to select clang/gcc, upgrade xcode * where does this go * where does this go * - libc++-dev * bleh * config * test * enable SDL for all travis builds (because -test depends on it) * libsdl2 dep * - libc++-dev dep
…onsive. fix fullscreen->windowed. add ctl-q to quit.
…ndom textures (#239) * There was a bug that existed in open GL ES 2.0 implementations where glTexImage2D could not convert GL_RGB formed textures into GL_RGBA while generating the noise textures. The GL error was GL_INVALID_OPERATION(0x502) This probably made the noise textures blank. So a new class was added that has the alpha channel for the values. * Added a fudge for render farming milkdrop where we control the time and the ticks. * User defined time: Got rid of testing code * Attempt to fix WIN32 compile - it doesnt use or need the ability to control the time * Got rid of debug - got rid of minor warning * projectM.hpp - type in ifdef projectM_SDL_main.cpp - there is code added to make the initial random number dependent on the time of day, making the sequence of visualizers more unexpected. But the posix command time does not exist in Win32 land, so we disable it.
Contributor
|
These changes fix some parsing errors with newer android NDKs. Maybe it
fixes other ARM platforms as well. These changes should have no effect on
platforms that are currently functioning well.
…On Wed, Oct 23, 2019, 6:32 AM Mischa Spiegelmock ***@***.***> wrote:
Related to #118
<#118> -
Incorporating a few changes (I assume these are fixes) to Parser.cpp from
@psperl <https://github.com/psperl>'s fork.
I don't really know if any of these are fixing anything or helping.
------------------------------
You can view, comment on, or merge this pull request online at:
#256
Commit Summary
- delete unused library references for xcode
- Some parser fixes from the mobile fork contributed by peter sperl
File Changes
- *M* src/libprojectM/MilkdropPresetFactory/Parser.cpp
<https://github.com/projectM-visualizer/projectm/pull/256/files#diff-0>
(57)
- *M* src/projectM-sdl/SDLprojectM.xcodeproj/project.pbxproj
<https://github.com/projectM-visualizer/projectm/pull/256/files#diff-1>
(6)
Patch Links:
- https://github.com/projectM-visualizer/projectm/pull/256.patch
- https://github.com/projectM-visualizer/projectm/pull/256.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#256?email_source=notifications&email_token=AB5S3ZBW6AMVIJRQRYE6WPTQQAR5TA5CNFSM4JD7JMG2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTYZC2Q>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5S3ZCZUQCM4QX57K5ZOO3QQAR5TANCNFSM4JD7JMGQ>
.
|
ghost
Member
|
From what I see, most of the issues addressed in this PR have already been merged/fixed in other changesets. The biggest part, supporting the missing functions like megabuf and loop, will be added later in the parser rewrite. The existing parser isn't up to the task as it has some limitations, e.g. it expects a variable on the left side of all equations. Internally, Milkdrop converts assignments like Closing the PR as rebasing it would probably be an impossible task due to the amount of changes accumulated since then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
29 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #118 -
Incorporating a few changes (I assume these are fixes) to Parser.cpp from @psperl's fork.
I don't really know if any of these are fixing anything or helping.