Complex presets with problems and parsing issues

[revmischa]

http://mischa.lol.s3.amazonaws.com/projectM/presets-broken-martin.zip

These Martin presets have serious problems in projectM, and supposedly push milkdrop and are cool. Maybe can help us find some issues with parsing and shaders.

psperl donated his Parser.cpp which he says adds some assertions that help track down actual parsing problems. We should merge it in as well. http://mischa.lol.s3.amazonaws.com/projectM/Parser.cpp (#256)

[mbellew]

5 of these presets use value1 and value2 (per point variables). Pull 142 may have addressed these.

#142

Well, these seem to work, don't know what they looked like before.

An AdamFX Mashup 2 martin - Geiss - Psychotic Roulette (AdamFXMashed).milk
Martin - cool morning.milk
martin - disco mix 1.milk

[mbellew]

Three of the presets are broken because they refer to a function that doesn't exist: gmegabuf()

martin - carpet weaver.milk
martin - massif central 2.milk
martin - sphery tales.milk

and since 'martin - tiling the tube.milk' seems to work, that just leaves 'martin - dark galaxy.milk' as the last mystery.

[revmischa]

From some forum post:

The way to transfer them upwards to the "per frame" section is via the 100 global "reg" variables (reg00 to reg99), or via the unlimited global array gmegabuf[].

[revmischa]

Also see #186 for more problematic presets

[korfuri]

I've found another possibly bad preset: Rovastar & Krash - Interwoven (Contra Mix).milk

I don't know if the preset itself is bad, but it's causing a whole bunch of undefined behaviors in the parser and in the execution. Here's a valgrind trace of me running that preset: https://pastebin.com/GUixatJm

I'm running a build from source on Linux at tag 3.1.1-rc3

[korfuri]

Also happening in:

• Rovastar & Krash - Interwoven (Contra Mix).milk (https://pastebin.com/GUixatJm)
• Mstress & Darius - Pursuing The Sunset.milk (https://pastebin.com/fCESn1Ab)
• Unchained - In Memory Of Peg.milk (https://pastebin.com/9wiAPc9M)
• Che - Escape.milk (https://pastebin.com/N9mxP3fk)

I'll edit this comment if I find more.