[Makefile] fixes the localnet_db_cli target#700
Merged
Conversation
dylanlott
added
bug
bryanchriswhite
added a commit
that referenced
this pull request
Apr 25, 2023
* pokt/main: [E2E] adds in-cluster config for E2E tests (#689) [Makefile] fixes the localnet_db_cli target (#700) Update devlog6.md [CLI] Remove logging for end user focused messages (#698) [Testing (DUP)] Add /internal/testutil pkg & refactor mockdns test code (#696) [Infra] Adapt pocket helm chart for DevNets (#682) Update changelog-verify.yml (#691)
Olshansk
pushed a commit
that referenced
this pull request
Apr 27, 2023
## Description #658 changed how Postgres instances are handled and assigned to Validators in the LocalNet, which broke the Make target specified for grabbing a shell to the LocalNet database. This PR fixes the command to target the Postgres instance for validator-001 by default, since validator-001 used for other tasks by default. ## Type of change Please mark the relevant option(s): - [ ] New feature, functionality or library - [x] Bug fix - [ ] Code health or cleanup - [ ] Major breaking change - [ ] Documentation - [ ] Other ## List of changes - Changes `make localnet_db_cli` to target the Postgres instance that `validator001` uses. ## Testing - [x] `make test_e2e` - [x] `make localnet_db_cli` produces a CLI shell to validator001's Postgres - [x] `make develop_test`; if any code changes were made - [ ] [Docker Compose LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md); if any major functionality was changed or introduced - [x] [k8s LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md); if any infrastructure or configuration changes were made ## Required Checklist - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added, or updated, [`godoc` format comments](https://go.dev/blog/godoc) on touched members (see: [tip.golang.org/doc/comment](https://tip.golang.org/doc/comment)) - [x] I have tested my changes using the available tooling - [x] I have updated the corresponding CHANGELOG ### If Applicable Checklist - [ ] I have updated the corresponding README(s); local and/or global - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added, or updated, [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding README(s) - [ ] I have added, or updated, documentation and [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*` if I updated `shared/*`README(s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#658 changed how Postgres instances are handled and assigned to Validators in the LocalNet, which broke the Make target specified for grabbing a shell to the LocalNet database. This PR fixes the command to target the Postgres instance for validator-001 by default, since validator-001 used for other tasks by default.
Type of change
Please mark the relevant option(s):
List of changes
make localnet_db_clito target the Postgres instance thatvalidator001uses.Testing
make develop_test; if any code changes were madeRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)