[Infra] Adapt pocket helm chart for DevNets by okdas · Pull Request #682 · pokt-network/pocket

okdas · 2023-04-14T23:28:36Z

Description

This PR introduces changes to the helm chart and go code necessary to deploy the chart on remote networks, and for the community on their hardware.

Issue

#674

Type of change

Please mark the relevant option(s):

New feature, functionality or library
Bug fix
Code health or cleanup

List of changes

Renamed pocket-validator helm chart to pocket - as we've decided to use one artifact to host all protocol actors.
Made sure the helm chart works on the remote environment
Modified DNS names in accordance with new changes/naming conventions

Testing

make develop_test; if any code changes were made
Docker Compose LocalNet; if any major functionality was changed or introduced
k8s LocalNet; if any infrastructure or configuration changes were made
Remote devnet
e2e tests via Tilt

Required Checklist

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
I have tested my changes using the available tooling
I have updated the corresponding CHANGELOG

If Applicable Checklist

I have updated the corresponding README(s); local and/or global
I have added tests that prove my fix is effective or that my feature works
I have added, or updated, mermaid.js diagrams in the corresponding README(s)
I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

github-actions

The changelog validation failed with the following output:

Missing changelog in module: build/

Changelog verification failed. See error messages for more detail.

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

github-actions

The changelog validation failed with the following output:

Missing changelog in module: build/

Latest date in charts/CHANGELOG.md is incorrect.
Latest: 2023-04-19, Current: 2023-04-18

Latest date in e2e/docs/CHANGELOG.md is incorrect.
Latest: 2023-04-14, Current: 2023-04-18

Latest date in p2p/CHANGELOG.md is incorrect.
Latest: 2023-04-17, Current: 2023-04-18

Changelog verification failed. See error messages for more detail.

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

github-actions

The changelog validation failed with the following output:

Missing changelog in module: build/

Missing changelog in module: e2e/

Latest date in p2p/CHANGELOG.md is incorrect.
Latest: 2023-04-17, Current: 2023-04-19

Changelog verification failed. See error messages for more detail.

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

github-actions

The changelog validation failed with the following output:

Missing changelog in module: build/

Missing changelog in module: e2e/

Latest date in p2p/CHANGELOG.md is incorrect.
Latest: 2023-04-17, Current: 2023-04-19

Changelog verification failed. See error messages for more detail.

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

github-actions

The changelog validation failed with the following output:

Latest date in p2p/CHANGELOG.md is incorrect.
Latest: 2023-04-17, Current: 2023-04-19

Changelog verification failed. See error messages for more detail.

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

github-actions

The changelog validation failed with the following output:

Missing changelog in module: runtime/

Latest date in p2p/CHANGELOG.md is incorrect.
Latest: 2023-04-17, Current: 2023-04-19

Changelog verification failed. See error messages for more detail.

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

github-actions

The changelog validation failed with the following output:

Latest date in p2p/CHANGELOG.md is incorrect.
Latest: 2023-04-17, Current: 2023-04-19

Changelog verification failed. See error messages for more detail.

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

okdas · 2023-04-19T23:20:25Z

Initially, I planned to also work on cluster-manager in scope of that PR because it is currently broken on DevNet (it relies on default namespace, however our DevNets are name-spaced). But we need changes in that PR merged sooner to unblock @dylanlott work.

The parent issue (#674) will cover work related to cluster-manager from the next pr.

dylanlott

This PR passed locally for me after an issue with Postgres persistent volume claims was resolved on my local. Otherwise, LGTM 👍✅

Olshansk · 2023-04-20T22:22:29Z

.github/workflows/main.yml

          labels: ${{ steps.meta.outputs.labels }}
          # NB: Uncomment below if arm64 build is needed; arm64 builds are off by default because build times are significant.
-          platforms: linux/amd64 #,linux/arm64 
+          platforms: linux/amd64 #,linux/arm64


Should we just remove arm?

Olshansk · 2023-04-20T22:31:53Z

build/localnet/cluster-manager/utils.go

-// it follows the pattern defined in the v1-validator template (/build/localnet/templates/v1-validator-template.yaml.tpl)
+// it follows the pattern defined in the pocket helm chart.
 func extractValidatorId(validatorName string) string {
 	if len(validatorName) >= 3 {


Move 3 into a constant and explain where the magic number came from.

Olshansk · 2023-04-20T22:32:00Z

build/localnet/cluster-manager/utils.go

 func extractValidatorId(validatorName string) string {
 	if len(validatorName) >= 3 {
-		return validatorName[len(validatorName)-3:]
+		re := regexp.MustCompile(`validator-(\d+)-pocket`)


Good candidate to put in an init

Olshansk · 2023-04-20T23:18:57Z

build/localnet/manifests/cli-client.yaml

      serviceAccountName: debug-client-account
      initContainers:
-        - name: wait-for-validator-001-pocket-validator
+        - name: wait-for-validator-001-pocket


I'm going to have GetSession implemented soon, which means that we're going to be able to have a "dispatch node".

Do you think this would enable us to have a dispatch node rather than using validator001 for everything?

If so, @okdas, can you create a ticket for it?

Olshansk · 2023-04-20T23:20:03Z

build/localnet/manifests/cluster-manager.yaml

          "sh",
          "-c",
-          'until wget -q -O - "http://validator-001-pocket-validator:50832/v1/health" --timeout=2 --tries=2 --spider >/dev/null 2>&1; do echo waiting for validator-001-pocket-validator to be online and healthy...; sleep 2; done;',
+          'until wget -q -O - "http://validator-001-pocket:50832/v1/health" --timeout=2 --tries=2 --spider >/dev/null 2>&1; do echo waiting for validator-001-pocket to be online and healthy...; sleep 2; done;',


Ditto, I think a ticket for s/validator-001/disaptch-node for everything in the infra would be appropriate. Thouhgts?

@Olshansk would dispatch node be just another validator in that case? Just a node that is not staked as validator?

It'd be a full node, not necessarily a validator.

* pokt/main: Update devlog6.md [CLI] Remove logging for end user focused messages (#698) [Testing (DUP)] Add /internal/testutil pkg & refactor mockdns test code (#696) [Infra] Adapt pocket helm chart for DevNets (#682) Update changelog-verify.yml (#691)

* pokt/main: [E2E] adds in-cluster config for E2E tests (#689) [Makefile] fixes the localnet_db_cli target (#700) Update devlog6.md [CLI] Remove logging for end user focused messages (#698) [Testing (DUP)] Add /internal/testutil pkg & refactor mockdns test code (#696) [Infra] Adapt pocket helm chart for DevNets (#682) Update changelog-verify.yml (#691)

rename pocket-validator chart to just pocket

544937e

okdas added infra Core infrastructure - not protocol related e2e-devnet-test Runs E2E tests on devnet labels Apr 14, 2023

okdas added this to the M2: Pocket DoS (Devnet of Servicers) milestone Apr 14, 2023

okdas self-assigned this Apr 14, 2023

reviewpad bot added the medium label Apr 14, 2023

github-actions bot requested changes Apr 14, 2023

View reviewed changes

okdas added 4 commits April 17, 2023 10:08

--wip-- [skip ci]

6301c57

--wip-- [skip ci]

3593656

add ci stuff

084f63f

Merge branch 'main' into issue/674-helm-chart-devnet

dd37f8a

github-actions bot requested changes Apr 19, 2023

View reviewed changes

revert unneded renames

f083e2f

github-actions bot requested changes Apr 19, 2023

View reviewed changes

okdas and others added 3 commits April 19, 2023 11:04

--wip-- [skip ci]

93faa62

ability to change svc name

f28296b

add generated helm docs

f59062e

github-actions bot requested changes Apr 19, 2023

View reviewed changes

add changelogs

e5dc25f

github-actions bot requested changes Apr 19, 2023

View reviewed changes

ensure cluster manager works with new helm names on localnet

17e46c0

github-actions bot requested changes Apr 19, 2023

View reviewed changes

final tests

87e27a6

github-actions bot requested changes Apr 19, 2023

View reviewed changes

okdas requested review from Olshansk and dylanlott April 19, 2023 23:17

okdas marked this pull request as ready for review April 19, 2023 23:17

reviewpad bot added the waiting-for-review label Apr 19, 2023

dylanlott approved these changes Apr 20, 2023

View reviewed changes

okdas merged commit 67cc9cb into main Apr 20, 2023

okdas deleted the issue/674-helm-chart-devnet branch April 20, 2023 21:12

Olshansk reviewed Apr 20, 2023

View reviewed changes

Conversation

okdas commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue

Type of change

List of changes

Testing

Required Checklist

If Applicable Checklist

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

okdas commented Apr 19, 2023

Uh oh!

dylanlott left a comment

Choose a reason for hiding this comment

Uh oh!

Olshansk Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

Olshansk Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

Olshansk Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

Olshansk Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

Olshansk Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

okdas Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Olshansk Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

okdas commented Apr 14, 2023 •

edited

Loading

okdas Apr 20, 2023 •

edited

Loading