[CLI] Remove logging for end user focused messages#698
Merged
Conversation
added 2 commits
April 21, 2023 23:42
…and add verbose flag to hide config messages
Olshansk
approved these changes
Apr 21, 2023
Collaborator
Olshansk
left a comment
There was a problem hiding this comment.
Impressive use of emojis 🌟
This is a piece of 🎨
bryanchriswhite
added a commit
that referenced
this pull request
Apr 25, 2023
* pokt/main: [E2E] adds in-cluster config for E2E tests (#689) [Makefile] fixes the localnet_db_cli target (#700) Update devlog6.md [CLI] Remove logging for end user focused messages (#698) [Testing (DUP)] Add /internal/testutil pkg & refactor mockdns test code (#696) [Infra] Adapt pocket helm chart for DevNets (#682) Update changelog-verify.yml (#691)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces all
loggerinstances withfmt.Printstatements when dealing with information that is intended to be read by the user.It also adds the
verboseflag to hide config file messages when the user runs a CLI command without it present. And fixes some comment formatting and keybase initialisation for the debug environment.Issue
Fixes #200
Type of change
Please mark the relevant option(s):
List of changes
loggercalls withfmt.Printstatements throughout the CLITesting
make develop_test; if any code changes were madeRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)