Skip to content

[CLI] Remove logging for end user focused messages#698

Merged
h5law merged 3 commits intomainfrom
cli-logging
Apr 22, 2023
Merged

[CLI] Remove logging for end user focused messages#698
h5law merged 3 commits intomainfrom
cli-logging

Conversation

@h5law
Copy link
Contributor

@h5law h5law commented Apr 21, 2023

Description

This PR replaces all logger instances with fmt.Print statements when dealing with information that is intended to be read by the user.

It also adds the verbose flag to hide config file messages when the user runs a CLI command without it present. And fixes some comment formatting and keybase initialisation for the debug environment.

Issue

Fixes #200

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Replace logger calls with fmt.Print statements throughout the CLI
  • Reformat some print statements to have spaces after emojis
  • Add verbose flag to hide config file messages
  • Fix keybase initialisation in debug environment

Testing

  • make develop_test; if any code changes were made
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@h5law h5law requested a review from Olshansk April 21, 2023 23:08
@h5law h5law self-assigned this Apr 21, 2023
@h5law h5law added client work needed to interface with the node (rpc, cli, etc..) and removed small waiting-for-review labels Apr 21, 2023
Copy link
Collaborator

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive use of emojis 🌟

This is a piece of 🎨

@h5law h5law merged commit d109e9d into main Apr 22, 2023
@h5law h5law deleted the cli-logging branch April 22, 2023 00:36
bryanchriswhite added a commit that referenced this pull request Apr 24, 2023
* pokt/main:
  Update devlog6.md
  [CLI] Remove logging for end user focused messages (#698)
  [Testing (DUP)] Add /internal/testutil pkg & refactor mockdns test code (#696)
  [Infra] Adapt pocket helm chart for DevNets (#682)
  Update changelog-verify.yml (#691)
bryanchriswhite added a commit that referenced this pull request Apr 25, 2023
* pokt/main:
  [E2E] adds in-cluster config for E2E tests (#689)
  [Makefile] fixes the localnet_db_cli target (#700)
  Update devlog6.md
  [CLI] Remove logging for end user focused messages (#698)
  [Testing (DUP)] Add /internal/testutil pkg & refactor mockdns test code (#696)
  [Infra] Adapt pocket helm chart for DevNets (#682)
  Update changelog-verify.yml (#691)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client work needed to interface with the node (rpc, cli, etc..) waiting-for-review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Tooling] CLI: make sure outputs to the user are not log package calls

2 participants