onion integration

[ricott1]

I extended the module to encode and decode .onion (tor) addresses. I'm planning to use this to extend the ens-app repo.

[ricott1]

This pull depends on another pull request for js-multiaddr. [edit] That pull has been merged

[ricott1]

Can I get some feedback on this?

[Arachnid]

@pldespaigne Can you please take a look at this? We'd like to add support to the ENS manager, but we can't until this is merged.

[pldespaigne]

I will look at it ! @ricott1 no offense, but this PR doesn't look clean, do you think a general encoding function will do the job (see #17 ) ?

[ricott1]

Absolutely, I'm by no mean an expert developer, I just needed a way to encode onion addresses for the ens-app, but a general encoding would definitely be the way to go.

[ricott1]

Hi @pldespaigne , are you working on the general encoding by any chance?

[pldespaigne]

Hi, I don't have so much time currently, but it will be done before Sunday evening !

[pldespaigne]

Hi @ricott1 just merge #28 and publish it to npm as v2.4.1, you should now be able to do contentHash.encode('onion', onionAddress); (onion3 is also supported), I will update the readme later today. Please tell me if it is ok for you so I can close this PR

[ricott1]

Thanks!