added onion protocol #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@ricott1 Thanks for this - please ping me when that pull request has gone through |
Member
|
@ricott1 Also can you please add a test for the new protocol |
Contributor
pldespaigne
reviewed
Jul 16, 2019
src/utils/contents.js
Outdated
| } else if (contentType === 'bzz') { | ||
| encoded = '0x' + contentHash.fromSwarm(content) | ||
| } else if (contentType === 'onion') {//In the future insert here general encoding given by contentHash library | ||
| encoded = '0x' + contentHash.fromOnion(content) |
Contributor
There was a problem hiding this comment.
this should be contentHash.encode('onion', content);
Contributor
Author
|
Tests added |
9 tasks
jefflau
reviewed
Jul 23, 2019
| "ethers": "^4.0.30", | ||
| "js-sha3": "^0.8.0", | ||
| "lodash": "^4.17.11", | ||
| "node-gyp": "^5.0.2", |
Member
There was a problem hiding this comment.
what are we using node-gyp and rebuild for?
| "ethers": "^4.0.30", | ||
| "js-sha3": "^0.8.0", | ||
| "lodash": "^4.17.11", | ||
| "node-gyp": "^5.0.2", |
Member
There was a problem hiding this comment.
What are we using node-gyp and rebuild for
Contributor
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated pull from ensdomains/ens-app#355
I added the option to register an onion address, encoded as a multiaddress, in the
contenthashentry.This pull will work in tandem with a metamask pull.
It depends on another pull made on the content-hash dependency, which we should wait for.