Add option to register onion address#355
Closed
ricott1 wants to merge 31 commits intoensdomains:devfrom
ricott1:onionSupport
Closed
Add option to register onion address#355ricott1 wants to merge 31 commits intoensdomains:devfrom ricott1:onionSupport
ricott1 wants to merge 31 commits intoensdomains:devfrom
ricott1:onionSupport
Conversation
Fix expiration date bug (#249)
Deploy to production
Deploy to production - Fix transfer registrant
Deploy to production - Fix 0x00000
Fix legacy auction entry for 0x00000
Deploy to production - fix error
Deploy to production
Deploy to production - Fix safari notifications
Deploy to production - Infura new URL
Fix transfer
Deploy to production
Deploy to production
Show parsed search result (#324)
Member
|
@jefflau PTAL |
Member
|
Hi @ricott1, Sorry for the delay at looking at this. We've moved this functionality in the most recent refactor to https://github.com/ensdomains/ui Is it possible you could make this pull request on that repo? |
Author
|
Hi @jefflau , |
Author
|
Closing, PR now at ensdomains/ui#13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull is similar to #328 . I don't know how to update a pull from someone else, so I created a new one.
I added the option to register an onion address, encoded as a multiaddress, in the
contenthashentry.This pull will work in tandem with a metamask pull.
It depends on another pull made on the content-hash dependency.