Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

bump transaction_version#5319

Closed
coderobe wants to merge 4 commits intorelease-v0.9.19from
coderobe/txver-19
Closed

bump transaction_version#5319
coderobe wants to merge 4 commits intorelease-v0.9.19from
coderobe/txver-19

Conversation

@coderobe
Copy link
Copy Markdown
Contributor

No description provided.

@coderobe coderobe added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Apr 13, 2022
@coderobe
Copy link
Copy Markdown
Contributor Author

releng is unsure whether or not the PolkadotPrimitivesV1... -> PolkadotPrimitivesV2... changes require a transaction_version bump

@coderobe coderobe mentioned this pull request Apr 13, 2022
16 tasks
@coderobe

This comment was marked as outdated.

@command-bot

This comment was marked as outdated.

@command-bot

This comment was marked as outdated.

@bkchr
Copy link
Copy Markdown
Member

bkchr commented Apr 13, 2022

releng is unsure whether or not the PolkadotPrimitivesV1... -> PolkadotPrimitivesV2... changes require a transaction_version bump

@drahnr @eskimor @rphmeier did any of the types structure changes? If not we don't need to bump the transaction_version.

@ordian
Copy link
Copy Markdown

ordian commented Apr 13, 2022

I believe it was only a rename introduced in #5037.

@coderobe coderobe closed this Apr 13, 2022
@bkchr bkchr deleted the coderobe/txver-19 branch April 14, 2022 08:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants