Add extra information to the harmless error logs during validate_transaction#9047
Merged
AndreiEres merged 5 commits intomasterfrom Jul 3, 2025
Merged
Add extra information to the harmless error logs during validate_transaction#9047AndreiEres merged 5 commits intomasterfrom
AndreiEres merged 5 commits intomasterfrom
Conversation
AndreiEres
added
the
R0-no-crate-publish-required
Contributor
Author
|
/cmd prdoc --audience node_dev --bump none |
ggwpez
reviewed
Jul 1, 2025
ggwpez
approved these changes
Jul 1, 2025
ggwpez
added
A4-backport-stable2506
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
alexggh
approved these changes
Jul 3, 2025
Sajjon
reviewed
Jul 3, 2025
| if !#input.is_empty() { | ||
| panic!( | ||
| "Bad input data provided to {}: expected no parameters, but input buffer is not empty.", | ||
| "Bad input data provided to {}: expected no parameters, but input buffer is not empty. Nothing bad happened: someone sent an invalid transaction to the node.", |
Contributor
There was a problem hiding this comment.
is it not weird to panic, and say "nothing bad happened"?
sandreim
approved these changes
Jul 3, 2025
paritytech-release-backport-bot bot
pushed a commit
that referenced
this pull request
Jul 3, 2025
…saction (#9047) # Description Fixes #5936 Since we are still receiving reports about this error, I suggest adding an extra line to prevent further questions. --------- Co-authored-by: Alexander Samusev <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Oliver Tale-Yazdi <[email protected]> (cherry picked from commit 180fcce)
|
Successfully created backport PR for |
EgorPopelyaev
pushed a commit
that referenced
this pull request
Jul 3, 2025
Backport #9047 into `stable2506` from AndreiEres. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Andrei Eres <[email protected]> Co-authored-by: Alexander Samusev <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
ordian
added a commit
that referenced
this pull request
Jul 24, 2025
* master: (91 commits) Add extra information to the harmless error logs during validate_transaction (#9047) `sp-tracing`: Remove `test-utils` feature (#9063) add try-state check for staking roles -- staker cannot be nominator a… (#9034) net/discovery: File persistence for `AddrCache` (#8839) dispute-coordinator: handle race with offchain disabling (#9050) Align parameters for `EventEmitter::emit_sent_event` (#9057) Fetch parent block `api_version` (#9059) [XCM Precompile] Rename functions and improve docs in the Solidity interface (#9023) Cleanup and improvements for `ControlledValidatorIndices` (#8896) reenable 0001-parachains-pvf (#9046) Add optional auto-rebag within on-idle (#8684) Fix flaxy 0003-block-building-warp-sync test - one more approach (#8974) [Staking] [AHM] Fixes insufficient slashing of nominators (and some other small issues). (#8937) chore: Bump bounded-collections dep (#9004) XCMP and DMP improvements (#8860) EPMB/unsigned: fixed multi-page winner computation (#8987) Always send full parent header, not only hash, part of collation response (#8939) revive: Precompiles should return dummy code when queried (#9001) Fix confusing log messages in network protocol behaviour (#8819) Fix pallet_migrations benchmark when FailedMigrationHandler emits events (#8694) ...
alvicsam
added a commit
that referenced
this pull request
Oct 17, 2025
…saction (#9047) # Description Fixes #5936 Since we are still receiving reports about this error, I suggest adding an extra line to prevent further questions. --------- Co-authored-by: Alexander Samusev <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5936
Since we are still receiving reports about this error, I suggest adding an extra line to prevent further questions.