Add extra information to the harmless error logs during validate_transaction

prdoc/pr_9047.prdoc

@@ -0,0 +1,9 @@
+title: Add extra information to the harmless error logs during validate_transaction
+doc:
+- audience: Node Operator
+  description: |-
+    Adds additional information to the harmless error logs "Bad input data provided" during `validate_transaction`.
+
+crates:
+- name: sp-api-proc-macro
+  bump: patch

substrate/primitives/api/proc-macro/src/impl_runtime_apis.rs

@@ -82,7 +82,7 @@ fn generate_impl_call(
 		quote!(
 			if !#input.is_empty() {
 				panic!(
-					"Bad input data provided to {}: expected no parameters, but input buffer is not empty.",
+					"Bad input data provided to {}: expected no parameters, but input buffer is not empty. Nothing bad happened: someone sent an invalid transaction to the node.",
 					#fn_name_str
 				);
 			}
@@ -104,7 +104,7 @@ fn generate_impl_call(
 					&mut #input,
 				) {
 					Ok(res) => res,
-					Err(e) => panic!("Bad input data provided to {}: {}", #fn_name_str, e),
+					Err(e) => panic!("Bad input data provided to {}: {}. Nothing bad happened: someone sent an invalid transaction to the node.", #fn_name_str, e),
 				};
 		)
 	};