Conversation
be a bit more lenient with allowed pvf execution range. Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
alexggh
added
the
R0-no-crate-publish-required
lrubasze
approved these changes
Jun 30, 2025
Contributor
lrubasze
left a comment
lrubasze
left a comment
There was a problem hiding this comment.
LGTM! Yet another tests unflaked!
| @@ -74,11 +74,11 @@ one: reports histogram polkadot_pvf_execution_time has at least 1 samples in buc | |||
| two: reports histogram polkadot_pvf_execution_time has at least 1 samples in buckets ["0.1", "0.5", "1", "2"] within 10 seconds | |||
|
|
|||
| # Check if we have no samples > 2s. | |||
Contributor
There was a problem hiding this comment.
Not sure, but maybe it would make sense to add more detailed description, where are these numbers are taken from.
## The issue In `FullSupportsOfMiner`, we initially considered `MaxWinnersPerPage` as the overall maximum number of winners across pages. However, it should be calculated as `Pages * MaxWinnersPerPage` to prevent the computed solution from having a low overall total of winners, which could result in a `WrongWinnerCount` error. This bug was identified in [#staking-miner-1074](paritytech/polkadot-staking-miner#1074) while testing the staking miner in a setup with aggressive trimming to evaluate backer bounding. ## How to test A test has been added to replicate this scenario: Test configuration: - `Pages=2` - `MaxWinnersPerPage=2` - `desired_targets=3` (3 or 4 doesn't matter here, the key point is that is strictly > `MaxWinnersPerPage`) - `MaxBackersPerWinner=1` Before the fix in this PR: - `FullSupportsOfMiner` could only hold 2 winners in total (bounded by `MaxWinnersPerPage`) - But the mining algorithm needed to hold 3 winners across multiple pages - This would cause a `WrongWinnerCount` error during verification With the fix: - `FullSupportsOfMiner` can now hold `Pages * MaxWinnersPerPage = 2 * 2 = 4` winners - The test passes with 3 winners across 2 pages (proving it can hold more than `MaxWinnersPerPage=2`) - No `WrongWinnerCount` errors occur --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Contributor
Author
|
Ran the job around ~15 times in CI all passed, merging now. |
alvicsam
approved these changes
Jul 2, 2025
ordian
added a commit
that referenced
this pull request
Jul 24, 2025
* master: (91 commits) Add extra information to the harmless error logs during validate_transaction (#9047) `sp-tracing`: Remove `test-utils` feature (#9063) add try-state check for staking roles -- staker cannot be nominator a… (#9034) net/discovery: File persistence for `AddrCache` (#8839) dispute-coordinator: handle race with offchain disabling (#9050) Align parameters for `EventEmitter::emit_sent_event` (#9057) Fetch parent block `api_version` (#9059) [XCM Precompile] Rename functions and improve docs in the Solidity interface (#9023) Cleanup and improvements for `ControlledValidatorIndices` (#8896) reenable 0001-parachains-pvf (#9046) Add optional auto-rebag within on-idle (#8684) Fix flaxy 0003-block-building-warp-sync test - one more approach (#8974) [Staking] [AHM] Fixes insufficient slashing of nominators (and some other small issues). (#8937) chore: Bump bounded-collections dep (#9004) XCMP and DMP improvements (#8860) EPMB/unsigned: fixed multi-page winner computation (#8987) Always send full parent header, not only hash, part of collation response (#8939) revive: Precompiles should return dummy code when queried (#9001) Fix confusing log messages in network protocol behaviour (#8819) Fix pallet_migrations benchmark when FailedMigrationHandler emits events (#8694) ...
alvicsam
added a commit
that referenced
this pull request
Oct 17, 2025
Fixes: #8940. All failure seems to be because occasionally we have 1 occurence in the 3 bucket, since the default backing timeout on polkadot is 2.5 it does makes sense to allow items in the 3 bucket as well. --------- Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io> Co-authored-by: Paolo La Camera <paolo@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: alvicsam <alvicsam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8940.
All failure seems to be because occasionally we have 1 occurence in the 3 bucket, since the default backing timeout on polkadot is 2.5 it does makes sense to allow items in the 3 bucket as well.