[pallet-revive] Fix pallet-revive-fixtures build.rs#7928
Merged
Conversation
Fix pallet-revive-uapi resolution when building pallet-revive-fixtures contracts
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
pgherveou
added
T7-smart_contracts
…time_dev --bump patch'
athei
reviewed
Mar 14, 2025
| .iter() | ||
| .filter(|pkg| pkg.name == "pallet-revive-uapi") | ||
| .collect(); | ||
| .find(|pkg| pkg.manifest_path.as_std_path() == manifest_path) |
Member
There was a problem hiding this comment.
We are still just picking the first package we find here. Why is the manifest path unique but the name is not?
Contributor
Author
There was a problem hiding this comment.
They look like that
"manifest_path": "/home/pg/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/pallet-contracts-uapi-12.0.0/Cargo.toml",
"manifest_path": "/home/pg/github/polkadot-sdk/substrate/frame/contracts/uapi/Cargo.toml",
"manifest_path": "/home/pg/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/pallet-revive-uapi-0.1.1/Cargo.toml",
so we can pick the right one knowing the path to the manifest
Contributor
Author
There was a problem hiding this comment.
there might be a better approach but that seem to work ...
athei
approved these changes
Mar 14, 2025
pgherveou
changed the title
xermicus
approved these changes
Mar 14, 2025
EgorPopelyaev
pushed a commit
that referenced
this pull request
Mar 17, 2025
backport revive PRs: - #7928 [pallet-revive] Fix pallet-revive-fixtures build.rs - #7879 [pallet-revive] Support blocktag in eth_getLogs RPC - #7848 [pallet-revive] Add support for eip1898 block notation - #7844 [pallet-revive] fixture as dev dep - #7827 [revive-rpc] allow using legacy data field - #7810 [pallet-revive] precompiles 2->9 - **bump asset-hub-westend spec version** --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ordian
added a commit
that referenced
this pull request
Mar 17, 2025
* origin: (325 commits) Add an extra_constant to pallet-treasury (#7918) Bump the ci_dependencies group across 1 directory with 4 updates (#7855) remove compromised action (#7934) Fixing token-economics dead link (#5302) [pallet-revive] Fix pallet-revive-fixtures build.rs (#7928) cumulus: fix pov exporter format (#7923) sp-api: Support `mut` in `impl_runtime_apis!` (#7924) Remove clones from block seal function (#7917) [pallet-revive] precompiles 2->9 (#7810) Use non-native token to benchmark xcm on asset hub (#7893) [CI] bump timeout wait for build in zombienet workflows. (#7871) taplo: split long array line to multiline array (#7905) [pallet-revive] fixture as dev dep (#7844) notifications/libp2p: Punish notification protocol misbehavior on outbound substreams (#7781) [Release|CI/CD] Update version of the cache action in the Publish docker ci (#7892) Remove `pallet::getter` usage from bridges/modules (#7120) [pallet-revive] Support blocktag in eth_getLogs RPC (#7879) Improve error message in benchmark macro (#7873) staking: add `manual_slash` extrinsic (#7805) Remove execute_with_origin implementation in the XCM executor (#7889) ...
ordian
added a commit
that referenced
this pull request
Mar 19, 2025
* master: (58 commits) Upgrade link-checker cache to v4 (#7874) Updating readmes (#7950) Cumulus: Remove some old scripts (#7946) pallet-bounties: allow bounties to never expire (#7723) run frame-omni-bencher overhead command in CI for all runtimes in the runtime matrix (#7459) Update README.md for Cumulus (#7930) FRAME: Meta Transaction (#6428) Follow up for: Use the umbrella crate for the parachain template #5993 (#7464) Add an extra_constant to pallet-treasury (#7918) Bump the ci_dependencies group across 1 directory with 4 updates (#7855) remove compromised action (#7934) Fixing token-economics dead link (#5302) [pallet-revive] Fix pallet-revive-fixtures build.rs (#7928) cumulus: fix pov exporter format (#7923) sp-api: Support `mut` in `impl_runtime_apis!` (#7924) Remove clones from block seal function (#7917) [pallet-revive] precompiles 2->9 (#7810) Use non-native token to benchmark xcm on asset hub (#7893) [CI] bump timeout wait for build in zombienet workflows. (#7871) taplo: split long array line to multiline array (#7905) ...
alindima
pushed a commit
that referenced
this pull request
Apr 8, 2025
Fix pallet-revive-uapi resolution when building pallet-revive-fixtures contracts follow up from #7844 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: xermicus <cyrill@parity.io>
7 tasks
This was referenced Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix pallet-revive-uapi resolution when building pallet-revive-fixtures contracts
follow up from #7844