Skip to content

taplo: split long array line to multiline array#7905

Merged
iulianbarbu merged 3 commits intoparitytech:masterfrom
iulianbarbu:ib-taplo-multiline-arrays
Mar 13, 2025
Merged

taplo: split long array line to multiline array#7905
iulianbarbu merged 3 commits intoparitytech:masterfrom
iulianbarbu:ib-taplo-multiline-arrays

Conversation

@iulianbarbu
Copy link
Copy Markdown
Contributor

@iulianbarbu iulianbarbu commented Mar 13, 2025

Description

It is difficult to spot changes to umbrella features when reviewing, when defined on a long line, so made sure tomls formatting will be applied to long array lines by splitting them on multiple lines. This will be applied to any tomls in the monorepo that is not excluded from taplo.

Integration

N/A

Review Notes

Set global taplo config array_auto_expand to true.

@iulianbarbu iulianbarbu self-assigned this Mar 13, 2025
@iulianbarbu iulianbarbu marked this pull request as ready for review March 13, 2025 10:55
@iulianbarbu iulianbarbu requested a review from a team March 13, 2025 10:56
@iulianbarbu iulianbarbu added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Mar 13, 2025
@iulianbarbu iulianbarbu changed the title taplo: format long lines to multiline arrays taplo: split long array line to multiline arrays Mar 13, 2025
@iulianbarbu iulianbarbu changed the title taplo: split long array line to multiline arrays taplo: split long array line to multiline array Mar 13, 2025
@michalkucharczyk michalkucharczyk requested a review from a team March 13, 2025 11:13
@iulianbarbu iulianbarbu enabled auto-merge March 13, 2025 11:21
@michalkucharczyk
Copy link
Copy Markdown
Contributor

check-toml-format is failing, I guess you need to re-format more tomls.

@iulianbarbu iulianbarbu disabled auto-merge March 13, 2025 11:30
Signed-off-by: Iulian Barbu <[email protected]>
@iulianbarbu iulianbarbu requested a review from a team as a code owner March 13, 2025 11:38
@iulianbarbu iulianbarbu enabled auto-merge March 13, 2025 13:46
@iulianbarbu iulianbarbu added this pull request to the merge queue Mar 13, 2025
Merged via the queue into paritytech:master with commit d4155b6 Mar 13, 2025
236 of 244 checks passed
@iulianbarbu iulianbarbu deleted the ib-taplo-multiline-arrays branch March 13, 2025 14:55
ordian added a commit that referenced this pull request Mar 17, 2025
* origin: (325 commits)
  Add an extra_constant to pallet-treasury (#7918)
  Bump the ci_dependencies group across 1 directory with 4 updates (#7855)
  remove compromised action (#7934)
  Fixing token-economics dead link (#5302)
  [pallet-revive] Fix pallet-revive-fixtures build.rs (#7928)
  cumulus: fix pov exporter format (#7923)
  sp-api: Support `mut` in `impl_runtime_apis!` (#7924)
  Remove clones from block seal function (#7917)
  [pallet-revive] precompiles 2->9 (#7810)
  Use non-native token to benchmark xcm on asset hub (#7893)
  [CI] bump timeout wait for build in zombienet workflows. (#7871)
  taplo: split long array line to multiline array (#7905)
  [pallet-revive] fixture as dev dep (#7844)
  notifications/libp2p: Punish notification protocol misbehavior on outbound substreams (#7781)
  [Release|CI/CD] Update version of the cache action in the Publish docker ci (#7892)
  Remove `pallet::getter` usage from bridges/modules (#7120)
  [pallet-revive] Support blocktag in eth_getLogs RPC (#7879)
  Improve error message in benchmark macro (#7873)
  staking: add `manual_slash` extrinsic (#7805)
  Remove execute_with_origin implementation in the XCM executor (#7889)
  ...
ordian added a commit that referenced this pull request Mar 19, 2025
* master: (58 commits)
  Upgrade link-checker cache to v4 (#7874)
  Updating readmes (#7950)
  Cumulus: Remove some old scripts (#7946)
  pallet-bounties: allow bounties to never expire (#7723)
  run frame-omni-bencher overhead command in CI for all runtimes in the runtime matrix (#7459)
  Update README.md for Cumulus (#7930)
  FRAME: Meta Transaction (#6428)
  Follow up for: Use the umbrella crate for the parachain template #5993 (#7464)
  Add an extra_constant to pallet-treasury (#7918)
  Bump the ci_dependencies group across 1 directory with 4 updates (#7855)
  remove compromised action (#7934)
  Fixing token-economics dead link (#5302)
  [pallet-revive] Fix pallet-revive-fixtures build.rs (#7928)
  cumulus: fix pov exporter format (#7923)
  sp-api: Support `mut` in `impl_runtime_apis!` (#7924)
  Remove clones from block seal function (#7917)
  [pallet-revive] precompiles 2->9 (#7810)
  Use non-native token to benchmark xcm on asset hub (#7893)
  [CI] bump timeout wait for build in zombienet workflows. (#7871)
  taplo: split long array line to multiline array (#7905)
  ...
alindima pushed a commit that referenced this pull request Apr 8, 2025
# Description

It is difficult to spot changes to umbrella features when reviewing,
when defined on a long line, so made sure tomls formatting will be
applied to long array lines by splitting them on multiple lines. This
will be applied to any tomls in the monorepo that is not excluded from
taplo.

## Integration

N/A

## Review Notes

Set global taplo config `array_auto_expand` to true.

---------

Signed-off-by: Iulian Barbu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants