[pallet-revive] fixture as dev dep by pgherveou · Pull Request #7844 · paritytech/polkadot-sdk

pgherveou · 2025-03-07T13:07:19Z

Update pallet-revive-fixtures so that it can build without looking up dependencies from the workspace

pgherveou · 2025-03-07T13:08:34Z

/cmd prdoc --audience runtime_dev --bump patch

…time_dev --bump patch'

ggwpez

I see it twice in pallet-revive; once in normal and once in dev-dependencies.
Can it maybe also just be dev in that case?

pgherveou · 2025-03-07T13:28:29Z

I see it twice in pallet-revive; once in normal and once in dev-dependencies. Can it maybe also just be dev in that case?

👀

pgherveou · 2025-03-07T13:32:14Z

I see it twice in pallet-revive; once in normal and once in dev-dependencies. Can it maybe also just be dev in that case?

@athei we need it as a dep in pallet-revive? Is that for benchmark?

athei · 2025-03-10T08:17:57Z

I see it twice in pallet-revive; once in normal and once in dev-dependencies. Can it maybe also just be dev in that case?

@athei we need it as a dep in pallet-revive? Is that for benchmark?

Yeah the dummy and noop benchmark fixtures are being used in benchmarks. If you want to get rid of them you could re-write them in assembly. However, the assembler doesn't support import tables. But you could use a hardcoded syscall number as I did for the code size benchmark.

pgherveou · 2025-03-10T11:39:45Z

/cmd prdoc --audience runtime_dev --bump patch

pgherveou · 2025-03-10T11:56:19Z

/cmd prdoc --audience runtime_dev --bump patch

github-actions · 2025-03-10T11:59:43Z

Command "prdoc --audience runtime_dev --bump patch" has failed ❌! See logs here

athei · 2025-03-10T12:12:22Z

substrate/frame/revive/fixtures/build.rs

+	if uapi_pkg.source.is_none() {
+		uapi_dep.insert(
+			"path".to_string(),
+			toml::Value::String(
+				fixtures_dir.join("../uapi").canonicalize()?.to_str().unwrap().to_string(),
+			),


How is this supposed to work? Is it set depending on whether we are in a workspace or not?

yeah, would need to test it out, to make sure it works with the release deployment pipeline

Aye if this works as expected its a good solution.

substrate/frame/revive/uapi/src/lib.rs

paritytech-workflow-stopper · 2025-03-13T12:56:58Z

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/13834260283
Failed job name: check-try-runtime

Fix pallet-revive-uapi resolution when building pallet-revive-fixtures contracts follow up from #7844 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: xermicus <[email protected]>

backport revive PRs: - #7928 [pallet-revive] Fix pallet-revive-fixtures build.rs - #7879 [pallet-revive] Support blocktag in eth_getLogs RPC - #7848 [pallet-revive] Add support for eip1898 block notation - #7844 [pallet-revive] fixture as dev dep - #7827 [revive-rpc] allow using legacy data field - #7810 [pallet-revive] precompiles 2->9 - **bump asset-hub-westend spec version** --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* origin: (325 commits) Add an extra_constant to pallet-treasury (#7918) Bump the ci_dependencies group across 1 directory with 4 updates (#7855) remove compromised action (#7934) Fixing token-economics dead link (#5302) [pallet-revive] Fix pallet-revive-fixtures build.rs (#7928) cumulus: fix pov exporter format (#7923) sp-api: Support `mut` in `impl_runtime_apis!` (#7924) Remove clones from block seal function (#7917) [pallet-revive] precompiles 2->9 (#7810) Use non-native token to benchmark xcm on asset hub (#7893) [CI] bump timeout wait for build in zombienet workflows. (#7871) taplo: split long array line to multiline array (#7905) [pallet-revive] fixture as dev dep (#7844) notifications/libp2p: Punish notification protocol misbehavior on outbound substreams (#7781) [Release|CI/CD] Update version of the cache action in the Publish docker ci (#7892) Remove `pallet::getter` usage from bridges/modules (#7120) [pallet-revive] Support blocktag in eth_getLogs RPC (#7879) Improve error message in benchmark macro (#7873) staking: add `manual_slash` extrinsic (#7805) Remove execute_with_origin implementation in the XCM executor (#7889) ...

# Description When building `polkadot-sdk-parachain-template` workspace (`cargo build --workspace --all-features`), based on `stable2412` dependencies (paritytech/polkadot-sdk-parachain-template#26), it fails with an error like below. <details> <summary><b>error message</b></summary> error[E0080]: evaluation of constant value failed --> /home/ubuntu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sc-network-0.47.0/src/protocol/message.rs:79:40 | 79 | #[derive(Debug, PartialEq, Eq, Clone, Encode, Decode)] | ^^^^^^ the evaluated program panicked at 'Found variants that have duplicate indexes. Both `Consensus` and `RemoteCallResponse` have the index `6`. Use different indexes for each variant.', /home/ubuntu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sc-network-0.47.0/src/protocol/message.rs:79:43 | = note: this error originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `::core::panic` (in Nightly builds, run with -Z macro-backtrace for more info) error[E0080]: evaluation of constant value failed --> /home/ubuntu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sc-network-0.47.0/src/protocol/message.rs:79:48 | 79 | #[derive(Debug, PartialEq, Eq, Clone, Encode, Decode)] | ^^^^^^ the evaluated program panicked at 'Found variants that have duplicate indexes. Both `Consensus` and `RemoteCallResponse` have the index `6`. Use different indexes for each variant.', /home/ubuntu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sc-network-0.47.0/src/protocol/message.rs:79:51 | = note: this error originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `::core::panic` (in Nightly builds, run with -Z macro-backtrace for more info) For more information about this error, try `rustc --explain E0080`. error: could not compile `sc-network` (lib) due to 2 previous errors </details> The root cause is `sc-network 0.47.0` (which builds fine when >=0.48.0), a dependency of `pallet-revive-eth-rpc 0.2.0`, which is a dependency of `polkadot-sdk 0.12.1`, used for various things in `polkadot-sdk-parachain-template` repo. While investigating how to fix the issue on `stable2412`, I discovered a few things: 1. `pallet-revive 0.3.1` can not build with `runtime-benchmarks` based on latest `stable2412`, and it is also a dependency of `pallet-revive-eth-rpc 0.2.0`, and pulled by `polkadot-sdk 0.12.1` for its `runtime-benchmarks` feature. 2. Based on some chats started here: #7844 (comment), we identified that `pallet-revive/pallet-revive-eth-rpc` were set with `publish = false` for a good reason and it shouldn't have changed here: 31b5923. We also identified as a potential fix what this PR does, meaning removing the `pallet-revive/pallet-revive-eth-rpc` dependency of `polkadot-sdk`. I removed the other dependencies as well since I feel it does not make sense to still keep them once `pallet-revive` is out. 3. Releasing correct crates for `pallet-revive*` and use them in `polkadot-sdk` isn't yet necessary IMO, since some things still need to be polished, and given their builds fail when building certain features, they are not usable by users fully, so maybe not worth keeping partial working functionality around just for the sake of having the crates in `polkadot-sdk` - please challenge this if you think differently. Ideally, we will make these pallets available for developers to use via `polkadot-sdk` when all builds correctly with all features. ## Integration Runtime/Node devs will not be able to reference `pallet-revive*` pallets anymore via `polkadot-sdk`, so this is a breaking change, but if their usage is close to zero by polkadot devs we can tune it down and consider it a minor change for `polkadot-sdk`. ## Review Notes 1. If we think this requires a major bump for `polkadot-sdk`.. then we can't look at the PR as a fix for `stable2412` and associated published `polkadot-sdk` version. If we consider `pallet-revive` logic not being necessarily used by polkadot devs so not very breaking from usage perspective, then we can go with a minor bump and finally have a working `polkadot-sdk` for `stable2412. 2. We also considered fixing `pallet-revive` & `pallet-revive-eth-rpc` on `stable2412`, and publish correct versions on `crates.io`, and then follow with a `polkadot-sdk` publish that depends on them, and in the end `polkadot-sdk-parachain-template` workspace would build successfully based on `stable2412` crates, but this is more work which could've been done by now if it was necessary - e.g. in a scenario where actual developers were using them (instead of setting the crates with `publish = false`), so I think it makes sense to remove them for now from `polkadot-sdk`. 3. ~IMO this PR should be backported to stable2503 too. Releasing `polkadot-sdk` with `pallet-revive*` dependencies can be done with the June release if things are more stable by then.~ We actually want to fix `pallet-revive*` crates for stable2503, so must be kept in master and 2503 branch. --------- Signed-off-by: Iulian Barbu <[email protected]> Co-authored-by: Alexander Theißen <[email protected]> Co-authored-by: Francisco Aguirre <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update pallet-revive-fixtures so that it can build without looking up dependencies from the workspace --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Fix pallet-revive-uapi resolution when building pallet-revive-fixtures contracts follow up from #7844 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: xermicus <[email protected]>

pgherveou added 2 commits March 7, 2025 14:06

[pallet-revive] fixture as dev dep

f25f85f

rm comment

4274605

pgherveou added T7-smart_contracts This PR/Issue is related to smart contracts. R0-no-crate-publish-required The change does not require any crates to be re-published. labels Mar 7, 2025

Update from github-actions[bot] running command 'prdoc --audience run…

ba26ea9

…time_dev --bump patch'

ggwpez reviewed Mar 7, 2025

View reviewed changes

bkchr approved these changes Mar 9, 2025

View reviewed changes

pgherveou added 5 commits March 10, 2025 12:22

update build script

3302e40

remove path = ""

b5751e1

fix

cc66426

fixes

6e16dda

fix

ed4c564

pgherveou requested review from a team as code owners March 10, 2025 11:34

pgherveou added 3 commits March 10, 2025 12:46

rm files

200ef61

update name

eeba81f

rm prdoc

bf47131

athei reviewed Mar 10, 2025

View reviewed changes

pgherveou added 4 commits March 10, 2025 14:06

use include! instead of ff

bb38e2c

rm

5dcb423

ignore doctest

1ba55e7

update prdoc

ab4d77f

pgherveou enabled auto-merge March 11, 2025 11:59

iulianbarbu mentioned this pull request Mar 12, 2025

[stable2412] pallet-revive: remove related crates from umbrella #7894

Merged

Merge branch 'master' into pg/fixture-as-dev

4dcb11d

xermicus approved these changes Mar 13, 2025

View reviewed changes

pgherveou added this pull request to the merge queue Mar 13, 2025

pgherveou removed this pull request from the merge queue due to a manual request Mar 13, 2025

sort and filter of find just to be safe

f47818c

pgherveou enabled auto-merge March 13, 2025 12:11

Merge branch 'master' into pg/fixture-as-dev

0e6caec

pgherveou added this pull request to the merge queue Mar 13, 2025

auto-merge was automatically disabled March 13, 2025 14:31
Pull Request is not mergeable

Merged via the queue into master with commit 8265c65 Mar 13, 2025
237 of 243 checks passed

pgherveou deleted the pg/fixture-as-dev branch March 13, 2025 14:44

This was referenced Mar 14, 2025

[pallet-revive] Fix pallet-revive-fixtures build.rs #7928

Merged

[pallet-revive] backports 2503 #7929

Merged

ggwpez mentioned this pull request Jun 4, 2025

Bump to stable2503 polkadot-fellows/runtimes#711

Merged

7 tasks

github-actions bot mentioned this pull request Jun 10, 2025

Update polkadot-sdk from stable2412 to stable2503 moondance-labs/tanssi#1087

Closed

This was referenced Jul 16, 2025

Update polkadot-sdk from stable2412 to stable2503 moonbeam-foundation/moonbeam#3362

Closed

Update polkadot-sdk from stable2412 to stable2503-7 moonbeam-foundation/moonbeam#3363

Closed

pgherveou added this to [preview] release tracker Mar 20, 2026

github-project-automation bot moved this from Todo to Done in [preview] release tracker Mar 20, 2026

github-project-automation bot moved this to Todo in [preview] release tracker Mar 20, 2026

pgherveou removed this from [preview] release tracker Mar 20, 2026

Conversation

pgherveou commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pgherveou commented Mar 7, 2025

Uh oh!

ggwpez left a comment

Choose a reason for hiding this comment

Uh oh!

pgherveou commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pgherveou commented Mar 7, 2025

Uh oh!

athei commented Mar 10, 2025

Uh oh!

pgherveou commented Mar 10, 2025

Uh oh!

pgherveou commented Mar 10, 2025

Uh oh!

github-actions bot commented Mar 10, 2025

Uh oh!

athei Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

pgherveou Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

athei Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

paritytech-workflow-stopper bot commented Mar 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

pgherveou commented Mar 7, 2025 •

edited

Loading

pgherveou commented Mar 7, 2025 •

edited

Loading