[DNM] Implementation of `ah-client` and `rc-client` staking pallets (the old one)#7357

Closed

tdimitrov wants to merge 212 commits intomasterfrom

tsv-ahm-staking-pallet

Contributor

tdimitrov commented Jan 28, 2025 •

edited

Loading

This PR is work in progress.

Related issues: #6167 and #6166

This PR introduces the initial structure for pallet-ah-client and pallet-rc-client. These pallets will reside on the relay chain and AssetHub, respectively, and will manage the interaction between pallet-session on the relay chain and pallet-staking on AssetHub.

Both pallets are experimental and not intended for production use.

TODOs:

Probably handle [AHM] Remove dependency to full exposure for validator identification on RC pallets #6344 here.

gpestana and others added 30 commits

October 13, 2024 15:34


          init: adds EPM-MB, multipaged types and primitives

3f6bf3f


          refactors staking pallet with new paginated types

8a682b8


          refactors election-multiphase pallet with new paginated types

94ff073


          nits for dependent pallets and runtimes

1527bd6


          adds ElectionProvider::ongoing to trait and impls

5cb1de1


          Merge branch 'master' into gpestana/epm-mb

50d9698


          clean up sp-staking

43eec4b


          clean up and rustdoc for epm-support

11dd785


          Merge branch 'gpestana/epm-mb' of github.com:paritytech/polkadot-sdk …

d446ed0

…into gpestana/epm-mb


          nits onchain election provider

5c17573


          EPM nits and rustdoc improvements

ee7bdd4


          clean up and rustdocs for EPM core and sub pallets

f30b548


          rustdocs and nits

e7bf7dc


          Merge branch 'master' into gpestana/epm-mb

f810692


          adds prdoc

bf67a3e


          fixes prdoc

345840d


          removes from all pallets

52dcee9


          Adds new tests for verifier pallet

6d506e2


          implements hold logic in signed pallet; finishes implementing bail call

430532a


          finishes signed pallet

068e0fd


          Merge branch 'master' into gpestana/epm-mb-merge

5ca0bab


          updates inherent call in unsigned phase to new interfaces

385500d


          licence header nit

b4019bb


          Merge branch 'master' into gpestana/epm-mb

9f30e2d


          removes epm-mb

82abba1


          nit fix in bags list remote tests


          nit fix prdoc


          Merge branch 'master' into gpestana/epm-mb

18813c9


          Addresses PR reviews (removes all paged types/configs from epm and nits)

a92d44a


          improve memory efficiency of try into bounded supports; tests

3d1a330

github-actions bot and others added 10 commits

February 14, 2025 08:29


          Update from kianenigma running command 'prdoc --force'

6769acb


          prdco

2aca247


          taplo format

6e52afb


          check-umbrella

b32847e


          Merge branch 'kiz-multi-block-eletion' into tsv-ahm-staking-pallet

5e01cd8


          taplo format

df56555


          small cleanup


          Fix ah-client Cargo file

b7fd1d9


          clippy

a727577


          publish = false

fcb6dfc

kianenigma reviewed

View reviewed changes

substrate/frame/staking/ah-client/src/lib.rs Show resolved Hide resolved

kianenigma reviewed

View reviewed changes

substrate/frame/staking/ah-client/src/lib.rs

+              	// A session with the given index has ended. The block authors with their corresponding
+              	// session points are provided.
+              	#[codec(index = 1)]
+              	RelayChainSessionEnd(SessionIndex, Vec<(AccountId32, u32)>),

Contributor

kianenigma Feb 15, 2025

Kusama: 32 + 4 * 1000 ~ 4K bytes
Polkadot: 32 + 4 * 500 ~ 2K bytes

kianenigma reviewed

View reviewed changes

substrate/frame/staking/ah-client/src/lib.rs

+              	pub struct Pallet<T>(_);
+              	// TODO: should contain some initial state, otherwise starting from genesis won't work
+              	#[pallet::storage]

Contributor

kianenigma Feb 15, 2025

For testing you can use #[pallet::genesis].

For AHM, I think it can remain empty and soon enough a new election result will come form AH.

kianenigma reviewed

View reviewed changes

substrate/frame/staking/ah-client/src/lib.rs Show resolved Hide resolved

kianenigma reviewed

View reviewed changes

substrate/frame/staking/ah-client/src/lib.rs

+              	/// Keeps track of the session points for each block author in the current session.
+              	#[pallet::storage]
+              	pub type BlockAuthors<T: Config> = StorageMap<_, Twox64Concat, AccountId32, u32, ValueQuery>;

Contributor

kianenigma Feb 15, 2025

You might want to call this ValidatorPoints.

Also, I just realized that other than block authorship, the parachains protocol also adds points for parachain work.

Contributor

kianenigma Feb 15, 2025

polkadot-sdk/polkadot/runtime/parachains/src/reward_points.rs

Line 64 in c1915af

<pallet_staking::Pallet<C>>::reward_by_ids(rewards);

github-merge-queue bot pushed a commit that referenced this pull request


          [AHM] Multi-block staking election pallet (#7282)

a025562

## Multi Block Election Pallet

This PR adds the first iteration of the multi-block staking pallet. 

From this point onwards, the staking and its election provider pallets
are being customized to work in AssetHub. While usage in solo-chains is
still possible, it is not longer the main focus of this pallet. For a
safer usage, please fork and user an older version of this pallet.

---

## Replaces

- [x] #6034 
- [x] #5272

## Related PRs: 

- [x] #7483
- [ ] #7357
- [ ] #7424
- [ ] paritytech/polkadot-staking-miner#955

This branch can be periodically merged into
#7358 ->
#6996

## TODOs: 

- [x] rebase to master 
- Benchmarking for staking critical path
  - [x] snapshot
  - [x] election result
- Benchmarking for EPMB critical path
  - [x] snapshot
  - [x] verification
  - [x] submission
  - [x] unsigned submission
  - [ ] election results fetching
- [ ] Fix deletion weights. Either of
  - [ ] Garbage collector + lazy removal of all paged storage items
  - [ ] Confirm that deletion is small PoV footprint.
- [ ] Move election prediction to be push based. @tdimitrov 
- [ ] integrity checks for bounds 
- [ ] Properly benchmark this as a part of CI -- for now I will remove
them as they are too slow
- [x] add try-state to all pallets
- [x] Staking to allow genesis dev accounts to be created internally
- [x] Decouple miner config so @niklasad1 can work on the miner
72841b7
- [x] duplicate snapshot page reported by @niklasad1 
- [ ] #6520 or equivalent
-- during snapshot, `VoterList` must be locked
- [ ] Move target snapshot to a separate block

---------

Co-authored-by: Gonçalo Pestana <[email protected]>
Co-authored-by: Ankan <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Guillaume Thiolliere <[email protected]>
Co-authored-by: Giuseppe Re <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Base automatically changed from kiz-multi-block-eletion to master

February 15, 2025 00:17

github-actions bot requested review from a team and acatangiu as code owners

February 15, 2025 00:17


          Merge branch 'master' into tsv-ahm-staking-pallet

efad6b4

tdimitrov changed the title ~~[WIP] Implementation of ah-client and rc-client staking pallets~~ [WIP] Implementation of ah-client and rc-client staking pallets [OLD ONE]

tdimitrov mentioned this pull request

Implementation of ah-client and rc-client staking pallets #7582

Merged

1 task

tdimitrov changed the title ~~[WIP] Implementation of ah-client and rc-client staking pallets [OLD ONE]~~ [DNM] Implementation of ah-client and rc-client staking pallets (the old one)

paritytech-workflow-stopper bot commented Feb 15, 2025

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/13342564238
Failed job name: test-linux-stable

tdimitrov closed this

tdimitrov deleted the tsv-ahm-staking-pallet branch

February 15, 2025 08:20

github-merge-queue bot pushed a commit that referenced this pull request


          Implementation of ah-client and rc-client staking pallets (#7582)

669b889

Recreation of #7357 on
top of master. The old PR messes up the git history too much so I am
recreating it from scratch.

This PR is work in progress. It's purpose is to commit initial structure
of `pallet-staking-ah-client` and `pallet-staking-rc-client` to master.
The changes will be polished by a follow up PRs which will be
backported.

Related issues: #6167
and #6166

This PR introduces the initial structure for `pallet-ah-client` and
`pallet-rc-client`. These pallets will reside on the relay chain and
AssetHub, respectively, and will manage the interaction between
`pallet-session` on the relay chain and `pallet-staking` on AssetHub.

Both pallets are experimental and not intended for production use.

TODOs:
- [ ] Probably handle
#6344 here.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ankan <[email protected]>

clangenb pushed a commit to clangenb/polkadot-sdk that referenced this pull request


          [AHM] Multi-block staking election pallet (paritytech#7282)

## Multi Block Election Pallet

This PR adds the first iteration of the multi-block staking pallet. 

From this point onwards, the staking and its election provider pallets
are being customized to work in AssetHub. While usage in solo-chains is
still possible, it is not longer the main focus of this pallet. For a
safer usage, please fork and user an older version of this pallet.

---

## Replaces

- [x] paritytech#6034 
- [x] paritytech#5272

## Related PRs: 

- [x] paritytech#7483
- [ ] paritytech#7357
- [ ] paritytech#7424
- [ ] paritytech/polkadot-staking-miner#955

This branch can be periodically merged into
paritytech#7358 ->
paritytech#6996

## TODOs: 

- [x] rebase to master 
- Benchmarking for staking critical path
  - [x] snapshot
  - [x] election result
- Benchmarking for EPMB critical path
  - [x] snapshot
  - [x] verification
  - [x] submission
  - [x] unsigned submission
  - [ ] election results fetching
- [ ] Fix deletion weights. Either of
  - [ ] Garbage collector + lazy removal of all paged storage items
  - [ ] Confirm that deletion is small PoV footprint.
- [ ] Move election prediction to be push based. @tdimitrov 
- [ ] integrity checks for bounds 
- [ ] Properly benchmark this as a part of CI -- for now I will remove
them as they are too slow
- [x] add try-state to all pallets
- [x] Staking to allow genesis dev accounts to be created internally
- [x] Decouple miner config so @niklasad1 can work on the miner
72841b7
- [x] duplicate snapshot page reported by @niklasad1 
- [ ] paritytech#6520 or equivalent
-- during snapshot, `VoterList` must be locked
- [ ] Move target snapshot to a separate block

---------

Co-authored-by: Gonçalo Pestana <[email protected]>
Co-authored-by: Ankan <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Guillaume Thiolliere <[email protected]>
Co-authored-by: Giuseppe Re <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

clangenb pushed a commit to clangenb/polkadot-sdk that referenced this pull request


          Implementation of ah-client and rc-client staking pallets (paritytech…

1c56d05

…#7582)

Recreation of paritytech#7357 on
top of master. The old PR messes up the git history too much so I am
recreating it from scratch.

This PR is work in progress. It's purpose is to commit initial structure
of `pallet-staking-ah-client` and `pallet-staking-rc-client` to master.
The changes will be polished by a follow up PRs which will be
backported.

Related issues: paritytech#6167
and paritytech#6166

This PR introduces the initial structure for `pallet-ah-client` and
`pallet-rc-client`. These pallets will reside on the relay chain and
AssetHub, respectively, and will manage the interaction between
`pallet-session` on the relay chain and `pallet-staking` on AssetHub.

Both pallets are experimental and not intended for production use.

TODOs:
- [ ] Probably handle
paritytech#6344 here.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ankan <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R1-breaking_change T2-pallets T8-polkadot