[AHM] Adds multi-block election types and refactors current pallets to support new interfaces and types by gpestana · Pull Request #6034 · paritytech/polkadot-sdk

gpestana · 2024-10-13T23:49:28Z

This PR refactors the types and structs required to run a mulit-block election and updates the EPM, staking-pallet and all dependent pallets to use the multi-block types. The Westend runtime is configured to run a 1 paged election, which is a noop refactor compared to the current single-block election.

Notable changes since last reviews:

Tasks based on feedback that can be closed after merging this PR: Umbrella ticket for multi-block election tasks to improve after PR#6034.

The multi-block election provider pallet is wip and it's added in a separate PR (#6213).

To-do before merging:

test with chopsticks/follow-chain
add benchmarks for on_intialize in pallet staking

substrate/frame/election-provider-support/src/lib.rs

Ank4n

Only looked at traits. Will do another pass.

substrate/frame/election-provider-support/src/lib.rs

…into gpestana/epm-mb

github-actions · 2025-01-20T18:27:32Z

Command "bench --pallet pallet_staking" has failed ❌! See logs here

Details

Command output:

❌ Failed benchmarks of runtimes/pallets:
-- dev: ['pallet_staking']
✅ Successful benchmarks of runtimes/pallets:
-- westend: ['pallet_staking']

kianenigma · 2025-01-20T18:34:20Z

/cmd fmt

github-actions · 2025-01-20T18:36:30Z

Command "fmt" has started 🚀 See logs here

github-actions · 2025-01-20T18:36:53Z

Command "fmt" has finished ✅ See logs here

…tana/epm-mb

kianenigma · 2025-01-23T09:52:33Z

/cmd bench --pallet pallet_staking

github-actions · 2025-01-23T09:56:21Z

Command "bench --pallet pallet_staking" has started 🚀 See logs here

substrate/frame/staking/src/pallet/mod.rs

Co-authored-by: Oliver Tale-Yazdi <[email protected]>

…into gpestana/epm-mb

github-actions · 2025-01-23T14:23:27Z

Command "bench --pallet pallet_staking" has failed ❌! See logs here

Details

Command output:

❌ Failed benchmarks of runtimes/pallets:
-- dev: ['pallet_staking']
✅ Successful benchmarks of runtimes/pallets:
-- westend: ['pallet_staking']

paritytech-workflow-stopper · 2025-01-23T15:03:14Z

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12931586313
Failed job name: run-frame-omni-bencher

kianenigma · 2025-01-27T09:15:38Z

This PR is in more or less good shape, but fixing its benchmarks would lead to an amount of work that I don't see useful because #7282 will alter more things, and fixing them there would be more fruitful.

@Ank4n @tdimitrov if you agree, I will close this, and we will make #7282 the main feature branch of all things staking related?

This PR can still be used as a checkpoint to audit part of the code @seadanda.

tdimitrov · 2025-01-28T07:21:41Z

This PR is in more or less good shape, but fixing its benchmarks would lead to an amount of work that I don't see useful because #7282 will alter more things, and fixing them there would be more fruitful.

@Ank4n @tdimitrov if you agree, I will close this, and we will make #7282 the main feature branch of all things staking related?

This PR can still be used as a checkpoint to audit part of the code @seadanda.

If I understand correctly both PRs add multi-block election to staking. I have no preference which one we will use as a feature branch.

Out of curiosity - why they both exist?

@tdimitrov

## Multi Block Election Pallet This PR adds the first iteration of the multi-block staking pallet. From this point onwards, the staking and its election provider pallets are being customized to work in AssetHub. While usage in solo-chains is still possible, it is not longer the main focus of this pallet. For a safer usage, please fork and user an older version of this pallet. --- ## Replaces - [x] #6034 - [x] #5272 ## Related PRs: - [x] #7483 - [ ] #7357 - [ ] #7424 - [ ] paritytech/polkadot-staking-miner#955 This branch can be periodically merged into #7358 -> #6996 ## TODOs: - [x] rebase to master - Benchmarking for staking critical path - [x] snapshot - [x] election result - Benchmarking for EPMB critical path - [x] snapshot - [x] verification - [x] submission - [x] unsigned submission - [ ] election results fetching - [ ] Fix deletion weights. Either of - [ ] Garbage collector + lazy removal of all paged storage items - [ ] Confirm that deletion is small PoV footprint. - [ ] Move election prediction to be push based. @tdimitrov - [ ] integrity checks for bounds - [ ] Properly benchmark this as a part of CI -- for now I will remove them as they are too slow - [x] add try-state to all pallets - [x] Staking to allow genesis dev accounts to be created internally - [x] Decouple miner config so @niklasad1 can work on the miner 72841b7 - [x] duplicate snapshot page reported by @niklasad1 - [ ] #6520 or equivalent -- during snapshot, `VoterList` must be locked - [ ] Move target snapshot to a separate block --------- Co-authored-by: Gonçalo Pestana <[email protected]> Co-authored-by: Ankan <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Guillaume Thiolliere <[email protected]> Co-authored-by: Giuseppe Re <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

@tdimitrov

## Multi Block Election Pallet This PR adds the first iteration of the multi-block staking pallet. From this point onwards, the staking and its election provider pallets are being customized to work in AssetHub. While usage in solo-chains is still possible, it is not longer the main focus of this pallet. For a safer usage, please fork and user an older version of this pallet. --- ## Replaces - [x] paritytech#6034 - [x] paritytech#5272 ## Related PRs: - [x] paritytech#7483 - [ ] paritytech#7357 - [ ] paritytech#7424 - [ ] paritytech/polkadot-staking-miner#955 This branch can be periodically merged into paritytech#7358 -> paritytech#6996 ## TODOs: - [x] rebase to master - Benchmarking for staking critical path - [x] snapshot - [x] election result - Benchmarking for EPMB critical path - [x] snapshot - [x] verification - [x] submission - [x] unsigned submission - [ ] election results fetching - [ ] Fix deletion weights. Either of - [ ] Garbage collector + lazy removal of all paged storage items - [ ] Confirm that deletion is small PoV footprint. - [ ] Move election prediction to be push based. @tdimitrov - [ ] integrity checks for bounds - [ ] Properly benchmark this as a part of CI -- for now I will remove them as they are too slow - [x] add try-state to all pallets - [x] Staking to allow genesis dev accounts to be created internally - [x] Decouple miner config so @niklasad1 can work on the miner 72841b7 - [x] duplicate snapshot page reported by @niklasad1 - [ ] paritytech#6520 or equivalent -- during snapshot, `VoterList` must be locked - [ ] Move target snapshot to a separate block --------- Co-authored-by: Gonçalo Pestana <[email protected]> Co-authored-by: Ankan <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Guillaume Thiolliere <[email protected]> Co-authored-by: Giuseppe Re <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

gpestana added 4 commits October 13, 2024 15:34

init: adds EPM-MB, multipaged types and primitives

3f6bf3f

refactors staking pallet with new paginated types

8a682b8

refactors election-multiphase pallet with new paginated types

94ff073

nits for dependent pallets and runtimes

1527bd6

gpestana self-assigned this Oct 13, 2024

gpestana requested a review from a team as a code owner October 13, 2024 23:49

gpestana requested a review from Ank4n October 13, 2024 23:49

gpestana marked this pull request as draft October 13, 2024 23:49

gpestana added the T2-pallets This PR/Issue is related to a particular pallet. label Oct 13, 2024

gpestana mentioned this pull request Oct 14, 2024

WIP: monitor command for the multi-block staking miner paritytech/polkadot-staking-miner#910

Closed

4 tasks

adds ElectionProvider::ongoing to trait and impls

5cb1de1

gpestana mentioned this pull request Oct 14, 2024

Introduces multi-block election types and traits and refactors relevant pallets #5438

Closed

Merge branch 'master' into gpestana/epm-mb

50d9698

Ank4n reviewed Oct 15, 2024

View reviewed changes

substrate/frame/election-provider-support/src/lib.rs Show resolved Hide resolved

Ank4n reviewed Oct 15, 2024

View reviewed changes

gpestana added 8 commits October 18, 2024 12:44

clean up sp-staking

43eec4b

clean up and rustdoc for epm-support

11dd785

Merge branch 'gpestana/epm-mb' of github.com:paritytech/polkadot-sdk …

d446ed0

…into gpestana/epm-mb

nits onchain election provider

5c17573

EPM nits and rustdoc improvements

ee7bdd4

clean up and rustdocs for EPM core and sub pallets

f30b548

rustdocs and nits

e7bf7dc

Merge branch 'master' into gpestana/epm-mb

f810692

gpestana marked this pull request as ready for review October 18, 2024 16:42

gpestana added 2 commits October 18, 2024 18:57

adds prdoc

bf67a3e

fixes prdoc

345840d

removes from all pallets

52dcee9

Merge branch 'master' into gpestana/epm-mb

ab861ea

Update from kianenigma running command 'fmt'

ebaeaf5

kianenigma added 2 commits January 23, 2025 09:50

Merge branch 'master' of github.com:paritytech/polkadot-sdk into gpes…

fb3b699

…tana/epm-mb

bump storage version

336642d

kianenigma changed the title ~~Adds multi-block election types and refactors current pallets to support new interfaces and types~~ [AHM] Adds multi-block election types and refactors current pallets to support new interfaces and types Jan 23, 2025

ggwpez reviewed Jan 23, 2025

View reviewed changes

substrate/frame/staking/src/pallet/mod.rs Outdated Show resolved Hide resolved

ggwpez reviewed Jan 23, 2025

View reviewed changes

substrate/frame/staking/src/pallet/mod.rs Outdated Show resolved Hide resolved

ggwpez reviewed Jan 23, 2025

View reviewed changes

substrate/frame/staking/src/pallet/mod.rs Outdated Show resolved Hide resolved

kianenigma and others added 4 commits January 23, 2025 14:11

Update substrate/frame/staking/src/pallet/mod.rs

c40f986

Co-authored-by: Oliver Tale-Yazdi <[email protected]>

pub all storage types

aa4d903

Merge branch 'gpestana/epm-mb' of github.com:paritytech/polkadot-sdk …

fd8c605

…into gpestana/epm-mb

Merge branch 'master' into gpestana/epm-mb

a550523

kianenigma added 2 commits January 23, 2025 14:32

more clippy fixes

039f2f7

undo toml file update

f24232f

kianenigma closed this Jan 28, 2025

kianenigma mentioned this pull request Jan 28, 2025

[AHM] Multi-block staking election pallet #7282

Merged

26 tasks

Ank4n deleted the gpestana/epm-mb branch April 18, 2025 07:48

ggwpez mentioned this pull request Jun 4, 2025

Bump to stable2503 polkadot-fellows/runtimes#711

Merged

7 tasks

Conversation

gpestana commented Oct 13, 2024 • edited by kianenigma Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Ank4n left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 20, 2025

Uh oh!

kianenigma commented Jan 20, 2025

Uh oh!

github-actions bot commented Jan 20, 2025

Uh oh!

github-actions bot commented Jan 20, 2025

Uh oh!

kianenigma commented Jan 23, 2025

Uh oh!

github-actions bot commented Jan 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 23, 2025

Uh oh!

paritytech-workflow-stopper bot commented Jan 23, 2025

Uh oh!

kianenigma commented Jan 27, 2025

Uh oh!

tdimitrov commented Jan 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

gpestana commented Oct 13, 2024 •

edited by kianenigma

Loading