feat: experimental-monitor-multi-block support#955
Merged
Conversation
kianenigma
reviewed
Jan 23, 2025
26 tasks
niklasad1
commented
Jan 31, 2025
niklasad1
commented
Feb 3, 2025
niklasad1
commented
Mar 4, 2025
niklasad1
commented
Mar 4, 2025
| } | ||
|
|
||
| #[tokio::test] | ||
| #[ignore] |
Contributor
|
Some todos:
|
niklasad1
commented
Mar 7, 2025
experimental-monitor-multi-block support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
multi-block palletwhich is added as new monitor commandexperimental-monitor-multi-blockThus, the "old miner a.k.a single-block miner" isn't modified and should work as it did before.
To run the experimental multi-block command can be done as follows:
Manual testing done:
Things to improve (possibly after merging):
parachain assethub-nextThis is not sufficient because we must also make sure that all pages have been submitted if requested.
AFAIU, otherwise the miner may be slashed
Extra notes for reviewer, lots of code is changed due to refactoring but the most important parts is: