Skip to content

Contracts: Stabilize APIs#3384

Merged
pgherveou merged 9 commits intomasterfrom
pg/call_v2
Feb 20, 2024
Merged

Contracts: Stabilize APIs#3384
pgherveou merged 9 commits intomasterfrom
pg/call_v2

Conversation

@pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Feb 19, 2024 •
edited
Loading

Remove #[unstable] on call_v2, instantiate_v2, lock_delegate_dependency and unlock_delegate_dependency.
See ink! integrations:

@pgherveou pgherveou requested a review from athei as a code owner February 19, 2024 10:45
@pgherveou pgherveou changed the title Contracts: Stabilize call_v2 Contracts: Stabilize APIs Feb 19, 2024
@pgherveou pgherveou added the T7-smart_contracts This PR/Issue is related to smart contracts. label Feb 19, 2024
@athei
Copy link
Member

athei commented Feb 19, 2024

I think we need to change the behaviour of callv2 before stabilising: #3392

It's out last change but I don't think it will affect the ink! implementation.

pgherveou
pgherveou commented Feb 19, 2024
View reviewed changes
@pgherveou
Copy link
Contributor Author

pgherveou commented Feb 19, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Feb 19, 2024 •
edited
Loading

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5267778 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-b2af51a3-796b-4d22-a564-f9f73ae3398c to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Feb 19, 2024

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5267778 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5267778/artifacts/download.

@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented Feb 19, 2024

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5268384

@pgherveou pgherveou enabled auto-merge February 20, 2024 09:22
@pgherveou pgherveou added this pull request to the merge queue Feb 20, 2024
Merged via the queue into master with commit d250a6e Feb 20, 2024
@pgherveou pgherveou deleted the pg/call_v2 branch February 20, 2024 17:55
paritytech-ci pushed a commit that referenced this pull request Feb 20, 2024
@pgherveou
Contracts: Stabilize APIs (#3384)
85ab2c2 
Remove `#[unstable]` on `call_v2`, `instantiate_v2`,
`lock_delegate_dependency` and `unlock_delegate_dependency`.
See ink! integrations: 
- call_v2: use-ink/ink#2077
- instantiate_v2: <TODO>
- lock/unlock dependency: use-ink/ink#2076
franciscoaguirre pushed a commit that referenced this pull request Feb 22, 2024
@pgherveou @franciscoaguirre
Contracts: Stabilize APIs (#3384)
c3c058e 
Remove `#[unstable]` on `call_v2`, `instantiate_v2`,
`lock_delegate_dependency` and `unlock_delegate_dependency`.
See ink! integrations: 
- call_v2: use-ink/ink#2077
- instantiate_v2: <TODO>
- lock/unlock dependency: use-ink/ink#2076
@pgherveou pgherveou mentioned this pull request Mar 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 7, 2024
@pgherveou
Contracts: Remove unstable on lock/unlock_delegate_dependency host fns (
de9411a 
#3606)

Oversight from PR #3384.
These 2 functions should have been tagged as stable
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@pgherveou
Contracts: Stabilize APIs (paritytech#3384)
81370df 
Remove `#[unstable]` on `call_v2`, `instantiate_v2`,
`lock_delegate_dependency` and `unlock_delegate_dependency`.
See ink! integrations: 
- call_v2: use-ink/ink#2077
- instantiate_v2: <TODO>
- lock/unlock dependency: use-ink/ink#2076
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@pgherveou
Contracts: Remove unstable on lock/unlock_delegate_dependency host fns (
d579037 
paritytech#3606)

Oversight from PR paritytech#3384.
These 2 functions should have been tagged as stable
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
@chungquantin chungquantin mentioned this pull request Aug 4, 2024
Closed
4 tasks
@chungquantin chungquantin mentioned this pull request Aug 12, 2024
Merged
4 tasks
@Aideepakchaudhary Aideepakchaudhary mentioned this pull request Oct 14, 2024
Closed
@LayNath242 LayNath242 mentioned this pull request Dec 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@athei athei athei approved these changes

+1 more reviewer

@ascjones ascjones ascjones approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T7-smart_contracts This PR/Issue is related to smart contracts.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pgherveou @athei @paritytech-cicd-pr @ascjones