delegate_dependency api calls

[ascjones]

Adds support for two new host functions

• lock_delegate_dependency: prevents the code at the given code hash for being removed.
• unlock_delegate_dependency: releases the lock on the code being removed from the current contract.

Having a delegate dependency allows contracts to safely delegate to another code_hash with the guarantee that it cannot be deleted. See paritytech/substrate#14079.

I have modified the upgradeable-contracts/delegator integration test to demonstrate these new calls. For that purpose I have also added remove_code extrinsic to the e2e client.

🟡 Requires version of pallet_contracts including paritytech/polkadot-sdk@d250a6e

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.67%. Comparing base (1e46971) to head (d20cd52).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2076      +/-   ##
==========================================
+ Coverage   53.64%   53.67%   +0.02%     
==========================================
  Files         224      224              
  Lines        7046     7046              
  Branches     3118     3118              
==========================================
+ Hits         3780     3782       +2     
+ Misses       3266     3264       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch with cargo-contract and comparing them to ink! master:

Contract	Upstream Size (kB)	PR Size (kB)	Diff (kB)	Diff (%)	Change
call-builder-return-value	9.237	9.237	0	0	➖
call-runtime	2.061	2.061	0	0	➖
combined-extension	2.12	2.12	0	0	➖
conditional-compilation	1.49	1.49	0	0	➖
contract-storage	7.568	7.568	0	0	➖
contract-terminate	1.329	1.329	0	0	➖
contract-transfer	1.689	1.689	0	0	➖
cross-contract-calls	5.835	5.835	0	0	➖
cross-contract-calls/other-contract	1.583	1.583	0	0	➖
custom-allocator	7.775	7.775	0	0	➖
custom-environment	2.146	2.146	0	0	➖
dns	7.318	7.318	0	0	➖
e2e-call-runtime	1.296	1.296	0	0	➖
e2e-runtime-only-backend	1.881	1.881	0	0	➖
erc1155	14.308	14.308	0	0	➖
erc20	6.918	6.918	0	0	➖
erc721	10.007	10.007	0	0	➖
events	5.258	5.258	0	0	➖
flipper	1.639	1.639	0	0	➖
incrementer	1.504	1.504	0	0	➖
lang-err-integration-tests/call-builder-delegate	2.638	2.638	0	0	➖
lang-err-integration-tests/call-builder	5.354	5.354	0	0	➖
lang-err-integration-tests/constructors-return-value	1.985	1.985	0	0	➖
lang-err-integration-tests/contract-ref	4.753	4.753	0	0	➖
lang-err-integration-tests/integration-flipper	1.815	1.815	0	0	➖
lazyvec-integration-test	4.616	4.616	0	0	➖
mapping-integration-tests	7.999	7.999	0	0	➖
mother	12.741	12.741	0	0	➖
multi-contract-caller	6.313	6.313	0	0	➖
multi-contract-caller/accumulator	1.378	1.378	0	0	➖
multi-contract-caller/adder	1.912	1.912	0	0	➖
multi-contract-caller/subber	1.932	1.932	0	0	➖
multisig	21.821	21.821	0	0	➖
payment-channel	5.659	5.659	0	0	➖
psp22-extension	7.071	7.071	0	0	➖
rand-extension	2.965	2.965	0	0	➖
sr25519-verification	1.142	1.142	0	0	➖
static-buffer	1.654	1.654	0	0	➖
trait-dyn-cross-contract-calls	2.887	2.887	0	0	➖
trait-dyn-cross-contract-calls/contracts/incrementer	1.545	1.545	0	0	➖
trait-erc20	7.294	7.294	0	0	➖
trait-flipper	1.49	1.49	0	0	➖
trait-incrementer	1.614	1.614	0	0	➖
upgradeable-contracts/delegator	3.928	3.928	0	0	➖
upgradeable-contracts/delegator/delegatee	1.609	1.609	0	0	➖
upgradeable-contracts/delegator/delegatee2	1.609	1.609	0	0	➖
upgradeable-contracts/set-code-hash-migration	1.743	1.743	0	0	➖
upgradeable-contracts/set-code-hash-migration/migration	1.45	1.45	0	0	➖
upgradeable-contracts/set-code-hash-migration/updated-incrementer	1.897	1.897	0	0	➖
upgradeable-contracts/set-code-hash	1.743	1.743	0	0	➖
upgradeable-contracts/set-code-hash/updated-incrementer	1.721	1.721	0	0	➖
wildcard-selector	2.846	2.846	0	0	➖

Link to the run | Last update: Fri Feb 23 19:33:22 CET 2024

[pgherveou]

lgtm

[cmichi]

Can you add a mention of the lock/unlock mechanism and the delegate2 package to https://github.com/paritytech/ink/tree/430a831b1e4084e154744910f36a9f40516699fe/integration-tests/upgradeable-contracts#delegator?

[ascjones]

Done 👍

[ascjones]

Ah oops I did that in the wrong PR 🙈 it is here: https://github.com/paritytech/ink/pull/2123/files#diff-7cf9db86b007053cf1ad83c5196420d3e5c582a7b3dbbc5d73edca22b4a452fa

[cmichi]

Thanks, Andrew!