contracts: Passing zero as deposit_limit to call_v2 correctly limits the deposit to nothing#3392
Merged
athei merged 1 commit intopg/call_v2from Feb 19, 2024
Merged
contracts: Passing zero as deposit_limit to call_v2 correctly limits the deposit to nothing#3392athei merged 1 commit intopg/call_v2from
athei merged 1 commit intopg/call_v2from
Conversation
|
The CI pipeline was cancelled due to failure one of the required jobs. |
pgherveou
approved these changes
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only affects unstable
v2versions ofcallandinstantiate. Also only when0was passed asdesposit_limit. Old behaviour was allowing all the remaining balance. New correct behaviour is to not allow any deposit. Otherwise both passing theSENTINELand encoding0would mean the same thing.