Fix ParentOrSiblings by franciscoaguirre · Pull Request #2428 · paritytech/polkadot-sdk

franciscoaguirre · 2023-11-21T15:34:08Z

We were not filtering for sibling parachains, but for sibling anything

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/xcm_config.rs

bkontur · 2023-11-30T11:31:54Z

bot fmt

command-bot · 2023-11-30T11:31:59Z

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4557170 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 19-7eae007e-906a-422f-be34-a03a3b853f8f to cancel this command or bot cancel to cancel all commands in this pull request.

muharem

I personally prefer such configs to be located within the runtime crate, not in common.

command-bot · 2023-11-30T11:34:20Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4557170 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4557170/artifacts/download.

franciscoaguirre · 2023-11-30T13:15:40Z

It's in common just because it's a configuration that is common to all our runtimes, as a way of deduplicating code

cumulus/parachains/common/src/xcm_config.rs

franciscoaguirre · 2023-12-10T12:09:37Z

bot fmt

command-bot · 2023-12-10T12:09:43Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4675696 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 13-2ae3e6c4-e154-4351-91c8-284f6dcd8c9c to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-12-10T12:11:23Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4675696 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4675696/artifacts/download.

…ins)

* Setup deps * Remove Koi from account migration test * paritytech/polkadot-sdk#1495 * Bump * paritytech/polkadot-sdk#1524 * !! paritytech/polkadot-sdk#1363 * paritytech/polkadot-sdk#1492 * paritytech/polkadot-sdk#1911 * paritytech/polkadot-sdk#1900 Signed-off-by: Xavier Lau <[email protected]> * paritytech/polkadot-sdk#1661 * paritytech/polkadot-sdk#2144 * paritytech/polkadot-sdk#2048 * paritytech/polkadot-sdk#1672 * paritytech/polkadot-sdk#2303 * paritytech/polkadot-sdk#1256 * Remove identity and vesting * Fixes * paritytech/polkadot-sdk#2657 * paritytech/polkadot-sdk#1313 * paritytech/polkadot-sdk#2331 * paritytech/polkadot-sdk#2409 part.1 * paritytech/polkadot-sdk#2767 * paritytech/polkadot-sdk#2521 Signed-off-by: Xavier Lau <[email protected]> * paritytech/polkadot-sdk#1222 * paritytech/polkadot-sdk#1234 part.1 * Satisfy compiler * XCM V4 part.1 * paritytech/polkadot-sdk#1246 * Remove pallet-democracy part.1 * paritytech/polkadot-sdk#2142 * paritytech/polkadot-sdk#2428 * paritytech/polkadot-sdk#3228 * XCM V4 part.2 * Bump * Build all runtimes * Build node * Remove pallet-democracy Signed-off-by: Xavier Lau <[email protected]> * Format * Fix pallet tests * Fix precompile tests * Format * Fixes * Async, remove council, common pallet config * Fix `ethtx-forward` test case (#1519) * Fix ethtx-forward tests * Format * Fix following the review * Fixes * Fixes * Use default impl * Benchmark helper * Bench part.1 * Bench part.2 * Bench part.3 * Fix all tests * Typo * Feat * Fix EVM tracing build * Reuse upstream `proof_size_base_cost()` (#1521) * Format issue * Fixes * Fix CI --------- Signed-off-by: Xavier Lau <[email protected]> Co-authored-by: Bear Wang <[email protected]>

Fix ParentOrSiblings

61c0044

paritytech-review-bot bot requested review from a team November 21, 2023 15:34

acatangiu reviewed Nov 21, 2023

View reviewed changes

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/xcm_config.rs Outdated Show resolved Hide resolved

Move ParentOrSiblings to parachains-common

7bb402c

franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Nov 21, 2023

Rename ParentOrSiblings to be more expressive

aac4a4f

franciscoaguirre added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Nov 21, 2023

Merge branch 'master' into cis-parent-or-siblings

43af618

franciscoaguirre requested review from acatangiu, bkchr and gavofyork November 21, 2023 17:03

acatangiu approved these changes Nov 22, 2023

View reviewed changes

This was referenced Nov 30, 2023

XCMv4 #1230

Merged

parachains xcm config: fix for ParentOrSiblings type #2566

Closed

Merge remote-tracking branch 'origin/master' into cis-parent-or-siblings

cc7e12a

bkontur approved these changes Nov 30, 2023

View reviewed changes

muharem approved these changes Nov 30, 2023

View reviewed changes

".git/.scripts/commands/fmt/fmt.sh"

e8fc1a6

Merge branch 'master' into cis-parent-or-siblings

8989143

franciscoaguirre enabled auto-merge (squash) November 30, 2023 13:15

joepetrowski reviewed Nov 30, 2023

View reviewed changes

cumulus/parachains/common/src/xcm_config.rs Show resolved Hide resolved

franciscoaguirre added 2 commits November 30, 2023 18:25

Merge branch 'master' into cis-parent-or-siblings

cefd41a

Document type

cfd65bf

franciscoaguirre requested a review from joepetrowski November 30, 2023 17:28

joepetrowski approved these changes Nov 30, 2023

View reviewed changes

franciscoaguirre requested review from a team December 9, 2023 18:47

franciscoaguirre requested review from andresilva, athei and jsidorenko as code owners December 9, 2023 18:47

franciscoaguirre requested a review from a team December 9, 2023 18:47

franciscoaguirre requested review from a team and koute as code owners December 9, 2023 18:47

franciscoaguirre force-pushed the cis-parent-or-siblings branch from 69a13a5 to c40f54a Compare December 9, 2023 18:48

Merge branch 'master' into cis-parent-or-siblings

4208876

".git/.scripts/commands/fmt/fmt.sh"

7d2c098

franciscoaguirre added 2 commits December 12, 2023 15:50

Merge branch 'master' into cis-parent-or-siblings

56675fc

Merge branch 'master' into cis-parent-or-siblings

e48ac65

franciscoaguirre merged commit 313b2c4 into master Dec 12, 2023

franciscoaguirre deleted the cis-parent-or-siblings branch December 12, 2023 16:36

bkontur mentioned this pull request Dec 18, 2023

Coretime Chain #1479

Merged

3 tasks

bkontur added a commit to bkontur/runtimes that referenced this pull request Feb 15, 2024

[xcm] adapt paritytech/polkadot-sdk#2428 (ParentRelayOrSiblingParacha…

a29757d

…ins)

bkontur added a commit to bkontur/runtimes that referenced this pull request Feb 16, 2024

[xcm] adapt paritytech/polkadot-sdk#2428 (ParentRelayOrSiblingParacha…

44eefcc

…ins)

github-actions bot mentioned this pull request Feb 19, 2024

Update substrate/polkadot/cumulus from v1.3.0 to v1.6.0 moondance-labs/tanssi#419

Closed

github-actions bot mentioned this pull request Mar 13, 2024

Update polkadot-sdk from v1.3.0 to v1.7.2 moonbeam-foundation/moonbeam#2703

Closed

aurexav added a commit to darwinia-network/darwinia that referenced this pull request Jun 25, 2024

paritytech/polkadot-sdk#2428

b1d1ca6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ParentOrSiblings#2428

Fix ParentOrSiblings#2428
franciscoaguirre merged 16 commits intomasterfrom
cis-parent-or-siblings

franciscoaguirre commented Nov 21, 2023

Uh oh!

Uh oh!

bkontur commented Nov 30, 2023

Uh oh!

command-bot bot commented Nov 30, 2023 •

edited

Loading

Uh oh!

muharem left a comment

Uh oh!

command-bot bot commented Nov 30, 2023

Uh oh!

franciscoaguirre commented Nov 30, 2023

Uh oh!

Uh oh!

franciscoaguirre commented Dec 10, 2023

Uh oh!

command-bot bot commented Dec 10, 2023 •

edited

Loading

Uh oh!

command-bot bot commented Dec 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

franciscoaguirre commented Nov 21, 2023

Uh oh!

Uh oh!

bkontur commented Nov 30, 2023

Uh oh!

command-bot bot commented Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

muharem left a comment

Choose a reason for hiding this comment

Uh oh!

command-bot bot commented Nov 30, 2023

Uh oh!

franciscoaguirre commented Nov 30, 2023

Uh oh!

Uh oh!

franciscoaguirre commented Dec 10, 2023

Uh oh!

command-bot bot commented Dec 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Dec 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

command-bot bot commented Nov 30, 2023 •

edited

Loading

command-bot bot commented Dec 10, 2023 •

edited

Loading