Rename `ExportGenesisStateCommand` to `ExportGenesisHeadCommand` and make it respect custom genesis block builders by JoshOrndorff · Pull Request #2331 · paritytech/polkadot-sdk

JoshOrndorff · 2023-11-14T19:53:58Z

Closes #2326.

This PR both fixes a logic bug and replaces an incorrect name.

Bug Fix: Respecting custom genesis builder

Prior to this PR the standard logic for creating a genesis block was repeated inside of cumulus. This PR removes that duplicated logic, and calls into the proper BuildGenesisBlock implementation.

One consequence is that if the genesis block has already been initialized, it will not be re-created, but rather read from the database like it is for other node invocations. So you need to watch out for old unpurged data during the development process. Offchain tools may need to be updated accordingly. I've already filed paritytech/zombienet#1519

Rename: It doesn't export state. It exports head data.

The name export-genesis-state was always wrong, nad it's never too late to right a wrong. I've changed the name of the struct to ExportGenesisHeadCommand.

There is still the question of what to do with individual nodes' public CLIs. I have updated the parachain template to a reasonable default that preserves compatibility with tools that will expect export-genesis-state to still work. And I've chosen not to modify the public CLIs of any other nodes in the repo. I'll leave it up to their individual owners/maintains to decide whether that is appropriate.

bkchr

Generally looks good.

… export-genesis-... command

cumulus/parachain-template/node/src/cli.rs

JoshOrndorff · 2023-12-13T13:55:17Z

Thank you for your help getting this across the line 🙏

closes #2567 Followup for #2331 This PR contains multiple internal cleanups: 1. This gets rid of the functionality in `generate_genesis_block` which was only used in one benchmark 2. Fixed `transaction_pool` and `transaction_throughput` benchmarks failing since they require a tokio runtime now. 3. Removed `parachain_id` CLI option from the test parachain 4. Removed `expect` call from `RuntimeResolver`

Polkadot-Forum · 2024-01-26T17:10:53Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v1-6-0/5855/1

closes paritytech#2567 Followup for paritytech#2331 This PR contains multiple internal cleanups: 1. This gets rid of the functionality in `generate_genesis_block` which was only used in one benchmark 2. Fixed `transaction_pool` and `transaction_throughput` benchmarks failing since they require a tokio runtime now. 3. Removed `parachain_id` CLI option from the test parachain 4. Removed `expect` call from `RuntimeResolver`

- Upgrade Polkadot-sdk to v.1.6.0. - Update weights to reflect the new version. - Modify extrinsic weight test due to an improvement in weights. Notable Changes: - [Rename ExportGenesisStateCommand to ExportGenesisHeadCommand ](paritytech/polkadot-sdk#2331) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.6.0) [Release Analysis](https://forum.polkadot.network/t/polkadot-release-analysis-v1-6-0/58550) issue-1841

* Setup deps * Remove Koi from account migration test * paritytech/polkadot-sdk#1495 * Bump * paritytech/polkadot-sdk#1524 * !! paritytech/polkadot-sdk#1363 * paritytech/polkadot-sdk#1492 * paritytech/polkadot-sdk#1911 * paritytech/polkadot-sdk#1900 Signed-off-by: Xavier Lau <[email protected]> * paritytech/polkadot-sdk#1661 * paritytech/polkadot-sdk#2144 * paritytech/polkadot-sdk#2048 * paritytech/polkadot-sdk#1672 * paritytech/polkadot-sdk#2303 * paritytech/polkadot-sdk#1256 * Remove identity and vesting * Fixes * paritytech/polkadot-sdk#2657 * paritytech/polkadot-sdk#1313 * paritytech/polkadot-sdk#2331 * paritytech/polkadot-sdk#2409 part.1 * paritytech/polkadot-sdk#2767 * paritytech/polkadot-sdk#2521 Signed-off-by: Xavier Lau <[email protected]> * paritytech/polkadot-sdk#1222 * paritytech/polkadot-sdk#1234 part.1 * Satisfy compiler * XCM V4 part.1 * paritytech/polkadot-sdk#1246 * Remove pallet-democracy part.1 * paritytech/polkadot-sdk#2142 * paritytech/polkadot-sdk#2428 * paritytech/polkadot-sdk#3228 * XCM V4 part.2 * Bump * Build all runtimes * Build node * Remove pallet-democracy Signed-off-by: Xavier Lau <[email protected]> * Format * Fix pallet tests * Fix precompile tests * Format * Fixes * Async, remove council, common pallet config * Fix `ethtx-forward` test case (#1519) * Fix ethtx-forward tests * Format * Fix following the review * Fixes * Fixes * Use default impl * Benchmark helper * Bench part.1 * Bench part.2 * Bench part.3 * Fix all tests * Typo * Feat * Fix EVM tracing build * Reuse upstream `proof_size_base_cost()` (#1521) * Format issue * Fixes * Fix CI --------- Signed-off-by: Xavier Lau <[email protected]> Co-authored-by: Bear Wang <[email protected]>

- Upgrade Polkadot-sdk to v.1.6.0. - Update weights to reflect the new version. - Modify extrinsic weight test due to an improvement in weights. Notable Changes: - [Rename ExportGenesisStateCommand to ExportGenesisHeadCommand ](paritytech/polkadot-sdk#2331) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.6.0) [Release Analysis](https://forum.polkadot.network/t/polkadot-release-analysis-v1-6-0/58550) issue-1841

- Upgrade Polkadot-sdk to v.1.6.0. - Update weights to reflect the new version. Notable Changes: - [Rename ExportGenesisStateCommand to ExportGenesisHeadCommand ](paritytech/polkadot-sdk#2331) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.6.0) [Release Analysis](https://forum.polkadot.network/t/polkadot-release-analysis-v1-6-0/5855/2) #1841

* Setup deps * Remove Koi from account migration test * paritytech/polkadot-sdk#1495 * Bump * paritytech/polkadot-sdk#1524 * !! paritytech/polkadot-sdk#1363 * paritytech/polkadot-sdk#1492 * paritytech/polkadot-sdk#1911 * paritytech/polkadot-sdk#1900 Signed-off-by: Xavier Lau <[email protected]> * paritytech/polkadot-sdk#1661 * paritytech/polkadot-sdk#2144 * paritytech/polkadot-sdk#2048 * paritytech/polkadot-sdk#1672 * paritytech/polkadot-sdk#2303 * paritytech/polkadot-sdk#1256 * Remove identity and vesting * Fixes * paritytech/polkadot-sdk#2657 * paritytech/polkadot-sdk#1313 * paritytech/polkadot-sdk#2331 * paritytech/polkadot-sdk#2409 part.1 * paritytech/polkadot-sdk#2767 * paritytech/polkadot-sdk#2521 Signed-off-by: Xavier Lau <[email protected]> * paritytech/polkadot-sdk#1222 * paritytech/polkadot-sdk#1234 part.1 * Satisfy compiler * XCM V4 part.1 * paritytech/polkadot-sdk#1246 * Remove pallet-democracy part.1 * paritytech/polkadot-sdk#2142 * paritytech/polkadot-sdk#2428 * paritytech/polkadot-sdk#3228 * XCM V4 part.2 * Bump * Build all runtimes * Build node * Remove pallet-democracy Signed-off-by: Xavier Lau <[email protected]> * Format * Fix pallet tests * Fix precompile tests * Format * Fixes * Async, remove council, common pallet config * Fix `ethtx-forward` test case (#1519) * Fix ethtx-forward tests * Format * Fix following the review * Fixes * Fixes * Use default impl * Benchmark helper * Bench part.1 * Bench part.2 * Bench part.3 * Fix all tests * Typo * Feat * Fix EVM tracing build * Reuse upstream `proof_size_base_cost()` (#1521) * Format issue * Fixes * Fix CI --------- Signed-off-by: Xavier Lau <[email protected]> Co-authored-by: Bear Wang <[email protected]>

JoshOrndorff mentioned this pull request Nov 14, 2023

Stop using shell output redirects paritytech/zombienet#1515

Closed

bkchr reviewed Nov 15, 2023

View reviewed changes

This was referenced Nov 15, 2023

Cumulus's ExportGenesisState command does not respect custom GenesisBuilder implementations #2326

Closed

Explicitly specify a data directory when exporting parachain genesis state paritytech/zombienet#1519

Closed

JoshOrndorff changed the title ~~Attempt to Fix ExportGenesisState~~ RenameExportGenesisStateCommand to ExportGenesisHead and make it respect custom genesis block builders Nov 16, 2023

JoshOrndorff changed the title ~~RenameExportGenesisStateCommand to ExportGenesisHead and make it respect custom genesis block builders~~ Rename ExportGenesisStateCommand to ExportGenesisHeadCommand and make it respect custom genesis block builders Nov 16, 2023

Joshy Orndorff added 24 commits November 16, 2023 15:22

aura AAAaaa

6fb2596

println and 🤵 emojis

89e825b

move log line 🤦

238a7e0

hack the build-state command

59b2c8f

try again

f58981e

comment the old generate_genesis_block function

3caefa5

debugging in command

08365ff

duplicate error message (To test for async weirdness).

d456cd0

block backend

7c84b90

try to have debug output not conflict with actual exported head data

5e20abc

another log

c72c161

some more random debugging lines

e4ac486

comment idea to make logs more useful

ece683a

format previous head data as hex to better compare to relay state and…

cca6d02

… export-genesis-... command

Remove some logs

1b593f7

Remove some more logging

a8e8fb1

Remove panics

439a5d4

delete commented code

297e1bd

remove some more debugging and tracing

1f6a2f3

spelling

757dc51

fmt

85d39ac

Rename command

c187e00

update polkadot-parachain (but don't modify it's public CLI)

22136dc

Update template CLI preserving backward compatability

35d9518

bkchr reviewed Dec 13, 2023

View reviewed changes

cumulus/parachain-template/node/src/cli.rs Outdated Show resolved Hide resolved

bkchr and others added 4 commits December 13, 2023 08:40

Update cumulus/parachain-template/node/src/cli.rs

8da60f6

Remove the custom export genesis wasm command

1e528ee

Adds prdoc

4866c84

Merge branch 'master' into polkadot-v1.2.0-hack

1d5795b

bkchr enabled auto-merge (squash) December 13, 2023 08:29

FMT

0a21af5

bkchr merged commit 8683bbe into paritytech:master Dec 13, 2023

skunert mentioned this pull request Jan 9, 2024

Cumulus test service cleanup #2887

Merged

github-actions bot mentioned this pull request Feb 19, 2024

Update substrate/polkadot/cumulus from v1.3.0 to v1.6.0 moondance-labs/tanssi#419

Closed

fgamundi mentioned this pull request Feb 21, 2024

Polkadot v1.6.0 upgrade moondance-labs/tanssi#413

Merged

github-actions bot mentioned this pull request Mar 13, 2024

Update polkadot-sdk from v1.3.0 to v1.7.2 moonbeam-foundation/moonbeam#2703

Closed

Anny0nn mentioned this pull request Apr 1, 2024

Upgrade Polkadot SDK version to v1.6.0 AbstractedCo/InvArch#152

Merged

aurexav added a commit to darwinia-network/darwinia that referenced this pull request Jun 24, 2024

paritytech/polkadot-sdk#2331

655eaae

enddynayn mentioned this pull request Jun 27, 2024

chore(upgrade): v1.5.0 to v1.6.0 frequency-chain/frequency#2046

Merged

Aideepakchaudhary mentioned this pull request Oct 11, 2024

Feat: Polkadot v1.5 to v1.6 upgrade Cerebellum-Network/blockchain-node#440

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename `ExportGenesisStateCommand` to `ExportGenesisHeadCommand` and make it respect custom genesis block builders#2331

Rename `ExportGenesisStateCommand` to `ExportGenesisHeadCommand` and make it respect custom genesis block builders#2331
bkchr merged 53 commits intoparitytech:masterfrom
JoshOrndorff:polkadot-v1.2.0-hack

JoshOrndorff commented Nov 14, 2023 •

edited

Loading

Uh oh!

bkchr left a comment

Uh oh!

Uh oh!

JoshOrndorff commented Dec 13, 2023

Uh oh!

Polkadot-Forum commented Jan 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

JoshOrndorff commented Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bug Fix: Respecting custom genesis builder

Rename: It doesn't export state. It exports head data.

Uh oh!

bkchr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshOrndorff commented Dec 13, 2023

Uh oh!

Polkadot-Forum commented Jan 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JoshOrndorff commented Nov 14, 2023 •

edited

Loading