Merged
Conversation
joepetrowski
added
T0-node
KiChjang
pushed a commit
that referenced
this pull request
Sep 16, 2023
When adding this pallet to the [Coretime Chain](#1479), this dependency results in conflicting implementations (rustc error below). This toml change fixes it. ``` error: failed to run custom build command for `coretime-rococo-runtime v1.0.0 (/home/joe/parity/polkadot-sdk/cumulus/parachains/runtimes/coretime/coretime-rococo)` Caused by: process didn't exit successfully: `/home/joe/parity/polkadot-sdk/target/debug/build/coretime-rococo-runtime-7943703d2770a119/build-script-build` (exit status: 1) --- stdout Information that should be included in a bug report. Executing build command: RUSTFLAGS="-C target-cpu=mvp -C target-feature=-sign-ext -C link-arg=--export-table -Clink-arg=--export=__heap_base -C link-arg=--import-memory " SKIP_WASM_BUILD="" "/home/joe/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/cargo" "rustc" "--target=wasm32-unknown-unknown" "--manifest-path=/home/joe/parity/polkadot-sdk/target/debug/wbuild/coretime-rococo-runtime/Cargo.toml" "--color=always" "--profile" "release" Using rustc version: rustc 1.71.1 (eb26296b5 2023-08-03) --- stderr Compiling sp-io v23.0.0 (/home/joe/parity/polkadot-sdk/substrate/primitives/io) Compiling coretime-rococo-runtime v1.0.0 (/home/joe/parity/polkadot-sdk/cumulus/parachains/runtimes/coretime/coretime-rococo) error[E0152]: found duplicate lang item `panic_impl` --> /home/joe/parity/polkadot-sdk/substrate/primitives/io/src/lib.rs:1749:1 | 1749 | pub fn panic(info: &core::panic::PanicInfo) -> ! { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: the lang item is first defined in crate `std` (which `bitvec` depends on) = note: first definition in `std` loaded from /home/joe/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/wasm32-unknown-unknown/lib/libstd-67dfbacfb4b441ef.rlib = note: second definition in the local crate (`sp_io`) For more information about this error, try `rustc --explain E0152`. ```
bkontur
reviewed
Dec 18, 2023
cumulus/parachains/runtimes/coretime/coretime-rococo/src/lib.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
muharem
approved these changes
Dec 18, 2023
cumulus/parachains/runtimes/coretime/coretime-rococo/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
| /// We only waive fees for system functions, which these locations represent. | ||
| pub type WaivedLocations = ( | ||
| RelayOrOtherSystemParachains<AllSiblingSystemParachains, Runtime>, | ||
| Equals<RelayTreasuryLocation>, |
Contributor
There was a problem hiding this comment.
we might want to give free executions for local root / (0, here), and for parent pluralities. I do not see the exact use case for it now, since there no Fellows referenda for example triggering xcm execution with Fellows origin. But if there is a xcm program sent from relay chain on behalf of Fellows which causes another xcm message to be sent back, that wont be delivered, because of the fees.
Contributor
There was a problem hiding this comment.
For the parent plurality something like MultiLocation { parents: 1, interior: X1(Plurality { .. }) } or the ParentOrParentsPlurality used elsewhere which includes: MultiLocation { parents: 1, interior: Here } | MultiLocation { parents: 1, interior: X1(Plurality { .. }) }? The second just includes the parent root from what I understand, but do we want that in the situation you've just described?
cumulus/parachains/runtimes/coretime/coretime-westend/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/coretime/coretime-rococo/src/coretime.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Branislav Kontur <[email protected]>
…dk into joe-coretime-chain
Revert CurrencyAdapter changes and just mark as deprecated
…dk into joe-coretime-chain
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
When adding this pallet to the [Coretime Chain](paritytech#1479), this dependency results in conflicting implementations (rustc error below). This toml change fixes it. ``` error: failed to run custom build command for `coretime-rococo-runtime v1.0.0 (/home/joe/parity/polkadot-sdk/cumulus/parachains/runtimes/coretime/coretime-rococo)` Caused by: process didn't exit successfully: `/home/joe/parity/polkadot-sdk/target/debug/build/coretime-rococo-runtime-7943703d2770a119/build-script-build` (exit status: 1) --- stdout Information that should be included in a bug report. Executing build command: RUSTFLAGS="-C target-cpu=mvp -C target-feature=-sign-ext -C link-arg=--export-table -Clink-arg=--export=__heap_base -C link-arg=--import-memory " SKIP_WASM_BUILD="" "/home/joe/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/cargo" "rustc" "--target=wasm32-unknown-unknown" "--manifest-path=/home/joe/parity/polkadot-sdk/target/debug/wbuild/coretime-rococo-runtime/Cargo.toml" "--color=always" "--profile" "release" Using rustc version: rustc 1.71.1 (eb26296b5 2023-08-03) --- stderr Compiling sp-io v23.0.0 (/home/joe/parity/polkadot-sdk/substrate/primitives/io) Compiling coretime-rococo-runtime v1.0.0 (/home/joe/parity/polkadot-sdk/cumulus/parachains/runtimes/coretime/coretime-rococo) error[E0152]: found duplicate lang item `panic_impl` --> /home/joe/parity/polkadot-sdk/substrate/primitives/io/src/lib.rs:1749:1 | 1749 | pub fn panic(info: &core::panic::PanicInfo) -> ! { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: the lang item is first defined in crate `std` (which `bitvec` depends on) = note: first definition in `std` loaded from /home/joe/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/wasm32-unknown-unknown/lib/libstd-67dfbacfb4b441ef.rlib = note: second definition in the local crate (`sp_io`) For more information about this error, try `rustc --explain E0152`. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces paritytech/cumulus#2889
New runtimes for the Coretime Chain (a.k.a. "Broker Chain") described in RFC-1.
DevOps issue for Aura keygen: https://github.com/paritytech/devops/issues/2725
Edit (Dónal): This PR is mainly for Rococo, the Westend runtime is a shell with no
Brokerpallet. The Rococo runtime has the broker calls filtered for initial deployment.