Skip to content

[testnet] Align testnet system parachain runtimes using RelayTreasuryLocation and SystemParachains in the same way#2023

Merged
bkontur merged 9 commits intomasterfrom
bko-testnet-nits
Oct 25, 2023
Merged

[testnet] Align testnet system parachain runtimes using RelayTreasuryLocation and SystemParachains in the same way#2023
bkontur merged 9 commits intomasterfrom
bko-testnet-nits

Conversation

@bkontur
Copy link
Copy Markdown
Contributor

@bkontur bkontur commented Oct 25, 2023 •
edited
Loading

This PR addresses several issues:

@bkontur bkontur added the T9-cumulus This PR/Issue is related to cumulus. label Oct 25, 2023
@bkontur
Copy link
Copy Markdown
Contributor Author

bkontur commented Oct 25, 2023

bot bench cumulus-assets --runtime asset-hub-rococo --subcommand xcm --pallet pallet_xcm_benchmarks::fungible

command-bot and others added 2 commits October 25, 2023 09:58
".git/.scripts/commands/bench/bench.sh" --subcommand=xcm --runtime=as…
515e02b 
…set-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_benchmarks::fungible
@bkontur
Setup TrustedReserve on asset-hub-rococo
b4b5361
@bkontur
Copy link
Copy Markdown
Contributor Author

bkontur commented Oct 25, 2023

bot bench cumulus-assets --runtime asset-hub-rococo --subcommand xcm --pallet pallet_xcm_benchmarks::fungible

command-bot and others added 3 commits October 25, 2023 11:41
@bkontur
Copy link
Copy Markdown
Contributor Author

bkontur commented Oct 25, 2023

bot clean

@bkontur bkontur marked this pull request as ready for review October 25, 2023 13:12
@bkontur
Copy link
Copy Markdown
Contributor Author

bkontur commented Oct 25, 2023

bot fmt

@command-bot
Copy link
Copy Markdown

command-bot bot commented Oct 25, 2023 •
edited
Loading

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4080316 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 8-d23b1874-5300-4be8-9a1c-36aca4745281 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link
Copy Markdown

command-bot bot commented Oct 25, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4080316 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4080316/artifacts/download.

@bkontur bkontur enabled auto-merge (squash) October 25, 2023 13:30
@paritytech-cicd-pr
Copy link
Copy Markdown

paritytech-cicd-pr commented Oct 25, 2023

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4080594

franciscoaguirre
franciscoaguirre approved these changes Oct 25, 2023
View reviewed changes
...arachains/runtimes/assets/asset-hub-rococo/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs
// Storage: `System::Account` (r:2 w:2)
// Storage: `System::Account` (r:3 w:3)
// Proof: `System::Account` (`max_values`: None, `max_size`: Some(128), added: 2603, mode: `MaxEncodedLen`)
// Storage: UNKNOWN KEY `0x48297505634037ef48c848c99c0b1f1b` (r:1 w:0)
Copy link
Copy Markdown
Contributor

@franciscoaguirre franciscoaguirre Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with these unknown keys?

@bkontur bkontur merged commit f6560c2 into master Oct 25, 2023
@bkontur bkontur deleted the bko-testnet-nits branch October 25, 2023 15:35
ordian added a commit that referenced this pull request Oct 26, 2023
@ordian
Merge branch 'master' into tsv-disabling
5a6ad28 
* master:
  Removed TODO from test-case for hard-coded delivery fee estimation (#2042)
  Expose collection attributes from `Inspect` trait (#1914)
  `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897)
  [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023)
  Sort the benchmarks before listing them (#2026)
  publish pallet-root-testing (#2017)
  Contracts: Add benchmarks to include files (#2022)
  Small optimisation to `--profile dev` wasm builds (#1851)
  basic-authorship: Improve time recording and logging (#2010)
  Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815)
  [ci] Run check-rust-feature-propagation in pr and master (#2012)
  Improve features dev-ex (#1831)
  Remove obsolete comment. (#2008)
ordian added a commit that referenced this pull request Oct 26, 2023
@ordian
Merge branch 'tsv-disabling' into tsv-disabling-runtime
ff577a5 
* tsv-disabling:
  Removed TODO from test-case for hard-coded delivery fee estimation (#2042)
  Expose collection attributes from `Inspect` trait (#1914)
  `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897)
  [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023)
  Sort the benchmarks before listing them (#2026)
  publish pallet-root-testing (#2017)
  Contracts: Add benchmarks to include files (#2022)
  Small optimisation to `--profile dev` wasm builds (#1851)
  basic-authorship: Improve time recording and logging (#2010)
  Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815)
  [ci] Run check-rust-feature-propagation in pr and master (#2012)
  Improve features dev-ex (#1831)
  Remove obsolete comment. (#2008)
ordian added a commit that referenced this pull request Oct 26, 2023
@ordian
Merge branch 'tsv-disabling' into ao-disabling-statement-distribution
73ed217 
* tsv-disabling: (36 commits)
  Removed TODO from test-case for hard-coded delivery fee estimation (#2042)
  Expose collection attributes from `Inspect` trait (#1914)
  `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897)
  [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023)
  Sort the benchmarks before listing them (#2026)
  publish pallet-root-testing (#2017)
  Contracts: Add benchmarks to include files (#2022)
  Small optimisation to `--profile dev` wasm builds (#1851)
  basic-authorship: Improve time recording and logging (#2010)
  Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815)
  [ci] Run check-rust-feature-propagation in pr and master (#2012)
  Improve features dev-ex (#1831)
  Remove obsolete comment. (#2008)
  Refactor candidates test in paras_inherent (#2004)
  PVF: Add worker check during tests and benches (#1771)
  Bump actions/setup-node from 3.8.1 to 4.0.0 (#1997)
  polkadot: enable tikv-jemallocator/unprefixed_malloc_on_supported_platforms (#2002)
  Make `IdentityInfo` generic in `pallet-identity` (#1661)
  Ensure correct variant count in `Runtime[Hold/Freeze]Reason` (#1900)
  `CheckWeight`: Add more logging (#1996)
  ...
s0me0ne-unkn0wn pushed a commit that referenced this pull request Oct 29, 2023
@bkontur @s0me0ne-unkn0wn
[testnet] Align testnet system parachain runtimes using `RelayTreasur…
16b02ca 
…yLocation` and `SystemParachains` in the same way (#2023)

This PR addresses several issues:
- simplify referencing `RelayTreasuryLocation` without needing
additional `RelayTreasury` struct
- fix for referencing `SystemParachains` from parachain with `parents:
1` instead of `parents: 0`
- removed hard-coded constants and fix tests for `asset-hub-rococo`
which was merged to master after
#1726

---------

Co-authored-by: command-bot <>
EgorPopelyaev pushed a commit that referenced this pull request Nov 3, 2023
@bkontur @EgorPopelyaev
[testnet] Align testnet system parachain runtimes using `RelayTreasur…
bc5a768 
…yLocation` and `SystemParachains` in the same way (#2023)

This PR addresses several issues:
- simplify referencing `RelayTreasuryLocation` without needing
additional `RelayTreasury` struct
- fix for referencing `SystemParachains` from parachain with `parents:
1` instead of `parents: 0`
- removed hard-coded constants and fix tests for `asset-hub-rococo`
which was merged to master after
#1726

---------

Co-authored-by: command-bot <>
@EgorPopelyaev EgorPopelyaev mentioned this pull request Nov 6, 2023
Merged
acatangiu added a commit that referenced this pull request Nov 6, 2023
@EgorPopelyaev @bkontur
@Morganamilo @sergejparity @bkchr @serban300 @acatangiu @joepetrowski @svyatonik
Backport missing functionalities for cumulus (#2176)
e990078 
This PR backports missing PR's needed for 1.3.0 cumulus release:
#2042
#2139
#2129
#1967
#2021
#1887
#2023

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Lulu <morgan@parity.io>
Co-authored-by: Sergejs Kostjucenko <85877331+sergejparity@users.noreply.github.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Serban Iorga <serban@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
@bkontur bkontur mentioned this pull request Nov 10, 2023
Closed
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
Boost message delivery transaction priority (#2023)
f738049 
* reject delivery transactions with at least one obsolete message

* clippy

* boost priority of message delivery transactions: transaction with more messages has larger priority than the transaction with less messages

* apply review suggestion

* CallInfo::bundled_messages

* validate_does_not_boost_priority_of_message_delivery_transactons_with_too_many_messages

* clippy
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@acatangiu acatangiu acatangiu approved these changes

Assignees

No one assigned

Labels

T9-cumulus This PR/Issue is related to cumulus.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bkontur @paritytech-cicd-pr @franciscoaguirre @acatangiu