Add ci check for parity-publish and fix current check issues by Morganamilo · Pull Request #1887 · paritytech/polkadot-sdk

Morganamilo · 2023-10-16T13:34:44Z

No description provided.

ggwpez

Ci requires a format: bot fmt for example.

.github/workflows/check-publish.yml

substrate/bin/utils/chain-spec-builder/Cargo.toml

cumulus/parachains/runtimes/assets/test-utils/Cargo.toml

Morganamilo · 2023-10-16T15:08:45Z

bot fmt

command-bot · 2023-10-16T15:08:51Z

"$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" was queued.

Comment bot cancel 45-1a77df3d-b9b0-41d8-b5ae-42d931708ff5 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-16T15:09:04Z

@Morganamilo Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result:

ValidationError: "id" is required
ValidationError: "id" is required
{"message":{"base":["Reference not found"]}}

.github/workflows/check-publish.yml

ggwpez · 2023-10-25T18:13:11Z

Why is the Cargo.lock updated?
The UI tests fail because scale codec got updated.

bkchr · 2023-10-25T18:14:33Z

substrate/bin/node/cli/Cargo.toml

 default-run = "substrate-node"
 homepage = "https://substrate.io"
 repository.workspace = true
-publish = false


This should not be published!

They are deps of substrate so need to be published.

@kianenigma can we not just provide a link to the node stuff? And to the chain-spec-builder? (We can release the chain spec builder, when it doesn't depend on node-cli anymore)

Yeah sorry, I added these things as deps to substrate just to use Rust's intra-crate linking convenience rather than building proper links. You can remove the dependency, and fix the links. Although, it might be a bit iffy to fix them such that it works for both https://paritytech.github.io/ hosted docs and for docs.rs

For now feel free to not publish substrate as well. This is easier for us all and will solve your issue?

I will be moving substrate crate to a new developer_hub crate in an upcoming PR.

This new developer_hub cannot be published because of some other issues, so I am for now settling for the fact that developer_hub will always be publish = false and only accessible via https://paritytech.github.io/

bkchr

Not sure why you want to publish node cli

substrate/bin/node/executor/Cargo.toml

substrate/bin/node/primitives/Cargo.toml

Morganamilo · 2023-10-31T07:57:26Z

@bkchr I think we should be good to go now?

bkchr

I'm approving. But you need to set the licenses correctly and the renames can be reverted.

cumulus/pallets/aura-ext/Cargo.toml

cumulus/pallets/dmp-queue/Cargo.toml

cumulus/pallets/parachain-system/Cargo.toml

cumulus/pallets/xcmp-queue/Cargo.toml

cumulus/parachains/runtimes/assets/asset-hub-polkadot/Cargo.toml

cumulus/test/relay-sproof-builder/Cargo.toml

substrate/bin/node/inspect/Cargo.toml

cumulus/client/service/Cargo.toml

Morganamilo · 2023-10-31T17:20:26Z

@bkchr what should the licence be for minimal-runtime (substrate/bin/minimal/runtime)?

Co-authored-by: Sergejs Kostjucenko <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>

This PR backports missing PR's needed for 1.3.0 cumulus release: #2042 #2139 #2129 #1967 #2021 #1887 #2023 --------- Co-authored-by: Branislav Kontur <[email protected]> Co-authored-by: Lulu <[email protected]> Co-authored-by: Sergejs Kostjucenko <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Serban Iorga <[email protected]> Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Svyatoslav Nikolsky <[email protected]>

…ech#1887) Co-authored-by: Sergejs Kostjucenko <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>

* optimize justification before submit * fmt * spelling * clippy * fmt again * aaand compilation * clippy

enddynayn · 2024-06-12T14:00:32Z

why was the package renamed to staging-parachain-info?

Morganamilo added the A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Oct 16, 2023

Morganamilo marked this pull request as ready for review October 16, 2023 14:32

Morganamilo requested review from a team October 16, 2023 14:32

Morganamilo requested review from a team as code owners October 16, 2023 14:32

Morganamilo requested review from a team and paritytech-ci October 16, 2023 14:33

ggwpez approved these changes Oct 16, 2023

View reviewed changes

.github/workflows/check-publish.yml Outdated Show resolved Hide resolved

alvicsam requested changes Oct 16, 2023

View reviewed changes

.github/workflows/check-publish.yml Outdated Show resolved Hide resolved

paritytech-ci requested a review from a team October 16, 2023 14:37

mrcnski reviewed Oct 16, 2023

View reviewed changes

substrate/bin/utils/chain-spec-builder/Cargo.toml Show resolved Hide resolved

cumulus/parachains/runtimes/assets/test-utils/Cargo.toml Outdated Show resolved Hide resolved

Morganamilo force-pushed the morganamilo/cicheck branch 2 times, most recently from 67bcd74 to 3739f00 Compare October 17, 2023 10:32

Morganamilo requested a review from alvicsam October 17, 2023 10:32

Morganamilo enabled auto-merge (squash) October 17, 2023 14:57

Morganamilo requested a review from mrcnski October 19, 2023 17:00

mrcnski approved these changes Oct 20, 2023

View reviewed changes

sergejparity reviewed Oct 20, 2023

View reviewed changes

.github/workflows/check-publish.yml Show resolved Hide resolved

sergejparity reviewed Oct 20, 2023

View reviewed changes

.github/workflows/check-publish.yml Show resolved Hide resolved

Morganamilo force-pushed the morganamilo/cicheck branch from 3739f00 to dd7109e Compare October 25, 2023 11:41

paritytech-ci requested a review from a team October 25, 2023 11:42

Morganamilo requested a review from sergejparity October 25, 2023 11:52

alvicsam approved these changes Oct 25, 2023

View reviewed changes

Morganamilo disabled auto-merge October 25, 2023 12:14

chevdor approved these changes Oct 25, 2023

View reviewed changes

sergejparity approved these changes Oct 25, 2023

View reviewed changes

.github/workflows/check-publish.yml Outdated Show resolved Hide resolved

Morganamilo disabled auto-merge October 25, 2023 16:55

Morganamilo force-pushed the morganamilo/cicheck branch from 3397911 to c3f5501 Compare October 25, 2023 17:51

bkchr reviewed Oct 25, 2023

View reviewed changes

bkchr requested changes Oct 25, 2023

View reviewed changes

substrate/bin/node/executor/Cargo.toml Show resolved Hide resolved

substrate/bin/node/primitives/Cargo.toml Show resolved Hide resolved

ggwpez self-requested a review October 25, 2023 18:16

Revert main Cargo.lock changes

59fa737

ggwpez mentioned this pull request Oct 26, 2023

License information missing from many package Cargo.toml files #2043

Closed

52 tasks

Morganamilo added 5 commits October 31, 2023 07:00

Don't publish node

a375014

Don't publish executor

d8fd392

Don't publish node-primitives

d627606

Add missing license

33566e6

Merge remote-tracking branch 'origin/master' into morganamilo/cicheck

34758a3

Morganamilo requested a review from bkchr October 31, 2023 07:56

bkchr approved these changes Oct 31, 2023

View reviewed changes

Morganamilo added 3 commits October 31, 2023 17:03

Rename crates back

0f3075c

Fix licenses

9de066a

Merge branch 'master' into morganamilo/cicheck

7014f06

Fix readme

53c8540

Morganamilo merged commit 495d24d into master Oct 31, 2023

Morganamilo deleted the morganamilo/cicheck branch October 31, 2023 18:04

EgorPopelyaev pushed a commit that referenced this pull request Nov 3, 2023

Add ci check for parity-publish and fix current check issues (#1887)

33f7987

Co-authored-by: Sergejs Kostjucenko <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>

EgorPopelyaev mentioned this pull request Nov 6, 2023

Backport missing functionalities for cumulus #2176

Merged

bkchr pushed a commit that referenced this pull request Apr 10, 2024

optimize justification before submit (#1887)

1d6e8a9

* optimize justification before submit * fmt * spelling * clippy * fmt again * aaand compilation * clippy

acatangiu mentioned this pull request Oct 14, 2024

Crates missing licenses in Cargo.toml #1491

Closed

Conversation

Morganamilo commented Oct 16, 2023

Uh oh!

ggwpez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Morganamilo commented Oct 16, 2023

Uh oh!

command-bot bot commented Oct 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Oct 16, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ggwpez commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkchr Oct 25, 2023

Choose a reason for hiding this comment

Uh oh!

Morganamilo Oct 26, 2023

Choose a reason for hiding this comment

Uh oh!

bkchr Oct 26, 2023

Choose a reason for hiding this comment

Uh oh!

kianenigma Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bkchr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Morganamilo commented Oct 31, 2023

Uh oh!

bkchr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Morganamilo commented Oct 31, 2023

Uh oh!

enddynayn commented Jun 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

command-bot bot commented Oct 16, 2023 •

edited

Loading

ggwpez commented Oct 25, 2023 •

edited

Loading

kianenigma Oct 27, 2023 •

edited

Loading