Skip to content

CheckWeight: Add more logging#1996

Merged
bkchr merged 3 commits intomasterfrom
bkchr-check-weight-more-logging
Oct 24, 2023
Merged

CheckWeight: Add more logging#1996
bkchr merged 3 commits intomasterfrom
bkchr-check-weight-more-logging

Conversation

@bkchr
Copy link
Member

@bkchr bkchr commented Oct 23, 2023

This adds more logging to CheckWeight to get a better understanding why a transaction exhausts resources.

@bkchr
CheckWeight: Add more logging
eeb5dcc 
This adds more logging to `CheckWeight` to get a better understanding
why a transaction exhausts resources.
@bkchr bkchr added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Oct 23, 2023
@bkchr bkchr requested review from a team October 23, 2023 22:18
@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented Oct 23, 2023

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4054269

ggwpez
ggwpez approved these changes Oct 23, 2023
View reviewed changes
@bkchr bkchr enabled auto-merge (squash) October 24, 2023 09:05
@ggwpez
Copy link
Member

ggwpez commented Oct 24, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Oct 24, 2023 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4058407 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-bc9f49ae-547f-4e33-95b5-79ca93d4093f to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 24, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4058407 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4058407/artifacts/download.

@bkchr bkchr merged commit a5a2432 into master Oct 24, 2023
@bkchr bkchr deleted the bkchr-check-weight-more-logging branch October 24, 2023 09:55
ordian added a commit that referenced this pull request Oct 26, 2023
@ordian
Merge branch 'tsv-disabling' into ao-disabling-statement-distribution
73ed217 
* tsv-disabling: (36 commits)
  Removed TODO from test-case for hard-coded delivery fee estimation (#2042)
  Expose collection attributes from `Inspect` trait (#1914)
  `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897)
  [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023)
  Sort the benchmarks before listing them (#2026)
  publish pallet-root-testing (#2017)
  Contracts: Add benchmarks to include files (#2022)
  Small optimisation to `--profile dev` wasm builds (#1851)
  basic-authorship: Improve time recording and logging (#2010)
  Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815)
  [ci] Run check-rust-feature-propagation in pr and master (#2012)
  Improve features dev-ex (#1831)
  Remove obsolete comment. (#2008)
  Refactor candidates test in paras_inherent (#2004)
  PVF: Add worker check during tests and benches (#1771)
  Bump actions/setup-node from 3.8.1 to 4.0.0 (#1997)
  polkadot: enable tikv-jemallocator/unprefixed_malloc_on_supported_platforms (#2002)
  Make `IdentityInfo` generic in `pallet-identity` (#1661)
  Ensure correct variant count in `Runtime[Hold/Freeze]Reason` (#1900)
  `CheckWeight`: Add more logging (#1996)
  ...
s0me0ne-unkn0wn pushed a commit that referenced this pull request Oct 29, 2023
@bkchr @s0me0ne-unkn0wn
CheckWeight: Add more logging (#1996)
ec44584 
This adds more logging to `CheckWeight` to get a better understanding
why a transaction exhausts resources.
@kiltbot kiltbot mentioned this pull request Nov 7, 2023
Closed
@ahmadkaouk ahmadkaouk mentioned this pull request Nov 16, 2023
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@bkchr
CheckWeight: Add more logging (paritytech#1996)
c3a6bd6 
This adds more logging to `CheckWeight` to get a better understanding
why a transaction exhausts resources.
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
Run benchmarks for mock runtimes (#1996)
068f6f6 
* run benchmarks for pallet-bridge-grandpa mock runtime

* run benchmarks for pallet-bridge-relayers mock runtime

* run benchmarks for pallet-bridge-parachains mock runtime

* run benchmarks for pallet-bridge-messages mock runtime

* test benchmarks on mockj runtimes from CI

* clippy and spelling
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggwpez ggwpez ggwpez approved these changes

@acatangiu acatangiu acatangiu approved these changes

Assignees

No one assigned

Labels

T1-FRAME This PR/Issue is related to core FRAME, the framework.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bkchr @paritytech-cicd-pr @ggwpez @acatangiu @patriciobcs