stop turning on runtime-benchmarks in tests#1360
Closed
Conversation
Contributor
Author
|
Given that this is changing the CI do we have to do anything special to make the CI use the CI defined in this PR rather than master @alvicsam ? |
Contributor
Author
|
We'll make the changes in this PR: #1335 |
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
This was referenced Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/paritytech/ci_cd/issues/864
The
runtime-benchmarksis not just additive. As well as adding some additional useful benchmarking types, it also turns off certain functionality used in production:polkadot-sdk/polkadot/runtime/polkadot/src/lib.rs
Line 1136 in 8cfaad4
It is safer not to have this feature enabled for our main test runs. Not enabling this feature means that the code we are testing is closer to the code that production runs.
(Associated: There are tests that only run if the runtime-benchmarks feature is turned off: #1247 - we could have peppered the tests with different assertions as to what to assert for depending on whether runtime-benchmarks was turned on or not but did not seem that maintainable)