Skip to content

[ci] Remove runtime-benchmarks from tests#1335

Merged
alvicsam merged 10 commits intomasterfrom
as-ci6
Sep 4, 2023
Merged

[ci] Remove runtime-benchmarks from tests#1335
alvicsam merged 10 commits intomasterfrom
as-ci6

Conversation

@alvicsam
Copy link
Copy Markdown
Contributor

@alvicsam alvicsam commented Aug 31, 2023

@alvicsam alvicsam requested review from ggwpez and gilescope August 31, 2023 12:01
@paritytech-ci paritytech-ci requested review from a team August 31, 2023 12:02
@alvicsam alvicsam added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Sep 1, 2023
ggwpez
ggwpez approved these changes Sep 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this is actually going to run all benchmarking tests, but there is no good solution currently.

@gilescope
Copy link
Copy Markdown
Contributor

gilescope commented Sep 2, 2023

Ah cool didn't see this so created another: #1360 - snuk the extra benchmark tests into an existing job so little additional load on the CI. Also looks to me there's a few other locations we want to remove the feature from.

@gilescope gilescope mentioned this pull request Sep 2, 2023
Closed
alvicsam and others added 3 commits September 4, 2023 09:53
@paritytech-cicd-pr
Copy link
Copy Markdown

paritytech-cicd-pr commented Sep 4, 2023

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-additional-tests
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3548282

@alvicsam alvicsam marked this pull request as draft September 4, 2023 11:54
ggwpez
ggwpez approved these changes Sep 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the status of this? I think i actually need it for another MR…

@alvicsam
Copy link
Copy Markdown
Contributor Author

alvicsam commented Sep 4, 2023 •
edited
Loading

What is the status of this? I think i actually need it for another MR…

I tried to combine the benchmarks with another job but it takes too long. I moved it to a separate job and if pipeline succeeds we can merge it

@alvicsam alvicsam marked this pull request as ready for review September 4, 2023 13:52
altaua
altaua reviewed Sep 4, 2023
View reviewed changes
@alvicsam alvicsam enabled auto-merge (squash) September 4, 2023 14:15
@alvicsam alvicsam merged commit ddab715 into master Sep 4, 2023
@alvicsam alvicsam deleted the as-ci6 branch September 4, 2023 14:58
ordian added a commit that referenced this pull request Sep 6, 2023
@ordian
Merge branch 'master' into ao-try-fixing-zombienet-slashing
27f8a62 
* master: (24 commits)
  GHW for building and publishing docker images (#1391)
  pallet asset-conversion additional quote tests (#1371)
  Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables (#1226)
  Fix PRdoc check (#1419)
  Fix the wasm runtime substitute caching bug (#1416)
  Bump enumn from 0.1.11 to 0.1.12 (#1412)
  RFC 14: Improve locking mechanism for parachains (#1290)
  Add PRdoc check (#1408)
  fmt fixes (#1413)
  Enforce a decoding limit in MultiAssets (#1395)
  Remove dynamic dispatch using `Ext` (#1399)
  Remove redundant calls to `borrow()` (#1393)
  Get rid of polling in `WarpSync` (#1265)
  Bump actions/checkout from 3 to 4 (#1398)
  Bump thiserror from 1.0.47 to 1.0.48 (#1396)
  Move Relay-Specific Shared Code to One Place (#1193)
  rust docs: add simple analytics (#1377)
  Contracts: Update read_sandbox (#1390)
  Extract block announce validation from `ChainSync` (#1170)
  [ci] Remove runtime-benchmarks from tests (#1335)
  ...
Ank4n pushed a commit that referenced this pull request Sep 8, 2023
@alvicsam @ggwpez @Ank4n
[ci] Remove runtime-benchmarks from tests (#1335)
daf6141 
* [ci] Remove runtime-benchmarks from tests

* Update .gitlab/pipeline/test.yml

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* remove ing

* move benchmark tests to additional tests

* rm -q option

* try release profile

* use testnet profile

* move to a separate job

* rm dup

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
@alvicsam @ggwpez @Daanvdplas
[ci] Remove runtime-benchmarks from tests (#1335)
6b4b89e 
* [ci] Remove runtime-benchmarks from tests

* Update .gitlab/pipeline/test.yml

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* remove ing

* move benchmark tests to additional tests

* rm -q option

* try release profile

* use testnet profile

* move to a separate job

* rm dup

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@NachoPal NachoPal mentioned this pull request Oct 16, 2023
Merged
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggwpez ggwpez ggwpez approved these changes

+4 more reviewers

@chevdor chevdor chevdor approved these changes

@gilescope gilescope gilescope approved these changes

@juangirini juangirini juangirini approved these changes

@altaua altaua altaua approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alvicsam @gilescope @paritytech-cicd-pr @chevdor @juangirini @ggwpez @altaua