Skip to content

stop turning on runtime-benchmarks in tests #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gilescope wants to merge 1 commit into from
Closed

stop turning on runtime-benchmarks in tests #1360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .gitlab/pipeline/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ test-linux-stable:
--locked \
--release \
--no-fail-fast \
--features runtime-benchmarks,try-runtime,experimental \
--features try-runtime,experimental \
--partition count:${CI_NODE_INDEX}/${CI_NODE_TOTAL}
# run runtime-api tests with `enable-staging-api` feature on the 1st node
- if [ ${CI_NODE_INDEX} == 1 ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi
Expand Down Expand Up @@ -67,11 +67,13 @@ test-linux-oldkernel-stable:
# --locked \
# --release \
# --no-fail-fast \
# --features runtime-benchmarks,try-runtime \
# --features try-runtime \
# --partition count:${CI_NODE_INDEX}/${CI_NODE_TOTAL}
# # todo: add flacky-test collector

# for some reasons these tests fail if run with all tests
# We also include running the autogenerated benchmark tests here
# as we do not want to have runtime-benchmarks feature enabled in general.
test-linux-stable-additional-tests:
stage: test
extends:
Expand All @@ -87,7 +89,7 @@ test-linux-stable-additional-tests:
script:
- |
time cargo nextest run \
-E 'test(receive_rate_limit_is_enforced) + test(benchmark_block_works)' \
-E 'test(receive_rate_limit_is_enforced) + test(benchmark_block_works) + test(benchmark)' \
--workspace \
--locked \
--release \
Expand Down Expand Up @@ -116,7 +118,7 @@ test-linux-stable-slow:
--workspace \
--locked \
--release \
--features runtime-benchmarks,try-runtime
--features try-runtime
allow_failure: true

# takes about 1,5h without cache
Expand All @@ -139,7 +141,7 @@ test-linux-stable-slow:
# - time cargo test --workspace
# --locked
# --profile testnet
# --features=runtime-benchmarks,runtime-metrics,try-runtime --
# --features=runtime-metrics,try-runtime --
# --skip upgrade_version_checks_should_work

test-doc:
Expand Down