Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables by juangirini · Pull Request #1226 · paritytech/polkadot-sdk

juangirini · 2023-08-28T16:26:00Z

Fixes #147
Fixes #148

The pallet_balances dispatchables set_balance_deprecated and transfer were deprecated in paritytech/substrate#12951 and have now been removed.
Instead force_set_balance and transfer_allow_death should be used respectively.

paritytech-cicd-pr · 2023-08-29T13:35:08Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3474324

liamaharon · 2023-08-29T14:53:17Z

Have we done an impact assessment on the removal of transfer? I have a feeling it could break a lot of front-ends.

juangirini · 2023-08-29T15:16:20Z

There's no assessment. And yes, there might be some broken frontends if their code hasn't been updated since these dispatchables have been marked as deprecated 6 months ago.
We don't have a proactive way to let the implementors know about these kind of deprecations, there is an open discussion about it #182 (comment)

ggwpez · 2023-08-30T09:51:56Z

substrate/frame/balances/src/lib.rs

-			dest: AccountIdLookupOf<T>,
-			#[pallet::compact] value: T::Balance,
-		) -> DispatchResult {
-			let source = ensure_signed(origin)?;


The only thing that we could do is to always return an error with a message that the other call should be used.
But its unclean i think…

I feel like we missed an opportunity to mark this function as #[deprecated]. Maybe this would've clued people in that this extrinsic is going away...

There was a deprecation message, tagging #[deprecated] wouldn't have helped much here anyway as external calls don't get notified of it. See #182 (comment)

ggwpez · 2023-08-30T09:53:07Z

This definitely needs to go into the change log. Lets see if that works out with the labels.

juangirini · 2023-09-01T09:58:31Z

@jacogr to keep you in the loop that this change is comming

juangirini · 2023-09-06T11:52:43Z

bot fmt

command-bot · 2023-09-06T11:52:48Z

@juangirini https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3588093 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-c526aba0-fdda-477f-982f-0ec5ffc9f833 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-09-06T11:53:31Z

@juangirini Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3588093 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3588093/artifacts/download.

* master: (24 commits) GHW for building and publishing docker images (#1391) pallet asset-conversion additional quote tests (#1371) Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables (#1226) Fix PRdoc check (#1419) Fix the wasm runtime substitute caching bug (#1416) Bump enumn from 0.1.11 to 0.1.12 (#1412) RFC 14: Improve locking mechanism for parachains (#1290) Add PRdoc check (#1408) fmt fixes (#1413) Enforce a decoding limit in MultiAssets (#1395) Remove dynamic dispatch using `Ext` (#1399) Remove redundant calls to `borrow()` (#1393) Get rid of polling in `WarpSync` (#1265) Bump actions/checkout from 3 to 4 (#1398) Bump thiserror from 1.0.47 to 1.0.48 (#1396) Move Relay-Specific Shared Code to One Place (#1193) rust docs: add simple analytics (#1377) Contracts: Update read_sandbox (#1390) Extract block announce validation from `ChainSync` (#1170) [ci] Remove runtime-benchmarks from tests (#1335) ...

xlc · 2023-09-06T22:42:37Z

Is this a transction_version breaking change?
Is this going to impact existing Ledger app?

juangirini · 2023-09-07T07:20:43Z

Is this a transction_version breaking change? Is this going to impact existing Ledger app?

Yes, it is a transaction_version breaking change. And yes, it is going to impact existing apps that haven't yet updated to use the new dispatchables after the release of the Currency deprecation PR paritytech/substrate#12951
The recommendation is to migrate to the new force_set_balance and transfer_allow_death ASAP

* master: (28 commits) Adds base benchmark for do_tick in broker pallet (#1235) zombienet: use another collator image for the slashing test (#1386) Prevent a fail prdoc check to block (#1433) Fix nothing scheduled on session boundary (#1403) GHW for building and publishing docker images (#1391) pallet asset-conversion additional quote tests (#1371) Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables (#1226) Fix PRdoc check (#1419) Fix the wasm runtime substitute caching bug (#1416) Bump enumn from 0.1.11 to 0.1.12 (#1412) RFC 14: Improve locking mechanism for parachains (#1290) Add PRdoc check (#1408) fmt fixes (#1413) Enforce a decoding limit in MultiAssets (#1395) Remove dynamic dispatch using `Ext` (#1399) Remove redundant calls to `borrow()` (#1393) Get rid of polling in `WarpSync` (#1265) Bump actions/checkout from 3 to 4 (#1398) Bump thiserror from 1.0.47 to 1.0.48 (#1396) Move Relay-Specific Shared Code to One Place (#1193) ...

…ransfer` dispatchables (#1226) * remove deprecated dispatchables * update test * update tests * update tests * add prdocs * add prdoc * Update docs/prdoc/pr_1226.prdoc Co-authored-by: Chevdor <chevdor@users.noreply.github.com> * move prdoc file --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> Co-authored-by: Chevdor <chevdor@users.noreply.github.com>

transfer is undefined now for some reason (reason -> paritytech/polkadot-sdk#1226) replaced with trasferKeepAlive <img width="836" alt="image" src="https://github.com/paritytech/polkadot-testnet-faucet/assets/1177472/471be755-8160-45d6-82be-2fc3e2f6f080"> The reason is valid, as `transfer` was actually `transfer_allow_death`, while we supposed to use transfer_keep_alive from the start

…ransfer` dispatchables (paritytech#1226) * remove deprecated dispatchables * update test * update tests * update tests * add prdocs * add prdoc * Update docs/prdoc/pr_1226.prdoc Co-authored-by: Chevdor <chevdor@users.noreply.github.com> * move prdoc file --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> Co-authored-by: Chevdor <chevdor@users.noreply.github.com>

juangirini added 3 commits August 28, 2023 18:22

remove deprecated dispatchables

be30e7e

update test

f085aab

update tests

33ea65a

juangirini self-assigned this Aug 29, 2023

juangirini added the T2-pallets This PR/Issue is related to a particular pallet. label Aug 29, 2023

juangirini requested a review from a team August 29, 2023 07:45

Merge branch 'master' into jg/deprecate-set-balance-deprecated

4065d12

juangirini marked this pull request as ready for review August 29, 2023 07:46

paritytech-ci requested review from a team August 29, 2023 07:47

juangirini changed the title ~~Remove deprecated dispatchables~~ Remove deprecated pallet_balances's set_balance_deprecated and transfer dispatchables Aug 29, 2023

Merge branch 'master' into jg/deprecate-set-balance-deprecated

141d165

update tests

e09564f

juangirini removed request for a team August 30, 2023 07:41

Merge branch 'master' into jg/deprecate-set-balance-deprecated

d362ce3

ggwpez approved these changes Aug 30, 2023

View reviewed changes

ggwpez added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Aug 30, 2023

Merge branch 'master' into jg/deprecate-set-balance-deprecated

bf11c73

juangirini requested a review from a team August 30, 2023 10:03

boundless-forest mentioned this pull request Aug 31, 2023

Check the deprecated balances apis darwinia-network/darwinia#1247

Closed

Merge branch 'master' into jg/deprecate-set-balance-deprecated

57f22e0

ggwpez mentioned this pull request Sep 6, 2023

Balances::transfer will be removed polkadot-js/apps#9854

Closed

move prdoc file

72b3a0e

juangirini enabled auto-merge (squash) September 6, 2023 12:29

juangirini merged commit 68ab943 into master Sep 6, 2023

juangirini deleted the jg/deprecate-set-balance-deprecated branch September 6, 2023 13:06

This was referenced Sep 7, 2023

Update examples and tutorials for set_balance_deprecated polkadot-developers/substrate-docs#2056

Closed

Update examples and tutorials for transfer polkadot-developers/substrate-docs#2057

Closed

AlexD10S mentioned this pull request Sep 27, 2023

Replace transfer with transferAllowDeath paritytech/parachains-integration-tests#106

Open

mordamax mentioned this pull request Oct 17, 2023

Fix transfer on rococo paritytech/polkadot-testnet-faucet#353

Merged

jasl mentioned this pull request Oct 17, 2023

Upgrade polkadot-sdk to release-polkadot-v1.2.0 Phala-Network/phala-blockchain#1415

Merged

kiltbot mentioned this pull request Oct 19, 2023

[AUTOMATIC] Update Polkadot dependencies from 1.1.0 to 1.2.0 KILTprotocol/kilt-node#571

Closed

jasl mentioned this pull request Oct 26, 2023

Upgrade polkadot-sdk to release-polkadot-v1.2.0 Phala-Network/khala-parachain#307

Merged

ahmadkaouk mentioned this pull request Nov 16, 2023

Update polkadot-sdk from v.1.1.0 to v1.3.0 moonbeam-foundation/moonbeam#2565

Closed

pacoyang mentioned this pull request Dec 6, 2023

Fix transfer button disappearance polkadot-js/apps#10081

Merged

IkerAlus mentioned this pull request Jan 26, 2024

Mention Polkadot Sdk in the release polkadot-fellows/runtimes#157

Closed

bkchr pushed a commit that referenced this pull request Apr 10, 2024

fixed set_operational in GRANDPA pallet (#1226)

5beeb9b

ukint-vs mentioned this pull request Apr 17, 2024

feat: Update substrate to v1.2.0 gear-tech/gear#3898

Merged

This was referenced Jun 5, 2024

Update polkadot-sdk from v1.7.0 to v1.11.0 moondance-labs/tanssi#573

Closed

Update polkadot-sdk from v1.10.0 to v1.11.0 moondance-labs/tanssi#577

Closed

Conversation

juangirini commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paritytech-cicd-pr commented Aug 29, 2023

Uh oh!

liamaharon commented Aug 29, 2023

Uh oh!

juangirini commented Aug 29, 2023

Uh oh!

ggwpez Aug 30, 2023

Choose a reason for hiding this comment

Uh oh!

KiChjang Sep 1, 2023

Choose a reason for hiding this comment

Uh oh!

juangirini Sep 1, 2023

Choose a reason for hiding this comment

Uh oh!

ggwpez commented Aug 30, 2023

Uh oh!

juangirini commented Sep 1, 2023

Uh oh!

juangirini commented Sep 6, 2023

Uh oh!

command-bot bot commented Sep 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Sep 6, 2023

Uh oh!

xlc commented Sep 6, 2023

Uh oh!

juangirini commented Sep 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

juangirini commented Aug 28, 2023 •

edited

Loading

command-bot bot commented Sep 6, 2023 •

edited

Loading