Adds base benchmark for do_tick in broker pallet by gupnik · Pull Request #1235 · paritytech/polkadot-sdk

gupnik · 2023-08-29T04:24:49Z

The weight meter for do_tick should start with a base weight for all mandatory code paths. This PR adds a benchmark to compute the same.

gupnik · 2023-08-29T05:01:23Z

bot bench substrate-pallet --pallet=pallet_broker

command-bot · 2023-08-29T05:01:28Z

@gupnik https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3464928 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_broker. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 18-84fa2f69-f7d9-4f79-bd31-6544ebe57efe to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-08-29T05:04:51Z

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_broker has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3464928 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3464928/artifacts/download.

gupnik · 2023-08-31T06:37:11Z

bot bench substrate-pallet --pallet=pallet_broker

command-bot · 2023-08-31T06:37:15Z

@gupnik https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3507866 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_broker. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-b03cb1bc-9928-42ba-9be0-8d8c786584a9 to cancel this command or bot cancel to cancel all commands in this pull request.

…=dev --target_dir=substrate --pallet=pallet_broker

command-bot · 2023-08-31T07:15:18Z

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_broker has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3507866 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3507866/artifacts/download.

substrate/frame/broker/src/benchmarking.rs

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2023-09-04T08:35:08Z

bot bench substrate-pallet --pallet=pallet_broker

command-bot · 2023-09-04T08:35:12Z

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3547481 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_broker. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 18-3f71fb84-0490-46a2-8224-5e6e7da22fed to cancel this command or bot cancel to cancel all commands in this pull request.

…=dev --target_dir=substrate --pallet=pallet_broker

command-bot · 2023-09-04T09:09:56Z

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_broker has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3547481 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3547481/artifacts/download.

substrate/frame/broker/src/tick_impls.rs

gupnik · 2023-09-07T02:34:37Z

bot merge

command-bot · 2023-09-07T02:34:39Z

@gupnik Unknown command "merge". Refer to help docs and/or source code.

* master: (28 commits) Adds base benchmark for do_tick in broker pallet (#1235) zombienet: use another collator image for the slashing test (#1386) Prevent a fail prdoc check to block (#1433) Fix nothing scheduled on session boundary (#1403) GHW for building and publishing docker images (#1391) pallet asset-conversion additional quote tests (#1371) Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables (#1226) Fix PRdoc check (#1419) Fix the wasm runtime substitute caching bug (#1416) Bump enumn from 0.1.11 to 0.1.12 (#1412) RFC 14: Improve locking mechanism for parachains (#1290) Add PRdoc check (#1408) fmt fixes (#1413) Enforce a decoding limit in MultiAssets (#1395) Remove dynamic dispatch using `Ext` (#1399) Remove redundant calls to `borrow()` (#1393) Get rid of polling in `WarpSync` (#1265) Bump actions/checkout from 3 to 4 (#1398) Bump thiserror from 1.0.47 to 1.0.48 (#1396) Move Relay-Specific Shared Code to One Place (#1193) ...

* Adds base benchmark for do_tick * ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_broker * Update substrate/frame/broker/src/benchmarking.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update substrate/frame/broker/src/benchmarking.rs * ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_broker * Addresses review comment --------- Co-authored-by: command-bot <> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Adds base benchmark for do_tick

08a6560

gupnik added T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Aug 29, 2023

gupnik requested review from bkchr, gavofyork and ggwpez August 29, 2023 04:25

paritytech-ci requested review from a team August 29, 2023 04:26

gupnik added the I2-bug The node fails to follow expected behavior. label Aug 29, 2023

alvicsam mentioned this pull request Aug 29, 2023

Add production and release profile #1238

Closed

Merge branch 'master' into gupnik/broker-bench-update

86be257

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

2cd0eb5

…=dev --target_dir=substrate --pallet=pallet_broker

Merge branch 'master' into gupnik/broker-bench-update

24af3fb

ggwpez reviewed Sep 1, 2023

View reviewed changes

substrate/frame/broker/src/benchmarking.rs Outdated Show resolved Hide resolved

ggwpez reviewed Sep 1, 2023

View reviewed changes

substrate/frame/broker/src/benchmarking.rs Outdated Show resolved Hide resolved

gupnik and others added 4 commits September 4, 2023 10:33

Update substrate/frame/broker/src/benchmarking.rs

392ef92

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Merge branch 'master' into gupnik/broker-bench-update

7fdec57

Update substrate/frame/broker/src/benchmarking.rs

2be9d4e

Merge branch 'master' into gupnik/broker-bench-update

74c26ed

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

91a678f

…=dev --target_dir=substrate --pallet=pallet_broker

ggwpez reviewed Sep 4, 2023

View reviewed changes

substrate/frame/broker/src/tick_impls.rs Outdated Show resolved Hide resolved

Addresses review comment

29b46d9

ggwpez approved these changes Sep 6, 2023

View reviewed changes

franciscoaguirre approved these changes Sep 6, 2023

View reviewed changes

gupnik merged commit 91deee7 into master Sep 7, 2023

gupnik deleted the gupnik/broker-bench-update branch September 7, 2023 02:35

kiltbot mentioned this pull request Oct 19, 2023

[AUTOMATIC] Update Polkadot dependencies from 1.1.0 to 1.2.0 KILTprotocol/kilt-node#571

Closed

ahmadkaouk mentioned this pull request Nov 16, 2023

Update polkadot-sdk from v.1.1.0 to v1.3.0 moonbeam-foundation/moonbeam#2565

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds base benchmark for do_tick in broker pallet#1235

Adds base benchmark for do_tick in broker pallet#1235
gupnik merged 10 commits intomasterfrom
gupnik/broker-bench-update

gupnik commented Aug 29, 2023

Uh oh!

gupnik commented Aug 29, 2023

Uh oh!

command-bot bot commented Aug 29, 2023 •

edited

Loading

Uh oh!

command-bot bot commented Aug 29, 2023

Uh oh!

gupnik commented Aug 31, 2023

Uh oh!

command-bot bot commented Aug 31, 2023 •

edited

Loading

Uh oh!

command-bot bot commented Aug 31, 2023

Uh oh!

Uh oh!

Uh oh!

ggwpez commented Sep 4, 2023

Uh oh!

command-bot bot commented Sep 4, 2023 •

edited

Loading

Uh oh!

command-bot bot commented Sep 4, 2023

Uh oh!

Uh oh!

gupnik commented Sep 7, 2023

Uh oh!

command-bot bot commented Sep 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gupnik commented Aug 29, 2023

Uh oh!

gupnik commented Aug 29, 2023

Uh oh!

command-bot bot commented Aug 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Aug 29, 2023

Uh oh!

gupnik commented Aug 31, 2023

Uh oh!

command-bot bot commented Aug 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Aug 31, 2023

Uh oh!

Uh oh!

Uh oh!

ggwpez commented Sep 4, 2023

Uh oh!

command-bot bot commented Sep 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Sep 4, 2023

Uh oh!

Uh oh!

gupnik commented Sep 7, 2023

Uh oh!

command-bot bot commented Sep 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

command-bot bot commented Aug 29, 2023 •

edited

Loading

command-bot bot commented Aug 31, 2023 •

edited

Loading

command-bot bot commented Sep 4, 2023 •

edited

Loading