[unstable2507] Backport #10861#10877
Closed
paritytech-release-backport-bot[bot] wants to merge 1 commit intounstable2507from
Closed
[unstable2507] Backport #10861#10877paritytech-release-backport-bot[bot] wants to merge 1 commit intounstable2507from
paritytech-release-backport-bot[bot] wants to merge 1 commit intounstable2507from
Conversation
Author
|
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-10861-to-unstable2507
git worktree add --checkout .worktree/backport-10861-to-unstable2507 backport-10861-to-unstable2507
cd .worktree/backport-10861-to-unstable2507
git reset --hard HEAD^
git cherry-pick -x 2eb43506e24f8d19028b0d928c3039d2830e7572
git push --force-with-lease |
github-actions
bot
added
the
A3-backport
Member
|
This fix is only needed if #10635 was backported but it doesn't seem the case. |
…ddress` precompiles (#10861) I couldn't see where the weight is charged in those builtin pre-compiles and a quick test indicated that there's no charges implemented. Assuming those are compute-heavy functions, the missing weight charges seem like a serious DoS vector. --------- Signed-off-by: xermicus <cyrill@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 2eb4350)
pgherveou
force-pushed
the
backport-10861-to-unstable2507
branch
from
92d4c26 to
af1633f
Compare
Contributor
|
no need to backport here the bug was only introduced later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #10861 into
unstable2507from xermicus.See the documentation on how to use this bot.