[pallet-revive] weight charge in sr25519_verify and ecdsa_to_eth_address precompiles#10861
Conversation
Signed-off-by: xermicus <cyrill@parity.io>
xermicus
added
A4-backport-unstable2507
Member
Author
|
/cmd fmt |
Signed-off-by: xermicus <cyrill@parity.io>
Member
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
…time_dev --bump patch'
0xOmarA
approved these changes
Jan 21, 2026
marian-radu
approved these changes
Jan 21, 2026
Contributor
|
Yup, they're costly, sr25519 should cost like 45 microseconds on one CPU core. And ecdsa should be somewhat more expensive. |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-10861-to-unstable2507
git worktree add --checkout .worktree/backport-10861-to-unstable2507 backport-10861-to-unstable2507
cd .worktree/backport-10861-to-unstable2507
git reset --hard HEAD^
git cherry-pick -x 2eb43506e24f8d19028b0d928c3039d2830e7572
git push --force-with-lease |
paritytech-release-backport-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
…ddress` precompiles (#10861) I couldn't see where the weight is charged in those builtin pre-compiles and a quick test indicated that there's no charges implemented. Assuming those are compute-heavy functions, the missing weight charges seem like a serious DoS vector. --------- Signed-off-by: xermicus <cyrill@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 2eb4350)
|
Successfully created backport PR for |
EgorPopelyaev
pushed a commit
that referenced
this pull request
Jan 22, 2026
Backport #10861 into `stable2512` from xermicus. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Signed-off-by: xermicus <cyrill@parity.io> Co-authored-by: xermicus <cyrill@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
xermicus
removed
the
A4-backport-unstable2507
pgherveou
pushed a commit
that referenced
this pull request
Jan 22, 2026
…ddress` precompiles (#10861) I couldn't see where the weight is charged in those builtin pre-compiles and a quick test indicated that there's no charges implemented. Assuming those are compute-heavy functions, the missing weight charges seem like a serious DoS vector. --------- Signed-off-by: xermicus <cyrill@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 2eb4350)
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
arturgontijo
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Apr 1, 2026
Backport paritytech#10861 into `stable2512` from xermicus. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Signed-off-by: xermicus <cyrill@parity.io> Co-authored-by: xermicus <cyrill@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't see where the weight is charged in those builtin pre-compiles and a quick test indicated that there's no charges implemented. Assuming those are compute-heavy functions, the missing weight charges seem like a serious DoS vector.