[pallet-revive] remove unstable host function sr25519_verify#10635
[pallet-revive] remove unstable host function sr25519_verify#10635
Conversation
|
/cmd prdoc --audience runtime_dev --bump patch |
Differential Tests Results (PolkaVM)Specified Tests
Counts
FailuresThe test specifiers seen in this section have the format 'path::case_idx::compilation_mode' and they're compatible with the revive differential tests framework and can be specified to it directly in the same way that they're provided through the The failures are provided in an expandable section to ensure that the PR does not get polluted with information. Please click on the section below for more information Detailed Differential Tests Failure Information
|
Differential Tests Results (REVM)Specified Tests
Counts
FailuresThe test specifiers seen in this section have the format 'path::case_idx::compilation_mode' and they're compatible with the revive differential tests framework and can be specified to it directly in the same way that they're provided through the The failures are provided in an expandable section to ensure that the PR does not get polluted with information. Please click on the section below for more information Detailed Differential Tests Failure Information
|
There was a problem hiding this comment.
shouldn't we continue the approach used here
#9603
instead of rewriting this to solidity?
There was a problem hiding this comment.
I think both ways of testing are valid.
Using solidity contracts reduces the amount of code (check substrate/frame/revive/fixtures/sol_utils.rs in the PR you linked)
There was a problem hiding this comment.
No. We should prefer Solidity in my opinion. Because we can test both backends with one fixture this way.
…abled-host-functions-sr25519_verify2
Co-authored-by: Alexander Theißen <[email protected]>
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
fixes part of #8572