Skip to content

Revert new client#2153

Merged
svyatonik merged 2 commits intomasterfrom
revert-new-client
May 24, 2023
Merged

Revert new client#2153
svyatonik merged 2 commits intomasterfrom
revert-new-client

Conversation

@svyatonik
Copy link
Copy Markdown
Contributor

There is a couple of ongoing issues at our test deployments. And there were two major changes before we've noticed that:

  • new client
  • Substrate/Polkadot/Cumulus dependencies update.

I'll keep trying to reproduce issues locally, but it'd be better to know the cause of the issue - whether it is new client, or dependencies. So I suggest to revert new client temporarily and see if the issue will appear at our test deployments in next two days.

What we know so far:

  • sometimes RialtoParachain is not registered in Rialto, so it isn't producing and finalizing any blocks. I've fixed similar issue here, but now I don't see any timeout in logs, so probably some other issue;
  • there's something wrong with Rialto <> Millau bridge - when it breaks, it looks as follows:
bridges-bot
[[Alerting] Messages from Millau to Rialto are not being delivered](http://grafana.millau.brucke.link/d/relay-millau-to-rialto-messages/millau-to-rialto-message-sync-dashboard?tab=alert&viewPanel=10&orgId=1)
Millau Messages delivered to Rialto in last 5m: 0
[[Alerting] Messages from Rialto to Millau are not being delivered](http://grafana.millau.brucke.link/d/relay-rialto-to-millau-messages/rialto-to-millau-message-sync-dashboard?tab=alert&viewPanel=10&orgId=1)
Rialto Messages delivered to Millau in last 5m: 0
bridges-bot
[[Alerting] Rialto -> Millau messages are not detected by relay](http://grafana.millau.brucke.link/d/relay-rialto-to-millau-messages/rialto-to-millau-message-sync-dashboard?tab=alert&viewPanel=6&orgId=1)
Messages generated in last 5 minutes (Rialto -> Millau, 00000000): 0
[[Alerting] Millau -> Rialto messages are not detected by relay](http://grafana.millau.brucke.link/d/relay-millau-to-rialto-messages/millau-to-rialto-message-sync-dashboard?tab=alert&viewPanel=6&orgId=1)
Messages generated in last 5 minutes (Millau -> Rialto, 00000000): 0

So either relay can't read data from nodes (then the cause is the new client), or Rialto and Millau nodes are broken (then the cause is dependencies).

@svyatonik svyatonik added the A-chores Something that has to be done, as part of regular maintenance label May 24, 2023
@svyatonik svyatonik merged commit 17cf7b5 into master May 24, 2023
@svyatonik svyatonik deleted the revert-new-client branch May 24, 2023 07:31
svyatonik added a commit that referenced this pull request May 29, 2023
svyatonik added a commit that referenced this pull request May 30, 2023
* Revert "Revert new client (#2153)"

This reverts commit 17cf7b5.

* add comment re cache to CachingClient (#2162)

* do not wait for reader when sending items (#2163)

* Use unsync cache + async-aware sync primitives (#2164)

* use unsync cache + async-aware sync primitives

* clippy

* trigger CI

* Revert "trigger CI"

This reverts commit b5c1405.
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.24.2 to 1.25.0.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](https://github.com/tokio-rs/tokio/commits/tokio-1.25.0)

---
updated-dependencies:
- dependency-name: tokio
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
bkontur pushed a commit that referenced this pull request May 7, 2024
* Revert "Revert new client (#2153)"

This reverts commit 17cf7b5.

* add comment re cache to CachingClient (#2162)

* do not wait for reader when sending items (#2163)

* Use unsync cache + async-aware sync primitives (#2164)

* use unsync cache + async-aware sync primitives

* clippy

* trigger CI

* Revert "trigger CI"

This reverts commit b5c1405.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-chores Something that has to be done, as part of regular maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants