Do not wait for reader when sending subscription items#2163
Merged
svyatonik merged 1 commit intorevive-new-clientfrom May 29, 2023
Merged
Conversation
bkontur
approved these changes
May 29, 2023
acatangiu
approved these changes
May 29, 2023
svyatonik
added a commit
that referenced
this pull request
May 30, 2023
* Revert "Revert new client (#2153)" This reverts commit 17cf7b5. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405.
bkontur
pushed a commit
that referenced
this pull request
May 7, 2024
* Revert "Revert new client (#2153)" This reverts commit 17cf7b5. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this during code review. When sending subscription items to readers, we shall not wait block - if reader is not reading items (and the channel is full), we shall just drop the reader. It doesn't causes any issues now, but still this is a code bug.