Adds TracingCustomizer and HttpTracingCustomizer#978
Adds TracingCustomizer and HttpTracingCustomizer#978codefromthecrypt merged 4 commits intomasterfrom
Conversation
| /** | ||
| * This allows configuration plugins to collaborate on building an instance of {@link Tracing}. | ||
| * | ||
| * <p>Notably, this decouples framework-level configuration (such as {@link |
There was a problem hiding this comment.
It's not so obvious how these decouple the configuration. Maybe this can be used to decouple blah and blah by having each layer create its own customizer and applying them all to construct the final Tracing
There was a problem hiding this comment.
I think I might add a code example, as I'm struggling with words that don't also repeat the first sentence. Thanks for helping me think through this.
There was a problem hiding this comment.
I changed the wording instead. lemme know if this works.
|
I forgot to implement this in spring-beans also.. |
|
I added spring integration and tests. |
|
PS I think will need to follow up with an ExtraFieldsCustomizer for the same reason cc @marcingrzejszczak For example, one should be able to assign additional extra fields without changing the underlying default propagation mechanism |
This will allow you to change field setup without accidentally overriding the trace propagation format. Like #978, except for extra fields. I realize this dramatically simplifies our spring 2.5 variant of brave-webmvc-example along the way.
|
#981 for extra fields |
4 participants
Fixes #973