-
Notifications
You must be signed in to change notification settings - Fork 717
Adds TracingCustomizer and HttpTracingCustomizer #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /* | ||
| * Copyright 2013-2019 The OpenZipkin Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License | ||
| * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
| * or implied. See the License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package brave; | ||
|
|
||
| import brave.handler.FinishedSpanHandler; | ||
| import zipkin2.reporter.Reporter; | ||
|
|
||
| /** | ||
| * This allows configuration plugins to collaborate on building an instance of {@link Tracing}. | ||
| * | ||
| * <p>Notably, this decouples framework-level configuration (such as {@link | ||
| * Tracing.Builder#spanReporter(Reporter)}) from site-specific configuration (such as {@link | ||
| * Tracing.Builder#addFinishedSpanHandler(FinishedSpanHandler) additional finished span handlers}. | ||
| * | ||
| * <h3>Integration examples</h3> | ||
| * | ||
| * <p>In practice, a dependency injection tool applies a collection of these instances prior to | ||
| * {@link Tracing.Builder#build() building the tracing instance}. For example, an injected {@code | ||
| * List<TracingCustomizer>} parameter to a provider of {@link Tracing}. | ||
| * | ||
| * <p>Here are some examples, in alphabetical order: | ||
| * <pre><ul> | ||
| * <li><a href="https://dagger.dev/multibindings.html">Dagger Set Multibindings</a></li> | ||
| * <li><a href="http://google.github.io/guice/api-docs/latest/javadoc/com/google/inject/multibindings/Multibinder.html">Guice Set Multibinder</a></li> | ||
| * <li><a href="https://docs.spring.io/spring/docs/current/spring-framework-reference/core.html#beans-autowired-annotation">Spring Autowired Collections</a></li> | ||
| * </ul></pre> | ||
| * | ||
| * @since 5.7 | ||
| */ | ||
| public interface TracingCustomizer { | ||
| void customize(Tracing.Builder builder); | ||
| } | ||
47 changes: 47 additions & 0 deletions
47
instrumentation/http/src/main/java/brave/http/HttpTracingCustomizer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * Copyright 2013-2019 The OpenZipkin Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License | ||
| * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
| * or implied. See the License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package brave.http; | ||
|
|
||
| import brave.Tracing; | ||
| import brave.TracingCustomizer; | ||
|
|
||
| /** | ||
| * This allows configuration plugins to collaborate on building an instance of {@link HttpTracing}. | ||
| * | ||
| * <p>Notably, this decouples framework-level configuration (such as {@link | ||
| * HttpTracing.Builder#Builder(Tracing) the http tracing instance}) from site-specific configuration | ||
| * (such as {@link HttpTracing.Builder#clientParser(HttpClientParser) parsers}). | ||
| * | ||
| * <p>This also allows one object to customize both {@link Tracing}, via {@link TracingCustomizer}, | ||
| * and the http layer {@link HttpTracing}, by implementing both customizer interfaces. | ||
| * | ||
| * <h3>Integration examples</h3> | ||
| * | ||
| * <p>In practice, a dependency injection tool applies a collection of these instances prior to | ||
| * {@link HttpTracing.Builder#build() building the tracing instance}. For example, an injected | ||
| * {@code List<HttpTracingCustomizer>} parameter to a provider of {@link HttpTracing}. | ||
| * | ||
| * <p>Here are some examples, in alphabetical order: | ||
| * <pre><ul> | ||
| * <li><a href="https://dagger.dev/multibindings.html">Dagger Set Multibindings</a></li> | ||
| * <li><a href="http://google.github.io/guice/api-docs/latest/javadoc/com/google/inject/multibindings/Multibinder.html">Guice Set Multibinder</a></li> | ||
| * <li><a href="https://docs.spring.io/spring/docs/current/spring-framework-reference/core.html#beans-autowired-annotation">Spring Autowired Collections</a></li> | ||
| * </ul></pre> | ||
| * | ||
| * @see TracingCustomizer | ||
| * @since 5.7 | ||
| */ | ||
| public interface HttpTracingCustomizer { | ||
| void customize(HttpTracing.Builder builder); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not so obvious how these decouple the configuration. Maybe
this can be used to decouple blah and blah by having each layer create its own customizer and applying them all to construct the final TracingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I might add a code example, as I'm struggling with words that don't also repeat the first sentence. Thanks for helping me think through this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the wording instead. lemme know if this works.