Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions brave/src/main/java/brave/TracingCustomizer.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/*
* Copyright 2013-2019 The OpenZipkin Authors
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
* or implied. See the License for the specific language governing permissions and limitations under
* the License.
*/
package brave;

import brave.handler.FinishedSpanHandler;
import zipkin2.reporter.Reporter;

/**
* This allows configuration plugins to collaborate on building an instance of {@link Tracing}.
*
* <p>Notably, this decouples framework-level configuration (such as {@link
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not so obvious how these decouple the configuration. Maybe this can be used to decouple blah and blah by having each layer create its own customizer and applying them all to construct the final Tracing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I might add a code example, as I'm struggling with words that don't also repeat the first sentence. Thanks for helping me think through this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the wording instead. lemme know if this works.

* Tracing.Builder#spanReporter(Reporter)}) from site-specific configuration (such as {@link
* Tracing.Builder#addFinishedSpanHandler(FinishedSpanHandler) additional finished span handlers}.
*
* <h3>Integration examples</h3>
*
* <p>In practice, a dependency injection tool applies a collection of these instances prior to
* {@link Tracing.Builder#build() building the tracing instance}. For example, an injected {@code
* List<TracingCustomizer>} parameter to a provider of {@link Tracing}.
*
* <p>Here are some examples, in alphabetical order:
* <pre><ul>
* <li><a href="https://dagger.dev/multibindings.html">Dagger Set Multibindings</a></li>
* <li><a href="http://google.github.io/guice/api-docs/latest/javadoc/com/google/inject/multibindings/Multibinder.html">Guice Set Multibinder</a></li>
* <li><a href="https://docs.spring.io/spring/docs/current/spring-framework-reference/core.html#beans-autowired-annotation">Spring Autowired Collections</a></li>
* </ul></pre>
*
* @since 5.7
*/
public interface TracingCustomizer {
void customize(Tracing.Builder builder);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
/*
* Copyright 2013-2019 The OpenZipkin Authors
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
* or implied. See the License for the specific language governing permissions and limitations under
* the License.
*/
package brave.http;

import brave.Tracing;
import brave.TracingCustomizer;

/**
* This allows configuration plugins to collaborate on building an instance of {@link HttpTracing}.
*
* <p>Notably, this decouples framework-level configuration (such as {@link
* HttpTracing.Builder#Builder(Tracing) the http tracing instance}) from site-specific configuration
* (such as {@link HttpTracing.Builder#clientParser(HttpClientParser) parsers}).
*
* <p>This also allows one object to customize both {@link Tracing}, via {@link TracingCustomizer},
* and the http layer {@link HttpTracing}, by implementing both customizer interfaces.
*
* <h3>Integration examples</h3>
*
* <p>In practice, a dependency injection tool applies a collection of these instances prior to
* {@link HttpTracing.Builder#build() building the tracing instance}. For example, an injected
* {@code List<HttpTracingCustomizer>} parameter to a provider of {@link HttpTracing}.
*
* <p>Here are some examples, in alphabetical order:
* <pre><ul>
* <li><a href="https://dagger.dev/multibindings.html">Dagger Set Multibindings</a></li>
* <li><a href="http://google.github.io/guice/api-docs/latest/javadoc/com/google/inject/multibindings/Multibinder.html">Guice Set Multibinder</a></li>
* <li><a href="https://docs.spring.io/spring/docs/current/spring-framework-reference/core.html#beans-autowired-annotation">Spring Autowired Collections</a></li>
* </ul></pre>
*
* @see TracingCustomizer
* @since 5.7
*/
public interface HttpTracingCustomizer {
void customize(HttpTracing.Builder builder);
}