Conversation
Codecov Report
@@ Coverage Diff @@
## master #1436 +/- ##
============================================
- Coverage 57.61% 57.57% -0.05%
- Complexity 794 795 +1
============================================
Files 150 150
Lines 4287 4304 +17
Branches 460 464 +4
============================================
+ Hits 2470 2478 +8
- Misses 1606 1612 +6
- Partials 211 214 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1436 +/- ##
============================================
- Coverage 57.23% 57.12% -0.12%
- Complexity 777 779 +2
============================================
Files 148 148
Lines 4242 4259 +17
Branches 457 461 +4
============================================
+ Hits 2428 2433 +5
- Misses 1603 1611 +8
- Partials 211 215 +4
Continue to review full report at Codecov.
|
|
Lgtm I'd refactor what we have to use the customizers I guess |
|
@marcingrzejszczak Netflix needs this. Could you include it in 2.1.3. Thanks. @adriancole fyi |
|
Brave 5.7 is being released now. |
17fbff1 to
5745a66
Compare
|
this is now on a stable release. needs tests and docs.. not sure if you have time for it @marcingrzejszczak but I'm offline until monday. hoping to get this in (also 2.1) to unlock the secondary sampling thing nara's hoping to roll out. |
| for (FinishedSpanHandler finishedSpanHandlerFactory : this.finishedSpanHandlers) { | ||
| builder.addFinishedSpanHandler(finishedSpanHandlerFactory); | ||
| } | ||
| for (TracingCustomizer customizer : this.tracingCustomizers) { |
There was a problem hiding this comment.
ps without tests this is subtle. it is important these apply last as they can rejig the reporter config, something needed for secondary sampling to work. ex we want to flip default reporter to noop but reuse the normal reporter as a finished span handler. this stuff works when customizes hit last before build
|
bravo!
…On Fri, Sep 6, 2019 at 5:47 PM Marcin Grzejszczak ***@***.***> wrote:
Closed #1436
<#1436> via
3ab6ec2
<3ab6ec2>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1436?email_source=notifications&email_token=AAAPVV3PEOMP7L4HSAZSUUDQIIRJ5A5CNFSM4ISTBEKKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTPFXANY#event-2613801015>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAPVVYCI5IYGVQIHLFWQSTQIIRJ5ANCNFSM4ISTBEKA>
.
|
This adds hooks for new customizers that will be in Brave 5.7. As I'll
be offline for a day or two, if anyone wants to play with this they can.
We could just weave-in and document this, or we could retrofit some of
our existing stuff to configure itself via customizers instead (ex MDC
integration).
cc @devinsba