Skip to content

[OSDEV-1998] Update OS Hub platform header and footer.#626

Merged
mazursasha1990 merged 8 commits intomainfrom
OSDEV-1998-update-oshub-platform-header-footer
May 14, 2025
Merged

[OSDEV-1998] Update OS Hub platform header and footer.#626
mazursasha1990 merged 8 commits intomainfrom
OSDEV-1998-update-oshub-platform-header-footer

Conversation

@mazursasha1990
Copy link
Contributor

@mazursasha1990 mazursasha1990 commented May 13, 2025

OSDEV-1998 - [FE] Update OS Hub platform header & footer.

Changes made:

  • Added an additional "Data Cleaning Service" subheader to the "How It Works" > "Premium Features" section.
  • Updated the list of supported languages/countries under the "globe" icon (added support for Chinese and changed the order).
  • Removed the Twitter icon from the social media icons/links in the footer.

Screenshot from 2025-05-13 17-36-02
Screenshot from 2025-05-13 17-36-08

@mazursasha1990 mazursasha1990 self-assigned this May 13, 2025
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:44 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:44 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:44 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:44 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:44 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:44 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:44 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:44 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:44 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:44 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:44 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:44 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 marked this pull request as draft May 13, 2025 14:45
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:45 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:45 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:45 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:45 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:45 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:45 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:45 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 marked this pull request as ready for review May 13, 2025 14:57
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:59 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:59 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:59 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:59 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:59 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:59 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:59 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:59 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:59 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:59 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:59 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:59 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 14:59 — with GitHub Actions Inactive
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
doc/release/RELEASE-NOTES.md (1)

32-34: Fix markdown list indentation for sub-items

The nested list items under * [OSDEV-1998] are indented by 4 spaces, triggering markdownlint MD007 (expected indentation of 2). Please reduce the indentation from 4 to 2 spaces:

-    * Added an additional "Data Cleaning Service" subheader to the "How It Works" > "Premium Features" section.
-    * Updated the list of supported languages/countries under the "globe" icon (added support for Chinese and changed the order).
-    * Removed the Twitter icon from the social media icons/links in the footer.
+  * Added an additional "Data Cleaning Service" subheader to the "How It Works" > "Premium Features" section.
+  * Updated the list of supported languages/countries under the "globe" icon (added support for Chinese and changed the order).
+  * Removed the Twitter icon from the social media icons/links in the footer.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

32-32: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)


33-33: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)


34-34: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7495cb2 and 15181b6.

📒 Files selected for processing (6)
  • doc/release/RELEASE-NOTES.md (1 hunks)
  • src/react/src/__tests__/components/Footer.test.js (0 hunks)
  • src/react/src/components/AddLocationData.jsx (1 hunks)
  • src/react/src/components/Navbar/InternationalMenu.jsx (2 hunks)
  • src/react/src/components/Navbar/MobileInternationalMenu.jsx (1 hunks)
  • src/react/src/util/constants.jsx (3 hunks)
💤 Files with no reviewable changes (1)
  • src/react/src/tests/components/Footer.test.js
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/react/src/components/AddLocationData.jsx (1)
src/react/src/util/constants.jsx (4)
  • InfoLink (19-19)
  • InfoLink (19-19)
  • InfoPaths (25-66)
  • InfoPaths (25-66)
🪛 markdownlint-cli2 (0.17.2)
doc/release/RELEASE-NOTES.md

32-32: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)


33-33: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)


34-34: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: run-integration-test-code-quality
  • GitHub Check: run-flake8-linter
  • GitHub Check: run-dd-code-quality
  • GitHub Check: run-countries-code-quality
  • GitHub Check: run-contricleaner-code-quality
  • GitHub Check: get-base-branch-dd-cov
  • GitHub Check: get-base-branch-contricleaner-cov
  • GitHub Check: get-base-branch-countries-cov
  • GitHub Check: get-base-branch-django-cov
  • GitHub Check: run-django-code-quality
🔇 Additional comments (11)
src/react/src/components/Navbar/InternationalMenu.jsx (3)

51-57: LGTM: Chinese language support added correctly

The addition of Simplified Chinese to the language menu is implemented consistently with the same styling class as the Bengali link.


70-70: LGTM: Portuguese label correctly updated

Changing "Portuguese" to "Português" provides a more accurate native language representation.


77-77: LGTM: Turkish label correctly updated

Updating from "Türkiye" (country name) to "Türkçe" (language name) is more appropriate for a language selector.

src/react/src/util/constants.jsx (3)

28-28: LGTM: Key renamed while preserving value

The key was renamed from contribute to dataCleaningService while keeping the value 'data-cleaning-service' unchanged, ensuring URL consistency.


825-829: LGTM: Data Cleaning Service menu item added correctly

The "Data Cleaning Service" link has been properly added to the "Premium Features" section of the menu, pointing to the correct URL path.


1012-1012: LGTM: GitHub repository link corrected

The GitHub repository URL has been updated to the correct repository name: open-supply-hub instead of pyoshub.

src/react/src/components/AddLocationData.jsx (1)

121-121: LGTM: URL reference updated to match renamed constant

The URL reference has been updated to use InfoPaths.dataCleaningService instead of the old InfoPaths.contribute key, maintaining consistency with the changes in the constants file.

src/react/src/components/Navbar/MobileInternationalMenu.jsx (4)

62-66: LGTM: Chinese language support added to mobile menu

The mobile menu has been updated to include the Simplified Chinese language option with the correct URL and styling, maintaining consistency with the desktop menu.


70-75: LGTM: India link styled correctly

The India link has been properly styled with the lighter font weight class for consistency with other language options.


80-84: LGTM: Portuguese link updated correctly

The link has been updated to point to the Brazil page with the Portuguese language label, maintaining consistency with the desktop menu.


89-93: LGTM: Turkish link updated correctly

The link has been updated to point to the Turkey page with the Turkish language label (Türkçe), maintaining consistency with the desktop menu.

@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 15:02 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented May 13, 2025

React App | Jest test suite - Code coverage report

Total: 34.24%

Your code coverage diff: -0.01% ▾

✅ All code changes are covered

@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 15:06 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 15:07 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment May 13, 2025 15:08 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented May 13, 2025

Django App | Unittest test suite - Code coverage report

Total: 81.06%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

@Innavin369 Innavin369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vladsha-dev vladsha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
doc/release/RELEASE-NOTES.md (1)

33-35: Correct nested list indentation to satisfy markdownlint MD007
The sub-items under the * [OSDEV-1998] bullet are currently indented by 4 spaces, but the project’s lint rules expect 2 spaces per level. Please apply this diff:

@@ -32,6 +32,6 @@
 * [OSDEV-1998](https://opensupplyhub.atlassian.net/browse/OSDEV-1998) - The following changes were made:
-    * Added an additional "Data Cleaning Service" subheader to the "How It Works" > "Premium Features" section.
-    * Updated the list of supported languages/countries under the "globe" icon (added support for Chinese and changed the order).
-    * Removed the Twitter icon from the social media icons/links in the footer.
+  * Added an additional "Data Cleaning Service" subheader to the "How It Works" > "Premium Features" section.
+  * Updated the list of supported languages/countries under the "globe" icon (added support for Chinese and changed the order).
+  * Removed the Twitter icon from the social media icons/links in the footer.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

33-33: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)


34-34: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)


35-35: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7b2c72 and b29bb70.

📒 Files selected for processing (1)
  • doc/release/RELEASE-NOTES.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
doc/release/RELEASE-NOTES.md

33-33: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)


34-34: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)


35-35: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

⏰ Context from checks skipped due to timeout of 90000ms (13)
  • GitHub Check: run-integration-test-code-quality
  • GitHub Check: run-flake8-linter
  • GitHub Check: run-fe-code-quality
  • GitHub Check: run-eslint-linter-and-prettier-formatter
  • GitHub Check: run-django-code-quality
  • GitHub Check: run-dd-code-quality
  • GitHub Check: run-countries-code-quality
  • GitHub Check: run-contricleaner-code-quality
  • GitHub Check: get-base-branch-fe-cov
  • GitHub Check: get-base-branch-django-cov
  • GitHub Check: get-base-branch-dd-cov
  • GitHub Check: get-base-branch-countries-cov
  • GitHub Check: get-base-branch-contricleaner-cov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants