[OSDEV-1998] Update OS Hub platform header and footer.#626
[OSDEV-1998] Update OS Hub platform header and footer.#626mazursasha1990 merged 8 commits intomainfrom
Conversation
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
doc/release/RELEASE-NOTES.md (1)
32-34: Fix markdown list indentation for sub-itemsThe nested list items under
* [OSDEV-1998]are indented by 4 spaces, triggering markdownlint MD007 (expected indentation of 2). Please reduce the indentation from 4 to 2 spaces:- * Added an additional "Data Cleaning Service" subheader to the "How It Works" > "Premium Features" section. - * Updated the list of supported languages/countries under the "globe" icon (added support for Chinese and changed the order). - * Removed the Twitter icon from the social media icons/links in the footer. + * Added an additional "Data Cleaning Service" subheader to the "How It Works" > "Premium Features" section. + * Updated the list of supported languages/countries under the "globe" icon (added support for Chinese and changed the order). + * Removed the Twitter icon from the social media icons/links in the footer.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
32-32: Unordered list indentation
Expected: 2; Actual: 4(MD007, ul-indent)
33-33: Unordered list indentation
Expected: 2; Actual: 4(MD007, ul-indent)
34-34: Unordered list indentation
Expected: 2; Actual: 4(MD007, ul-indent)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
doc/release/RELEASE-NOTES.md(1 hunks)src/react/src/__tests__/components/Footer.test.js(0 hunks)src/react/src/components/AddLocationData.jsx(1 hunks)src/react/src/components/Navbar/InternationalMenu.jsx(2 hunks)src/react/src/components/Navbar/MobileInternationalMenu.jsx(1 hunks)src/react/src/util/constants.jsx(3 hunks)
💤 Files with no reviewable changes (1)
- src/react/src/tests/components/Footer.test.js
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/react/src/components/AddLocationData.jsx (1)
src/react/src/util/constants.jsx (4)
InfoLink(19-19)InfoLink(19-19)InfoPaths(25-66)InfoPaths(25-66)
🪛 markdownlint-cli2 (0.17.2)
doc/release/RELEASE-NOTES.md
32-32: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
33-33: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
34-34: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: run-integration-test-code-quality
- GitHub Check: run-flake8-linter
- GitHub Check: run-dd-code-quality
- GitHub Check: run-countries-code-quality
- GitHub Check: run-contricleaner-code-quality
- GitHub Check: get-base-branch-dd-cov
- GitHub Check: get-base-branch-contricleaner-cov
- GitHub Check: get-base-branch-countries-cov
- GitHub Check: get-base-branch-django-cov
- GitHub Check: run-django-code-quality
🔇 Additional comments (11)
src/react/src/components/Navbar/InternationalMenu.jsx (3)
51-57: LGTM: Chinese language support added correctlyThe addition of Simplified Chinese to the language menu is implemented consistently with the same styling class as the Bengali link.
70-70: LGTM: Portuguese label correctly updatedChanging "Portuguese" to "Português" provides a more accurate native language representation.
77-77: LGTM: Turkish label correctly updatedUpdating from "Türkiye" (country name) to "Türkçe" (language name) is more appropriate for a language selector.
src/react/src/util/constants.jsx (3)
28-28: LGTM: Key renamed while preserving valueThe key was renamed from
contributetodataCleaningServicewhile keeping the value'data-cleaning-service'unchanged, ensuring URL consistency.
825-829: LGTM: Data Cleaning Service menu item added correctlyThe "Data Cleaning Service" link has been properly added to the "Premium Features" section of the menu, pointing to the correct URL path.
1012-1012: LGTM: GitHub repository link correctedThe GitHub repository URL has been updated to the correct repository name:
open-supply-hubinstead ofpyoshub.src/react/src/components/AddLocationData.jsx (1)
121-121: LGTM: URL reference updated to match renamed constantThe URL reference has been updated to use
InfoPaths.dataCleaningServiceinstead of the oldInfoPaths.contributekey, maintaining consistency with the changes in the constants file.src/react/src/components/Navbar/MobileInternationalMenu.jsx (4)
62-66: LGTM: Chinese language support added to mobile menuThe mobile menu has been updated to include the Simplified Chinese language option with the correct URL and styling, maintaining consistency with the desktop menu.
70-75: LGTM: India link styled correctlyThe India link has been properly styled with the lighter font weight class for consistency with other language options.
80-84: LGTM: Portuguese link updated correctlyThe link has been updated to point to the Brazil page with the Portuguese language label, maintaining consistency with the desktop menu.
89-93: LGTM: Turkish link updated correctlyThe link has been updated to point to the Turkey page with the Turkish language label (Türkçe), maintaining consistency with the desktop menu.
React App | Jest test suite - Code coverage reportTotal: 34.24%Your code coverage diff: -0.01% ▾ ✅ All code changes are covered |
Django App | Unittest test suite - Code coverage reportTotal: 81.06%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
doc/release/RELEASE-NOTES.md (1)
33-35: Correct nested list indentation to satisfy markdownlint MD007
The sub-items under the* [OSDEV-1998]bullet are currently indented by 4 spaces, but the project’s lint rules expect 2 spaces per level. Please apply this diff:@@ -32,6 +32,6 @@ * [OSDEV-1998](https://opensupplyhub.atlassian.net/browse/OSDEV-1998) - The following changes were made: - * Added an additional "Data Cleaning Service" subheader to the "How It Works" > "Premium Features" section. - * Updated the list of supported languages/countries under the "globe" icon (added support for Chinese and changed the order). - * Removed the Twitter icon from the social media icons/links in the footer. + * Added an additional "Data Cleaning Service" subheader to the "How It Works" > "Premium Features" section. + * Updated the list of supported languages/countries under the "globe" icon (added support for Chinese and changed the order). + * Removed the Twitter icon from the social media icons/links in the footer.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
33-33: Unordered list indentation
Expected: 2; Actual: 4(MD007, ul-indent)
34-34: Unordered list indentation
Expected: 2; Actual: 4(MD007, ul-indent)
35-35: Unordered list indentation
Expected: 2; Actual: 4(MD007, ul-indent)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
doc/release/RELEASE-NOTES.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
doc/release/RELEASE-NOTES.md
33-33: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
34-34: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
35-35: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: run-integration-test-code-quality
- GitHub Check: run-flake8-linter
- GitHub Check: run-fe-code-quality
- GitHub Check: run-eslint-linter-and-prettier-formatter
- GitHub Check: run-django-code-quality
- GitHub Check: run-dd-code-quality
- GitHub Check: run-countries-code-quality
- GitHub Check: run-contricleaner-code-quality
- GitHub Check: get-base-branch-fe-cov
- GitHub Check: get-base-branch-django-cov
- GitHub Check: get-base-branch-dd-cov
- GitHub Check: get-base-branch-countries-cov
- GitHub Check: get-base-branch-contricleaner-cov



OSDEV-1998 - [FE] Update OS Hub platform header & footer.
Changes made: