Skip to content

[OSDEV-1831] Fix tooltip message for pending badge#563

Merged
VadimKovalenkoSNF merged 3 commits intomainfrom
OSDEV-1831-update-tooltip-text
Mar 18, 2025
Merged

[OSDEV-1831] Fix tooltip message for pending badge#563
VadimKovalenkoSNF merged 3 commits intomainfrom
OSDEV-1831-update-tooltip-text

Conversation

@VadimKovalenkoSNF
Copy link
Contributor

@VadimKovalenkoSNF VadimKovalenkoSNF commented Mar 18, 2025

Follow-up fix for OSDEV-1831

Changed tooltip text for pending badge if existing production location has pending claim status or has been claimed already.

@barecheck
Copy link

barecheck bot commented Mar 18, 2025

React App | Jest test suite - Code coverage report

Total: 33.12%

Your code coverage diff: 0.03% ▴

✅ All code changes are covered

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2025

📝 Walkthrough

Walkthrough

This pull request updates the tooltip messages associated with the Claim button on the Contribution Record page and refines related testing. The release notes document now reflects enhanced descriptions for tooltip text changes. In the production dialog component, the tooltip determination logic has been adjusted to handle multiple claim statuses. The tests for the ProductionLocationDialog have been expanded with a new mock and additional mouse event simulations, while minor formatting refinements were made in the RejectModerationEventDialog tests.

Changes

File(s) Change Summary
doc/release/RELEASE-NOTES.md Updated tooltip messages for the Claim button and pending badge, adding clarity for moderation statuses and aligning with the "Thanks for adding data for this production location" pop-up design.
src/react/…/ProductionLocationDialog.test.js
src/react/…/RejectModerationEventDialog.test.js
Expanded tests for tooltip behavior in ProductionLocationDialog with a new DialogTooltip mock and mouse events for PENDING, CLAIMED, and UNCLAIMED statuses; minor formatting adjustments in RejectModerationEventDialog tests.
src/react/…/Contribute/ProductionLocationDialog.jsx Introduced a data-testid attribute to the InfoOutlinedIcon, refactored getPendingTooltipText using destructured enum properties, and updated the tooltip logic to cover PENDING, CLAIMED, and default scenarios.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant D as ProductionLocationDialog
    participant T as Tooltip Component

    U->>D: Hover over Claim button
    D->>D: Evaluate claimStatus via getPendingTooltipText
    D->>T: Pass computed tooltip message
    T->>U: Display updated tooltip message
Loading

Possibly related PRs

Suggested reviewers

  • Innavin369
  • roman-stolar
  • mazursasha1990

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8619785 and 930c982.

📒 Files selected for processing (1)
  • src/react/src/__tests__/components/RejectModerationEventDialog.test.js (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/react/src/tests/components/RejectModerationEventDialog.test.js
⏰ Context from checks skipped due to timeout of 90000ms (13)
  • GitHub Check: run-integration-test-code-quality
  • GitHub Check: run-flake8-linter
  • GitHub Check: run-fe-code-quality
  • GitHub Check: run-eslint-linter-and-prettier-formatter
  • GitHub Check: run-django-code-quality
  • GitHub Check: run-dd-code-quality
  • GitHub Check: run-countries-code-quality
  • GitHub Check: run-contricleaner-code-quality
  • GitHub Check: get-base-branch-fe-cov
  • GitHub Check: get-base-branch-dd-cov
  • GitHub Check: get-base-branch-countries-cov
  • GitHub Check: get-base-branch-django-cov
  • GitHub Check: get-base-branch-contricleaner-cov

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@barecheck
Copy link

barecheck bot commented Mar 18, 2025

Dedupe Hub App | Unittest test suite - Code coverage report

Total: 56.14%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@sonarqubecloud
Copy link

Copy link
Contributor

@roman-stolar roman-stolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VadimKovalenkoSNF VadimKovalenkoSNF merged commit 6aee1a1 into main Mar 18, 2025
21 checks passed
@VadimKovalenkoSNF VadimKovalenkoSNF deleted the OSDEV-1831-update-tooltip-text branch March 18, 2025 09:17
protsack-stephan pushed a commit that referenced this pull request Apr 12, 2025
Follow-up fix for
[OSDEV-1831](https://opensupplyhub.atlassian.net/browse/OSDEV-1831)

Changed tooltip text for pending badge if existing production location
has pending claim status or has been claimed already.

[OSDEV-1831]:
https://opensupplyhub.atlassian.net/browse/OSDEV-1831?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants