[OSDEV-1701] - Refactor Go Back button

[VadimKovalenkoSNF]

Fix OSDEV-1701
Refactor "Go Back" button in production location info page.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request updates the release documentation for version 2.0.0, detailing significant changes including the addition of the action_perform_by field to the api_moderationevent table, the introduction of geo-bounding box query support for the production locations API, and the architectural split of the Django container into frontend and backend components. Additionally, it removes Redux functionality for managing search parameters in the React codebase, simplifying component logic by eliminating unused imports and props.

Changes

Files	Summary
doc/release/RELEASE-NOTES.md	Updated release notes for v2.0.0 with database changes (new field action_perform_by), code/API changes (geo-bounding box support), architectural changes (Django split), and bugfix for the "Go Back" button.
src/react/src/actions/searchParameters.js src/react/src/reducers/SearchParametersReducer.js src/react/src/reducers/index.js	Removed Redux integration for search parameters: deleted actions and reducer files, and updated the root reducer to eliminate search parameter state management.
src/react/src/components/Contribute/ProductionLocationInfo.jsx src/react/src/components/Contribute/SearchByNameAndAddressSuccessResult.jsx	Simplified component logic by removing unused imports and properties, replacing function calls (e.g., inline arrow function for history navigation), and removing Redux connect and related search parameter handling from the component props.

Possibly related PRs

• [OSDEV-1365] Disable claim button when moderation event on new productino location is REJECTED #497: The changes in the main PR regarding the ProductionLocationInfo.jsx component and the modifications in the retrieved PR related to the ProductionLocationDialog.jsx component both involve alterations to how claim statuses are handled, indicating a direct connection in their functionality.
• Updated RELEASE-NOTES.md file for 1.24 version #396: The changes in the main PR regarding the RELEASE-NOTES.md file for version 2.0.0 are related to the updates made in the retrieved PR for version 1.24.0, as both involve modifications to the same file and structure of release notes.
• [OSDEV-1558] Described that the action_type field was added to the moderation_events OpenSearch index. #499: The changes in the main PR regarding the addition of the action_perform_by field to the api_moderationevent table are related to the changes in the retrieved PR, which also involves modifications to the api_moderationevent table, specifically the addition of the action_type field.

Suggested reviewers

• Innavin369
• roman-stolar
• mazursasha1990

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/react/src/components/Contribute/SearchByNameAndAddressSuccessResult.jsx (1)

45-45: Remove unused dependency from useCallback.

The location dependency is included in the useCallback hook but is not used within the handleSelectLocation function. This could trigger unnecessary re-renders.

Apply this diff to remove the unused dependency:

-        [history, location],
+        [history],

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between afdcf9b and e088f7d.

📒 Files selected for processing (6)

• doc/release/RELEASE-NOTES.md (1 hunks)
• src/react/src/actions/searchParameters.js (0 hunks)
• src/react/src/components/Contribute/ProductionLocationInfo.jsx (2 hunks)
• src/react/src/components/Contribute/SearchByNameAndAddressSuccessResult.jsx (2 hunks)
• src/react/src/reducers/SearchParametersReducer.js (0 hunks)
• src/react/src/reducers/index.js (0 hunks)

💤 Files with no reviewable changes (3)

• src/react/src/reducers/index.js
• src/react/src/reducers/SearchParametersReducer.js
• src/react/src/actions/searchParameters.js

🧰 Additional context used

🪛 Biome (1.9.4)

src/react/src/components/Contribute/ProductionLocationInfo.jsx

[error] 7-7: Do not shadow the global "toString" property.

Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.

(lint/suspicious/noShadowRestrictedNames)

⏰ Context from checks skipped due to timeout of 90000ms (13)

• GitHub Check: run-integration-test-code-quality
• GitHub Check: run-flake8-linter
• GitHub Check: run-fe-code-quality
• GitHub Check: run-eslint-linter-and-prettier-formatter
• GitHub Check: run-django-code-quality
• GitHub Check: run-dd-code-quality
• GitHub Check: run-countries-code-quality
• GitHub Check: run-contricleaner-code-quality
• GitHub Check: get-base-branch-fe-cov
• GitHub Check: get-base-branch-dd-cov
• GitHub Check: get-base-branch-django-cov
• GitHub Check: get-base-branch-countries-cov
• GitHub Check: get-base-branch-contricleaner-cov

🔇 Additional comments (5)

src/react/src/components/Contribute/SearchByNameAndAddressSuccessResult.jsx (1)

146-148: LGTM!

The removal of Redux connection simplifies the component's state management and aligns with the PR's objective to refactor the component.

src/react/src/components/Contribute/ProductionLocationInfo.jsx (3)

1-1: Clean import statements!

Good job removing unused imports (useCallback, useRef, shape, omitBy, isNil) to keep the code clean.

Also applies to: 4-4, 7-7

---

743-743: Clean refactor of Go Back button!

Good simplification by replacing the handleGoBack function with an inline arrow function. Using history.goBack() is the idiomatic way to handle browser history navigation in React Router.

---

1-882: Verify Redux search parameter changes.

The AI summary mentions removal of Redux functionality for managing search parameters, but these changes are not visible in the provided code. Please verify if these changes were made in other files or if the summary needs to be updated.

Likely an incorrect or invalid review comment.

🧰 Tools

🪛 Biome (1.9.4)

[error] 7-7: Do not shadow the global "toString" property.

Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.

(lint/suspicious/noShadowRestrictedNames)

doc/release/RELEASE-NOTES.md (1)

54-54: Well-documented release notes!

The bugfix entry properly documents the Go Back button refactor with the corresponding JIRA ticket.

[barecheck]

React App | Jest test suite - Code coverage report

Total: 28.9%

Your code coverage diff: -0.06% ▾

✅ All code changes are covered

[barecheck]

Dedupe Hub App | Unittest test suite - Code coverage report

Total: 56.14%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

[barecheck]

Countries App | Unittest test suite - Code coverage report

Total: 100%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

[barecheck]

Contricleaner App | Unittest test suite - Code coverage report

Total: 98.91%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

[roman-stolar]

LGTM

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

doc/release/RELEASE-NOTES.md (1)

69-73: Verify post-deployment commands are executed in the correct order.

The release instructions include critical post-deployment commands that need to be executed in a specific order:

1. migrate - for database schema updates
2. reindex_database - for refreshing indexes

Additionally, the OpenSearch index mapping needs to be updated for the moderation-events index.

Consider adding these commands to an automated post-deployment script to ensure they are consistently executed in the correct order.

🧰 Tools

🪛 markdownlint-cli2 (0.17.2)

69-69: Trailing punctuation in heading
Punctuation: ':'

(MD026, no-trailing-punctuation)

---

71-71: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

---

72-72: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0bd45e and 2c3d2e2.

📒 Files selected for processing (1)

• doc/release/RELEASE-NOTES.md (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (13)

• GitHub Check: run-integration-test-code-quality
• GitHub Check: run-flake8-linter
• GitHub Check: run-eslint-linter-and-prettier-formatter
• GitHub Check: run-fe-code-quality
• GitHub Check: run-dd-code-quality
• GitHub Check: run-django-code-quality
• GitHub Check: run-countries-code-quality
• GitHub Check: run-contricleaner-code-quality
• GitHub Check: get-base-branch-dd-cov
• GitHub Check: get-base-branch-django-cov
• GitHub Check: get-base-branch-countries-cov
• GitHub Check: get-base-branch-contricleaner-cov
• GitHub Check: get-base-branch-fe-cov

🔇 Additional comments (2)

doc/release/RELEASE-NOTES.md (2)

64-64: Verify the bugfix description matches the implementation.

The bugfix entry for OSDEV-1701 only mentions "Refactored 'Go Back' button" without providing details about the changes. However, according to the AI summary, this change involves removing Redux functionality for managing search parameters. Consider expanding the description to include these important implementation details.

Likely an incorrect or invalid review comment.

---

34-35: Verify the impact of architectural changes.

The split of the Django container into frontend and backend components is a significant architectural change that could affect request handling and performance. Please ensure:

1. All listed endpoints are correctly redirected to the Django container
2. Frontend requests are properly handled by CDN
3. Resource allocation is optimized for both components

Run this script to verify the endpoint routing:

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Description: Verify that the listed endpoints are correctly configured to be handled by the Django container

# Test: Search for route configurations in the codebase
rg -A 2 "tile/|api/|api-auth/|api-token-auth/|api-feature-flags/|web/environment.js|admin/|health-check/|rest-auth/|user-login/|user-logout/|user-signup/|user-profile/|user-api-info/|static/admin/|static/django_extensions/|static/drf-yasg/|static/gis/|static/rest_framework/|static/static/|static/staticfiles.json"

Length of output: 70580

---

Endpoint Routing and CDN Configuration Verified

The search results confirm that:

• Terraform configurations (e.g., in deployment/terraform/cdn.tf and deployment/terraform/container_service.tf) explicitly define the routing rules for endpoints such as /api/*, /tile/*, /admin/*, and others.
• Django URL configurations in files like src/django/oar/urls.py correctly handle API endpoints and static assets.
• The release notes documentation aligns with the current endpoint patterns in both Terraform and Django, indicating the split between frontend (CDN-managed) and backend (Django container) responsibilities.

While resource allocation optimization is generally managed at the infrastructure level (e.g., container and ECS task definitions) and cannot be fully verified via static endpoint checks, the routing and redirection mechanisms are correctly implemented.

[mazursasha1990]

LGTM