Skip to content

[OSDEV-1626] SLC. Update URL for "Add Data" functionality on site to hide SLC entry point.#495

Merged
roman-stolar merged 7 commits intomainfrom
OSDEV-1626-update-url-for-add-data-to-old-list-upload-page-main
Jan 29, 2025
Merged

[OSDEV-1626] SLC. Update URL for "Add Data" functionality on site to hide SLC entry point.#495
roman-stolar merged 7 commits intomainfrom
OSDEV-1626-update-url-for-add-data-to-old-list-upload-page-main

Conversation

@roman-stolar
Copy link
Contributor

@roman-stolar roman-stolar commented Jan 29, 2025

OSDEV-1626 SLC. Update URL for "Add Data" functionality on site to hide SLC entry point.

  • Temporarily hid the new contribution page Add Location Data and re-enabled the old navigation to the List Upload page via the /contribute path.

… navigation to List Upload page by /contribute path.
…st-upload-page-main

# Conflicts:
#	doc/release/RELEASE-NOTES.md
…age' into OSDEV-1626-update-url-for-add-data-to-old-list-upload-page-main
@roman-stolar roman-stolar self-assigned this Jan 29, 2025
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:47 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:47 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:47 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:47 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:47 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:47 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:47 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:47 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:47 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:47 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:47 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:47 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:47 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:47 — with GitHub Actions Inactive
Copy link
Contributor

@VadimKovalenkoSNF VadimKovalenkoSNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link
Contributor

@mazursasha1990 mazursasha1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:50 — with GitHub Actions Inactive
@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2025

📝 Walkthrough

Walkthrough

This pull request introduces a new release section for version 1.28.1 in the RELEASE-NOTES.md file, which includes details about a bug fix related to the contribution page. The new contribution page titled "Add Location Data" has been temporarily hidden, and the old navigation to the "List Upload" page via the /contribute path has been re-enabled. Additionally, the routing configuration in Routes.jsx has been updated to remove the AddLocationData component and its associated route.

Changes

File Change Summary
doc/release/RELEASE-NOTES.md Added new release section 1.28.1 with product name, release date, and bug fix details
src/react/src/Routes.jsx Removed routes for AddLocationData and multipleLocationRoute components

Possibly related PRs

Suggested reviewers

  • Innavin369
  • vladsha-dev
  • mazursasha1990
  • VadimKovalenkoSNF

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 39d1c7f and aec9024.

📒 Files selected for processing (1)
  • doc/release/RELEASE-NOTES.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
doc/release/RELEASE-NOTES.md

44-44: Multiple headings with the same content
null

(MD024, no-duplicate-heading)

⏰ Context from checks skipped due to timeout of 90000ms (12)
  • GitHub Check: run-integration-test-code-quality
  • GitHub Check: run-flake8-linter
  • GitHub Check: run-dd-code-quality
  • GitHub Check: run-django-code-quality
  • GitHub Check: run-countries-code-quality
  • GitHub Check: run-contricleaner-code-quality
  • GitHub Check: get-base-branch-contricleaner-cov
  • GitHub Check: get-base-branch-fe-cov
  • GitHub Check: get-base-branch-countries-cov
  • GitHub Check: get-base-branch-dd-cov
  • GitHub Check: get-base-branch-django-cov
  • GitHub Check: run-fe-code-quality
🔇 Additional comments (1)
doc/release/RELEASE-NOTES.md (1)

42-50: LGTM! The release notes accurately document the changes.

The new release section 1.28.1 properly documents:

  • The release date
  • The bugfix entry for OSDEV-1626 that describes temporarily hiding the new contribution page and re-enabling old navigation
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

44-44: Multiple headings with the same content
null

(MD024, no-duplicate-heading)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@barecheck
Copy link

barecheck bot commented Jan 29, 2025

React App | Jest test suite - Code coverage report

Total: 28.37%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 13:54 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Jan 29, 2025

Django App | Unittest test suite - Code coverage report

Total: 80.38%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:39 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:39 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:39 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:39 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:39 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:39 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:39 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:39 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:39 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:39 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:39 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:39 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:39 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:39 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:41 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:45 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:46 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:46 — with GitHub Actions Inactive
@roman-stolar roman-stolar enabled auto-merge (squash) January 29, 2025 14:47
@roman-stolar roman-stolar temporarily deployed to Quality Environment January 29, 2025 14:56 — with GitHub Actions Inactive
@roman-stolar roman-stolar merged commit 6e44d7e into main Jan 29, 2025
21 checks passed
@roman-stolar roman-stolar deleted the OSDEV-1626-update-url-for-add-data-to-old-list-upload-page-main branch January 29, 2025 14:56
protsack-stephan pushed a commit that referenced this pull request Apr 12, 2025
…hide SLC entry point. (#495)

[OSDEV-1626](https://opensupplyhub.atlassian.net/browse/OSDEV-1626)
**SLC. Update URL for "Add Data" functionality on site to hide SLC entry
point.**

- Temporarily hid the new contribution page `Add Location Data` and
re-enabled the old navigation to the `List Upload` page via the
`/contribute` path.

[OSDEV-1626]:
https://opensupplyhub.atlassian.net/browse/OSDEV-1626?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants