added new release version to release notes, replace task, removed emp…#486
added new release version to release notes, replace task, removed emp…#486Innavin369 merged 1 commit intomainfrom
Conversation
…ty sections from the prev release
Innavin369
requested review from
VadimKovalenkoSNF,
mazursasha1990 and
vladsha-dev
and removed request for
VadimKovalenkoSNF and
vladsha-dev
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
|
📝 WalkthroughWalkthroughThe pull request updates the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
doc/release/RELEASE-NOTES.md (3)
12-17: Remove placeholder text from sections.The following sections contain placeholder text that should be replaced with actual changes:
- Database changes
- Code/API changes
- Architecture/Environment changes
- Bugfix
-* *Describe high-level database changes.* +* No database changes in this release. -* *Describe migrations here.* +* No migrations in this release. -* *Describe schema changes here.* +* No schema changes in this release. -* *Describe code/API changes here.* +* No code/API changes in this release. -* *Describe architecture/environment changes here.* +* No architecture/environment changes in this release. -* *Describe bugfix here.* +* No bugfixes in this release.Also applies to: 21-23, 24-26, 27-29
🧰 Tools
🪛 Markdownlint (0.37.0)
15-15: Punctuation: ':'
Trailing punctuation in heading(MD026, no-trailing-punctuation)
36-40: Add more context to the release instructions.While the commands are clear, it would be helpful to:
- Explain why these commands are necessary
- Specify the order of execution
- Add any prerequisites or post-verification steps
### Release instructions: * Ensure that the following commands are included in the `post_deployment` command: + * Run in the following order: * `migrate` + * Applies any pending database migrations * `reindex_database` + * Rebuilds the search index to include new changes + * After running the commands: + * Verify the search functionality is working correctly + * Check that the new search results page is accessible🧰 Tools
🪛 Markdownlint (0.37.0)
38-38: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
39-39: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
36-36: Punctuation: ':'
Trailing punctuation in heading(MD026, no-trailing-punctuation)
Line range hint
1-40: Fix markdown formatting issues.There are several markdown formatting inconsistencies:
- Unordered list indentation should be 2 spaces instead of 4
- Use consistent list markers (asterisks instead of dashes)
- Remove trailing colons from headings
-### Database changes: +### Database changes -### Release instructions: +### Release instructions - * `migrate` + * `migrate` - * `reindex_database` + * `reindex_database`🧰 Tools
🪛 Markdownlint (0.37.0)
32-32: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
33-33: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
34-34: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
32-32: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
33-33: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
34-34: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
38-38: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
39-39: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
44-44: null
Multiple headings with the same content(MD024, no-duplicate-heading)
15-15: Punctuation: ':'
Trailing punctuation in heading(MD026, no-trailing-punctuation)
36-36: Punctuation: ':'
Trailing punctuation in heading(MD026, no-trailing-punctuation)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
doc/release/RELEASE-NOTES.md(2 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
doc/release/RELEASE-NOTES.md
32-32: Expected: asterisk; Actual: dash
Unordered list style
(MD004, ul-style)
33-33: Expected: asterisk; Actual: dash
Unordered list style
(MD004, ul-style)
34-34: Expected: asterisk; Actual: dash
Unordered list style
(MD004, ul-style)
32-32: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
33-33: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
34-34: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
38-38: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
39-39: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
15-15: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
36-36: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: run-integration-test-code-quality
- GitHub Check: run-flake8-linter
- GitHub Check: run-fe-code-quality
- GitHub Check: run-eslint-linter-and-prettier-formatter
- GitHub Check: run-django-code-quality
- GitHub Check: run-dd-code-quality
- GitHub Check: run-countries-code-quality
- GitHub Check: run-contricleaner-code-quality
- GitHub Check: get-base-branch-fe-cov
- GitHub Check: get-base-branch-contricleaner-cov
- GitHub Check: get-base-branch-django-cov
- GitHub Check: get-base-branch-countries-cov
- GitHub Check: get-base-branch-dd-cov
🔇 Additional comments (1)
doc/release/RELEASE-NOTES.md (1)
30-34: LGTM! Clear description of the new search results page implementation.The section provides good details about:
- The integration with
GET v1/production-locations- The routing configuration between search-related pages
- The maximum result limit setting
🧰 Tools
🪛 Markdownlint (0.37.0)
32-32: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
33-33: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
34-34: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
32-32: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
33-33: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
34-34: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
React App | Jest test suite - Code coverage reportTotal: 28.37%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Dedupe Hub App | Unittest test suite - Code coverage reportTotal: 56.14%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Contricleaner App | Unittest test suite - Code coverage reportTotal: 98.91%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Countries App | Unittest test suite - Code coverage reportTotal: 100%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Django App | Unittest test suite - Code coverage reportTotal: 80.16%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
#486) Added new 1.29.0 release version to the Release notes, replaced task OSDEV-1374 from 1.28 to 1.29 section, and removed empty sections from the previous 1.28 release. Co-authored-by: Inessa Druzhkova <[email protected]>
3 participants
Added new 1.29.0 release version to the Release notes, replaced task OSDEV-1374 from 1.28 to 1.29 section, and removed empty sections from the previous 1.28 release.